From 0de0e3bc53103d29443f9cc8dc700a87d4bd7f27 Mon Sep 17 00:00:00 2001 From: marinoborges <39623860+marinoborges@users.noreply.github.com> Date: Thu, 9 Oct 2025 00:42:49 -0300 Subject: [PATCH 1/2] Set APIVersion:v1 for node events --- .../k8sexporter/problemclient/problem_client.go | 1 + .../k8sexporter/problemclient/problem_client_test.go | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/pkg/exporters/k8sexporter/problemclient/problem_client.go b/pkg/exporters/k8sexporter/problemclient/problem_client.go index 03f6bf37..a75f0704 100644 --- a/pkg/exporters/k8sexporter/problemclient/problem_client.go +++ b/pkg/exporters/k8sexporter/problemclient/problem_client.go @@ -157,6 +157,7 @@ func getEventRecorder(c typedcorev1.CoreV1Interface, namespace, nodeName, source func getNodeRef(namespace, nodeName string) *v1.ObjectReference { // TODO(random-liu): Get node to initialize the node reference return &v1.ObjectReference{ + APIVersion: "v1", Kind: "Node", Name: nodeName, UID: types.UID(nodeName), diff --git a/pkg/exporters/k8sexporter/problemclient/problem_client_test.go b/pkg/exporters/k8sexporter/problemclient/problem_client_test.go index 5552d58e..e8a304b8 100644 --- a/pkg/exporters/k8sexporter/problemclient/problem_client_test.go +++ b/pkg/exporters/k8sexporter/problemclient/problem_client_test.go @@ -85,3 +85,13 @@ func TestEvent(t *testing.T) { t.Errorf("expected event %q, got %q", expected, got) } } + +func TestNodeRefHasAPIVersionV1(t *testing.T) { + eventNamespace := "default" + nodeName := "fake-node" + client := newFakeProblemClient(eventNamespace, nodeName) + + if client.nodeRef.APIVersion != "v1" { + t.Errorf("expected nodeRef.APIVersion to be 'v1', got %q", client.nodeRef.APIVersion) + } +} From 6d71278653cb144551ec9d7fd56ce623319603e9 Mon Sep 17 00:00:00 2001 From: marinoborges <39623860+marinoborges@users.noreply.github.com> Date: Mon, 13 Oct 2025 16:36:03 -0300 Subject: [PATCH 2/2] Fix newFakeProblemClient call --- .../k8sexporter/problemclient/problem_client_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/exporters/k8sexporter/problemclient/problem_client_test.go b/pkg/exporters/k8sexporter/problemclient/problem_client_test.go index e8a304b8..244212af 100644 --- a/pkg/exporters/k8sexporter/problemclient/problem_client_test.go +++ b/pkg/exporters/k8sexporter/problemclient/problem_client_test.go @@ -87,9 +87,7 @@ func TestEvent(t *testing.T) { } func TestNodeRefHasAPIVersionV1(t *testing.T) { - eventNamespace := "default" - nodeName := "fake-node" - client := newFakeProblemClient(eventNamespace, nodeName) + client := newFakeProblemClient() if client.nodeRef.APIVersion != "v1" { t.Errorf("expected nodeRef.APIVersion to be 'v1', got %q", client.nodeRef.APIVersion)