From 3868f4858605429ff3279e52f762010d2e278e53 Mon Sep 17 00:00:00 2001 From: gkGaneshR Date: Fri, 2 Mar 2018 21:49:07 +0530 Subject: [PATCH] Include cmd/options in Makefile's test 1. Why is this change necessary ? Solves kubernetes/node-problem-detector#163 2. How does this change address the issue ? Unit testing for node-problem-detector/cmd/options is yet to be done and the corresponding package path needs to be included in makefile test 3. How to verify this change ? make test command should run the test TestSetNodeNameOrDie with admin privileges. Signed-off-by: gkGaneshR --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1e9a08a8..c6f79881 100644 --- a/Makefile +++ b/Makefile @@ -87,7 +87,7 @@ Dockerfile: Dockerfile.in sed -e 's|@BASEIMAGE@|$(BASEIMAGE)|g' $< >$@ test: vet fmt - go test -timeout=1m -v -race ./pkg/... $(BUILD_TAGS) + go test -timeout=1m -v -race ./cmd/options ./pkg/... $(BUILD_TAGS) build-container: ./bin/node-problem-detector Dockerfile docker build -t $(IMAGE) .