From babc9095efd3d50cfa4237f92c583cc276a8420b Mon Sep 17 00:00:00 2001
From: Jean-Philippe Evrard <open-source@a.spamming.party>
Date: Tue, 6 Apr 2021 15:26:07 +0200
Subject: [PATCH] Update github actions

Without this patch, github actions are lagging behind.
This should improve our coverage.
---
 .github/workflows/on-pr-charts.yaml | 2 +-
 .github/workflows/on-pr.yaml        | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/on-pr-charts.yaml b/.github/workflows/on-pr-charts.yaml
index 9b2d04e..68574cc 100644
--- a/.github/workflows/on-pr-charts.yaml
+++ b/.github/workflows/on-pr-charts.yaml
@@ -37,5 +37,5 @@ jobs:
         uses: helm/kind-action@v1.1.0
         if: ${{ matrix.test-action == 'install' }}
 
-      - name: Run chart tests 
+      - name: Run chart tests
         run: ct ${{ matrix.test-action }} --config .github/ct.yaml
diff --git a/.github/workflows/on-pr.yaml b/.github/workflows/on-pr.yaml
index 7f0beb3..6f9af20 100644
--- a/.github/workflows/on-pr.yaml
+++ b/.github/workflows/on-pr.yaml
@@ -84,12 +84,13 @@ jobs:
         with:
           image-name: docker.io/${{ github.repository_owner }}/kured:${{ github.sha }}
 
-  # If the PRs don't break the behaviour in the helm chart, we can simply publish the helm chart at the time of the release.
+  # If the PRs don't break the behaviour in the helm chart, we can simply publish the helm charts at the time of a branch commit.
   e2e-helm:
     name: "Functional test of helm chart, e2e testing"
     runs-on: ubuntu-latest
     # only build with oldest and newest supported, it should be good enough.
     strategy:
+      fail-fast: false
       matrix:
         kubernetes:
           - "1.18"
@@ -161,13 +162,14 @@ jobs:
   # This workflow is useful when introducing new versions, to ensure our manifests
   # still work (even if there might be no manifest 'code' change).
   # The version used here is what hasn't been tested with the helm chart
+  # This should therefore be "mid version" and (optionally) next new version
   deploy-manifests:
     name: Deploy kured with current manifests
     runs-on: ubuntu-latest
     strategy:
       matrix:
         kubernetes:
-          - 1.18
+          - "1.19"
     steps:
       - uses: actions/checkout@v2
       - name: Find go version