From de3593799fc71ff50437d2991d63ef56a5175f5b Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Wed, 17 Apr 2019 13:21:50 +0200 Subject: [PATCH] Move image to Docker Hub --- .circleci/config.yml | 2 +- Makefile | 8 ++++---- README.md | 2 +- kured-ds.yaml | 8 ++++---- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a1aca2c..a587a71 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -12,7 +12,7 @@ jobs: - deploy: name: Build and push image command: | - docker login -u "$DOCKER_USER" -p "$DOCKER_PASS" quay.io + echo "$DOCKER_PASS" | docker login --username "$DOCKER_USER" --password-stdin if [ -z "${CIRCLE_TAG}" ]; then make publish-image else diff --git a/Makefile b/Makefile index e8779ca..1e1a726 100644 --- a/Makefile +++ b/Makefile @@ -23,14 +23,14 @@ cmd/kured/kured: cmd/kured/*.go build/.image.done: cmd/kured/Dockerfile cmd/kured/kured mkdir -p build cp $^ build - $(SUDO) docker build -t quay.io/$(DH_ORG)/kured -f build/Dockerfile ./build - $(SUDO) docker tag quay.io/$(DH_ORG)/kured quay.io/$(DH_ORG)/kured:$(VERSION) + $(SUDO) docker build -t docker.io/$(DH_ORG)/kured -f build/Dockerfile ./build + $(SUDO) docker tag docker.io/$(DH_ORG)/kured docker.io/$(DH_ORG)/kured:$(VERSION) touch $@ image: build/.image.done publish-image: image - $(SUDO) docker push quay.io/$(DH_ORG)/kured:$(VERSION) + $(SUDO) docker push docker.io/$(DH_ORG)/kured:$(VERSION) minikube-publish: image - $(SUDO) docker save quay.io/$(DH_ORG)/kured | (eval $$(minikube docker-env) && docker load) + $(SUDO) docker save docker.io/$(DH_ORG)/kured | (eval $$(minikube docker-env) && docker load) diff --git a/README.md b/README.md index 4bade6c..e8f120a 100644 --- a/README.md +++ b/README.md @@ -234,7 +234,7 @@ dep ensure && make ## Frequently Asked/Anticipated Questions -### Why is there no `latest` tag on quay.io? +### Why is there no `latest` tag on Docker Hub? Use of `latest` for production deployments is bad practice - see [here](https://kubernetes.io/docs/concepts/configuration/overview) for diff --git a/kured-ds.yaml b/kured-ds.yaml index 72978dc..da8363b 100644 --- a/kured-ds.yaml +++ b/kured-ds.yaml @@ -29,10 +29,10 @@ spec: restartPolicy: Always containers: - name: kured - image: quay.io/weaveworks/kured # If you find yourself here - # wondering why there is no - # :latest tag on quay.io, see - # the FAQ in the README + image: docker.io/weaveworks/kured # If you find yourself here + # wondering why there is no + # :latest tag on Docker Hub, + # see the FAQ in the README imagePullPolicy: IfNotPresent securityContext: privileged: true # Give permission to nsenter /proc/1/ns/mnt