diff --git a/cmd/kured/main.go b/cmd/kured/main.go index 81ed076..ae94494 100644 --- a/cmd/kured/main.go +++ b/cmd/kured/main.go @@ -151,10 +151,9 @@ func rebootRequired() bool { if sentinelExists() { log.Infof("Reboot required") return true - } else { - log.Infof("Reboot not required") - return false } + log.Infof("Reboot not required") + return false } func rebootBlocked(client *kubernetes.Clientset, nodeID string) bool { @@ -334,7 +333,7 @@ func rebootAsRequired(nodeID string, window *timewindow.TimeWindow, TTL time.Dur source := rand.NewSource(time.Now().UnixNano()) tick := delaytick.New(source, period) - for _ = range tick { + for range tick { if window.Contains(time.Now()) && rebootRequired() && !rebootBlocked(client, nodeID) { node, err := client.CoreV1().Nodes().Get(context.TODO(), nodeID, metav1.GetOptions{}) if err != nil { diff --git a/pkg/alerts/prometheus.go b/pkg/alerts/prometheus.go index 3193294..625a4c0 100644 --- a/pkg/alerts/prometheus.go +++ b/pkg/alerts/prometheus.go @@ -12,7 +12,7 @@ import ( "github.com/prometheus/common/model" ) -// Returns a list of names of active (e.g. pending or firing) alerts, filtered +// PrometheusActiveAlerts returns a list of names of active (e.g. pending or firing) alerts, filtered // by the supplied regexp. func PrometheusActiveAlerts(prometheusURL string, filter *regexp.Regexp) ([]string, error) { client, err := api.NewClient(api.Config{Address: prometheusURL}) @@ -39,7 +39,7 @@ func PrometheusActiveAlerts(prometheusURL string, filter *regexp.Regexp) ([]stri } var activeAlerts []string - for activeAlert, _ := range activeAlertSet { + for activeAlert := range activeAlertSet { activeAlerts = append(activeAlerts, activeAlert) } sort.Sort(sort.StringSlice(activeAlerts))