From 0640683fbb082b399fe0a7c19665d136ef7394e6 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Evrard Date: Mon, 11 Jan 2021 16:06:32 +0100 Subject: [PATCH] Update helm chart README using Make Without this, it's possible that the helm chart documentation contains the `image tag` version which might not be equal to the version in the helm chart, as it's only an example. This is a confusing, so instead we should use make to edit the application version everywhere. This fixes it by updating the Makefile to modify text of the chart's README using a regex looking for something similar to a version; then I used the updated makefile to edit the README, which in turns requires a bump of the version of the chart itself. --- Makefile | 1 + charts/kured/Chart.yaml | 2 +- charts/kured/README.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7395126..466e36d 100644 --- a/Makefile +++ b/Makefile @@ -42,4 +42,5 @@ helm-chart: sed -i "s#repository:.*/kured#repository: $(DH_ORG)/kured#g" charts/kured/values.yaml sed -i "s#tag:.*#tag: $(VERSION)#g" charts/kured/values.yaml sed -i "s#appVersion:.*#appVersion: \"$(VERSION)\"#g" charts/kured/Chart.yaml + sed -i "s#\`[0-9]*\.[0-9]*\.[0-9]*\`#\`$(VERSION)\`#g" charts/kured/README.md echo "Please bump version in charts/kured/Chart.yaml" diff --git a/charts/kured/Chart.yaml b/charts/kured/Chart.yaml index 3a8011d..8475d1d 100644 --- a/charts/kured/Chart.yaml +++ b/charts/kured/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v1 appVersion: "1.6.1" description: A Helm chart for kured name: kured -version: 2.3.0 +version: 2.3.1 home: https://github.com/weaveworks/kured maintainers: - name: ckotzbauer diff --git a/charts/kured/README.md b/charts/kured/README.md index 1896412..e688089 100644 --- a/charts/kured/README.md +++ b/charts/kured/README.md @@ -36,7 +36,7 @@ The following changes have been made compared to the stable chart: | Config | Description | Default | | ------ | ----------- | ------- | | `image.repository` | Image repository | `weaveworks/kured` | -| `image.tag` | Image tag | `1.5.1` | +| `image.tag` | Image tag | `1.6.1` | | `image.pullPolicy` | Image pull policy | `IfNotPresent` | | `image.pullSecrets` | Image pull secrets | `[]` | | `updateStrategy` | Daemonset update strategy | `OnDelete` |