mirror of
https://github.com/kubevela/kubevela.git
synced 2026-03-05 19:22:03 +00:00
fcfb1012d6
* Feat: add if in workflow struct Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Feat: implement the if in workflow Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Feat: support dependency and skip for suspend step Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Fix: fix the rebase from sub steps Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Fix: fix the lint Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Feat: support if in sub steps Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Feat: add tests in application controller Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Fix: fix the lint Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Test: add more tests in discover and custom Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Lint: fix lint Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Tests: add more tests in application controller Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Fix: change failed after retries into reason Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Fix: fix the terminate cli Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * fix lint Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * remove the terminate workflow to pkg and add feature gates Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * resolve comments Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * nit fix Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * make finish condition more clear Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
1571 lines
48 KiB
Go
1571 lines
48 KiB
Go
/*
|
|
Copyright 2021 The KubeVela Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package workflow
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"math"
|
|
"testing"
|
|
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/pkg/errors"
|
|
corev1 "k8s.io/api/core/v1"
|
|
kerrors "k8s.io/apimachinery/pkg/api/errors"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
featuregatetesting "k8s.io/component-base/featuregate/testing"
|
|
"sigs.k8s.io/yaml"
|
|
|
|
"github.com/oam-dev/kubevela/apis/core.oam.dev/common"
|
|
oamcore "github.com/oam-dev/kubevela/apis/core.oam.dev/v1beta1"
|
|
"github.com/oam-dev/kubevela/pkg/cue/model/value"
|
|
"github.com/oam-dev/kubevela/pkg/features"
|
|
monitorContext "github.com/oam-dev/kubevela/pkg/monitor/context"
|
|
wfContext "github.com/oam-dev/kubevela/pkg/workflow/context"
|
|
"github.com/oam-dev/kubevela/pkg/workflow/tasks"
|
|
"github.com/oam-dev/kubevela/pkg/workflow/tasks/custom"
|
|
wfTypes "github.com/oam-dev/kubevela/pkg/workflow/types"
|
|
)
|
|
|
|
var _ = Describe("Test Workflow", func() {
|
|
|
|
BeforeEach(func() {
|
|
cm := &corev1.ConfigMap{}
|
|
revJson, err := yaml.YAMLToJSON([]byte(revYaml))
|
|
Expect(err).ToNot(HaveOccurred())
|
|
err = json.Unmarshal(revJson, cm)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
err = k8sClient.Create(context.Background(), cm)
|
|
if err != nil && !kerrors.IsAlreadyExists(err) {
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
})
|
|
It("Workflow test for failed", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "failed",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateExecuting))
|
|
workflowStatus := app.Status.Workflow
|
|
Expect(workflowStatus.ContextBackend.Name).Should(BeEquivalentTo("workflow-" + app.Name + "-context"))
|
|
workflowStatus.ContextBackend = nil
|
|
cleanStepTimeStamp(workflowStatus)
|
|
Expect(cmp.Diff(*workflowStatus, common.WorkflowStatus{
|
|
AppRevision: workflowStatus.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateExecuting),
|
|
Steps: []common.WorkflowStepStatus{
|
|
{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "failed",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
},
|
|
},
|
|
},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
app, runners = makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
|
|
app.Status.Workflow = workflowStatus
|
|
wf = NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
app.Status.Workflow.Finished = true
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSucceeded))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateSucceeded),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Workflow test failed with sub steps", func() {
|
|
By("Test failed with step group")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "failed",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateExecuting))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateExecuting),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "failed",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
},
|
|
}},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Workflow test skipped with sub steps", func() {
|
|
By("Test skipped with step group")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "failed-after-retries",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "failed",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Terminated: true,
|
|
Message: string(MessageTerminatedFailedAfterRetries),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "failed",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Workflow test if-always with sub steps", func() {
|
|
By("Test if-always with step group")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "failed-after-retries",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
If: "always",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
DependsOn: []string{"s2-sub2"},
|
|
If: "always",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "failed-after-retries",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Terminated: true,
|
|
Message: string(MessageTerminatedFailedAfterRetries),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Workflow test success with sub steps", func() {
|
|
By("Test success with step group")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "success",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSucceeded))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateSucceeded),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
By("Test success with step group and empty subSteps")
|
|
app, runners = makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf = NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx = monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSucceeded))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateSucceeded),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Workflow test for failed after retries with suspend", func() {
|
|
By("Test failed-after-retries in StepByStep mode with suspend")
|
|
defer featuregatetesting.SetFeatureGateDuringTest(&testing.T{}, utilfeature.DefaultFeatureGate, features.EnableSuspendOnFailure, true)()
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSuspended))
|
|
workflowStatus := app.Status.Workflow
|
|
Expect(workflowStatus.ContextBackend.Name).Should(BeEquivalentTo("workflow-" + app.Name + "-context"))
|
|
workflowStatus.ContextBackend = nil
|
|
cleanStepTimeStamp(workflowStatus)
|
|
Expect(cmp.Diff(*workflowStatus, common.WorkflowStatus{
|
|
AppRevision: workflowStatus.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: MessageSuspendFailedAfterRetries,
|
|
Suspend: true,
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
By("Test failed-after-retries in DAG mode with suspend")
|
|
app, runners = makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx = monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf = NewWorkflow(app, k8sClient, common.WorkflowModeDAG, false, nil)
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSuspended))
|
|
workflowStatus = app.Status.Workflow
|
|
Expect(workflowStatus.ContextBackend.Name).Should(BeEquivalentTo("workflow-" + app.Name + "-context"))
|
|
workflowStatus.ContextBackend = nil
|
|
cleanStepTimeStamp(workflowStatus)
|
|
Expect(cmp.Diff(*workflowStatus, common.WorkflowStatus{
|
|
AppRevision: workflowStatus.AppRevision,
|
|
Mode: common.WorkflowModeDAG,
|
|
Message: MessageSuspendFailedAfterRetries,
|
|
Suspend: true,
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Workflow test if always", func() {
|
|
By("Test if always in StepByStep mode")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
If: "always",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s4",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s5",
|
|
If: "always",
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
workflowStatus := app.Status.Workflow
|
|
Expect(workflowStatus.ContextBackend.Name).Should(BeEquivalentTo("workflow-" + app.Name + "-context"))
|
|
workflowStatus.ContextBackend = nil
|
|
cleanStepTimeStamp(workflowStatus)
|
|
Expect(cmp.Diff(*workflowStatus, common.WorkflowStatus{
|
|
AppRevision: workflowStatus.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: MessageTerminatedFailedAfterRetries,
|
|
Suspend: false,
|
|
Terminated: true,
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s4",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s5",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
By("Test if always in DAG mode")
|
|
app, runners = makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
DependsOn: []string{"s2"},
|
|
If: "always",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s4",
|
|
DependsOn: []string{"s3"},
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s5",
|
|
DependsOn: []string{"s3"},
|
|
If: "always",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s6",
|
|
DependsOn: []string{"s1", "s5"},
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx = monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf = NewWorkflow(app, k8sClient, common.WorkflowModeDAG, false, nil)
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
workflowStatus = app.Status.Workflow
|
|
Expect(workflowStatus.ContextBackend.Name).Should(BeEquivalentTo("workflow-" + app.Name + "-context"))
|
|
workflowStatus.ContextBackend = nil
|
|
cleanStepTimeStamp(workflowStatus)
|
|
Expect(cmp.Diff(*workflowStatus, common.WorkflowStatus{
|
|
AppRevision: workflowStatus.AppRevision,
|
|
Mode: common.WorkflowModeDAG,
|
|
Message: MessageTerminatedFailedAfterRetries,
|
|
Terminated: true,
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s4",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s5",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s6",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSkipped,
|
|
Reason: custom.StatusReasonSkip,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Test failed after retries with sub steps", func() {
|
|
By("Test failed-after-retries with step group in StepByStep mode")
|
|
defer featuregatetesting.SetFeatureGateDuringTest(&testing.T{}, utilfeature.DefaultFeatureGate, features.EnableSuspendOnFailure, true)()
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "failed-after-retries",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSuspended))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: MessageSuspendFailedAfterRetries,
|
|
Suspend: true,
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
},
|
|
}},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("Test get backoff time and clean", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "wait-with-set-var",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeDAG, false, nil)
|
|
_, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
_, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
wfCtx, err := wfContext.LoadContext(k8sClient, app.Namespace, app.Name)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
e := &engine{
|
|
status: app.Status.Workflow,
|
|
wfCtx: wfCtx,
|
|
}
|
|
interval := e.getBackoffWaitTime()
|
|
Expect(interval).Should(BeEquivalentTo(minWorkflowBackoffWaitTime))
|
|
|
|
By("Test get backoff time")
|
|
for i := 0; i < 4; i++ {
|
|
_, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
interval := e.getBackoffWaitTime()
|
|
Expect(interval).Should(BeEquivalentTo(minWorkflowBackoffWaitTime))
|
|
}
|
|
|
|
for i := 0; i < 6; i++ {
|
|
_, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
interval := e.getBackoffWaitTime()
|
|
Expect(interval).Should(BeEquivalentTo(int(0.05 * math.Pow(2, float64(i+5)))))
|
|
}
|
|
|
|
_, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
interval = e.getBackoffWaitTime()
|
|
Expect(interval).Should(BeEquivalentTo(MaxWorkflowWaitBackoffTime))
|
|
|
|
By("Test get backoff time after clean")
|
|
wfContext.CleanupMemoryStore(app.Name, app.Namespace)
|
|
_, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
wfCtx, err = wfContext.LoadContext(k8sClient, app.Namespace, app.Name)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
e = &engine{
|
|
status: app.Status.Workflow,
|
|
wfCtx: wfCtx,
|
|
}
|
|
interval = e.getBackoffWaitTime()
|
|
Expect(interval).Should(BeEquivalentTo(minWorkflowBackoffWaitTime))
|
|
})
|
|
|
|
It("test for suspend", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "suspend",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSuspended))
|
|
wfStatus := *app.Status.Workflow
|
|
wfStatus.ContextBackend = nil
|
|
cleanStepTimeStamp(&wfStatus)
|
|
Expect(cmp.Diff(wfStatus, common.WorkflowStatus{
|
|
AppRevision: wfStatus.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Suspend: true,
|
|
Message: string(common.WorkflowStateSuspended),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "suspend",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
// check suspend...
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSuspended))
|
|
|
|
// check resume
|
|
app.Status.Workflow.Suspend = false
|
|
// check app meta changed
|
|
app.Labels = map[string]string{"for-test": "changed"}
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSucceeded))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateSucceeded),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "suspend",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSucceeded))
|
|
})
|
|
|
|
It("test for suspend with sub steps", func() {
|
|
By("Test suspend with step group")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "suspend",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSuspended))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Suspend: true,
|
|
Message: string(common.WorkflowStateSuspended),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "suspend",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("test for terminate", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "terminate",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Terminated: true,
|
|
Message: string(common.WorkflowStateTerminated),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "terminate",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
})
|
|
|
|
It("test for terminate with sub steps", func() {
|
|
|
|
By("Test terminate with step group")
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
SubSteps: []common.WorkflowSubStep{
|
|
{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2-sub2",
|
|
Type: "terminate",
|
|
},
|
|
},
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Terminated: true,
|
|
Message: string(common.WorkflowStateTerminated),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "step-group",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
SubStepsStatus: []common.WorkflowSubStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2-sub2",
|
|
Type: "terminate",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateTerminated))
|
|
})
|
|
|
|
It("test for error", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "error",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateExecuting))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeStep,
|
|
Message: string(common.WorkflowStateExecuting),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("skip workflow", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateFinished))
|
|
})
|
|
|
|
It("test for DAG", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "success",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "pending",
|
|
},
|
|
{
|
|
Name: "s3",
|
|
Type: "success",
|
|
},
|
|
})
|
|
pending = true
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeDAG, false, nil)
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateExecuting))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeDAG,
|
|
Message: string(common.WorkflowStateExecuting),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateExecuting))
|
|
|
|
pending = false
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateSucceeded))
|
|
app.Status.Workflow.ContextBackend = nil
|
|
cleanStepTimeStamp(app.Status.Workflow)
|
|
Expect(cmp.Diff(*app.Status.Workflow, common.WorkflowStatus{
|
|
AppRevision: app.Status.Workflow.AppRevision,
|
|
Mode: common.WorkflowModeDAG,
|
|
Message: string(common.WorkflowStateSucceeded),
|
|
Steps: []common.WorkflowStepStatus{{
|
|
StepStatus: common.StepStatus{
|
|
Name: "s1",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s3",
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}, {
|
|
StepStatus: common.StepStatus{
|
|
Name: "s2",
|
|
Type: "pending",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
},
|
|
}},
|
|
})).Should(BeEquivalentTo(""))
|
|
})
|
|
|
|
It("step commit data without success", func() {
|
|
app, runners := makeTestCase([]oamcore.WorkflowStep{
|
|
{
|
|
Name: "s1",
|
|
Type: "wait-with-set-var",
|
|
},
|
|
{
|
|
Name: "s2",
|
|
Type: "success",
|
|
},
|
|
})
|
|
ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
|
|
wf := NewWorkflow(app, k8sClient, common.WorkflowModeStep, false, nil)
|
|
state, err := wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateInitializing))
|
|
state, err = wf.ExecuteSteps(ctx, revision, runners)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(state).Should(BeEquivalentTo(common.WorkflowStateExecuting))
|
|
Expect(app.Status.Workflow.Steps[0].Phase).Should(BeEquivalentTo(common.WorkflowStepPhaseRunning))
|
|
wfCtx, err := wfContext.LoadContext(k8sClient, app.Namespace, app.Name)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
v, err := wfCtx.GetVar("saved")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
saved, err := v.CueValue().Bool()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(saved).Should(BeEquivalentTo(true))
|
|
})
|
|
})
|
|
|
|
func makeTestCase(steps []oamcore.WorkflowStep) (*oamcore.Application, []wfTypes.TaskRunner) {
|
|
app := &oamcore.Application{
|
|
ObjectMeta: metav1.ObjectMeta{UID: "test-uid"},
|
|
Spec: oamcore.ApplicationSpec{
|
|
Workflow: &oamcore.Workflow{
|
|
Steps: steps,
|
|
},
|
|
},
|
|
Status: common.AppStatus{},
|
|
}
|
|
app.Namespace = "default"
|
|
app.Name = "app"
|
|
runners := []wfTypes.TaskRunner{}
|
|
for _, step := range steps {
|
|
if step.SubSteps != nil {
|
|
subStepRunners := []wfTypes.TaskRunner{}
|
|
for _, subStep := range step.SubSteps {
|
|
subStepRunners = append(subStepRunners, makeRunner(subStep.Name, subStep.Type, subStep.If, subStep.DependsOn, nil))
|
|
}
|
|
runners = append(runners, makeRunner(step.Name, step.Type, step.If, step.DependsOn, subStepRunners))
|
|
} else {
|
|
runners = append(runners, makeRunner(step.Name, step.Type, step.If, step.DependsOn, nil))
|
|
}
|
|
}
|
|
return app, runners
|
|
}
|
|
|
|
var pending bool
|
|
|
|
func makeRunner(name, tpy, ifDecl string, dependsOn []string, subTaskRunners []wfTypes.TaskRunner) wfTypes.TaskRunner {
|
|
var run func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error)
|
|
skip := func(dependsOnPhase common.WorkflowStepPhase, stepStatus map[string]common.StepStatus) (common.StepStatus, bool) {
|
|
status := common.StepStatus{
|
|
Name: name,
|
|
Type: tpy,
|
|
}
|
|
if utilfeature.DefaultMutableFeatureGate.Enabled(features.EnableSuspendOnFailure) {
|
|
return status, false
|
|
}
|
|
skip := custom.SkipTaskRunner(&custom.SkipOptions{
|
|
If: ifDecl,
|
|
DependsOnPhase: dependsOnPhase,
|
|
})
|
|
if skip {
|
|
status.Phase = common.WorkflowStepPhaseSkipped
|
|
status.Reason = custom.StatusReasonSkip
|
|
}
|
|
return status, skip
|
|
}
|
|
switch tpy {
|
|
case "suspend":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "suspend",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
}, &wfTypes.Operation{
|
|
Suspend: true,
|
|
}, nil
|
|
}
|
|
case "terminate":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "terminate",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
}, &wfTypes.Operation{
|
|
Terminated: true,
|
|
}, nil
|
|
}
|
|
case "success":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "success",
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
}, &wfTypes.Operation{}, nil
|
|
}
|
|
case "failed":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "failed",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
}, &wfTypes.Operation{}, nil
|
|
}
|
|
case "failed-after-retries":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "failed-after-retries",
|
|
Phase: common.WorkflowStepPhaseFailed,
|
|
Reason: custom.StatusReasonFailedAfterRetries,
|
|
}, &wfTypes.Operation{
|
|
FailedAfterRetries: true,
|
|
}, nil
|
|
}
|
|
case "error":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "error",
|
|
Phase: common.WorkflowStepPhaseRunning,
|
|
}, &wfTypes.Operation{}, errors.New("error for test")
|
|
}
|
|
case "wait-with-set-var":
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
v, _ := value.NewValue(`saved: true`, nil, "")
|
|
err := ctx.SetVar(v)
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: "wait-with-set-var",
|
|
Phase: common.WorkflowStepPhaseRunning,
|
|
}, &wfTypes.Operation{}, err
|
|
}
|
|
case "step-group":
|
|
group, _ := tasks.StepGroup(oamcore.WorkflowStep{
|
|
Name: name,
|
|
If: ifDecl,
|
|
Type: tpy,
|
|
DependsOn: dependsOn,
|
|
}, &wfTypes.GeneratorOptions{SubTaskRunners: subTaskRunners})
|
|
run = group.Run
|
|
skip = group.Skip
|
|
default:
|
|
run = func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return common.StepStatus{
|
|
Name: name,
|
|
Type: tpy,
|
|
Phase: common.WorkflowStepPhaseSucceeded,
|
|
}, &wfTypes.Operation{}, nil
|
|
}
|
|
|
|
}
|
|
return &testTaskRunner{
|
|
name: name,
|
|
run: run,
|
|
checkPending: func(ctx wfContext.Context, stepStatus map[string]common.StepStatus) bool {
|
|
if tpy != "pending" {
|
|
return false
|
|
}
|
|
if pending == true {
|
|
return true
|
|
}
|
|
return false
|
|
},
|
|
skip: skip,
|
|
}
|
|
}
|
|
|
|
var (
|
|
revYaml = `apiVersion: v1
|
|
data:
|
|
components: '{"server":"{\"Scopes\":null,\"StandardWorkload\":\"{\\\"apiVersion\\\":\\\"v1\\\",\\\"kind\\\":\\\"Pod\\\",\\\"metadata\\\":{\\\"labels\\\":{\\\"app\\\":\\\"nginx\\\"}},\\\"spec\\\":{\\\"containers\\\":[{\\\"env\\\":[{\\\"name\\\":\\\"APP\\\",\\\"value\\\":\\\"nginx\\\"}],\\\"image\\\":\\\"nginx:1.14.2\\\",\\\"imagePullPolicy\\\":\\\"IfNotPresent\\\",\\\"name\\\":\\\"main\\\",\\\"ports\\\":[{\\\"containerPort\\\":8080,\\\"protocol\\\":\\\"TCP\\\"}]}]}}\",\"Traits\":[\"{\\\"apiVersion\\\":\\\"v1\\\",\\\"kind\\\":\\\"Service\\\",\\\"metadata\\\":{\\\"name\\\":\\\"my-service\\\"},\\\"spec\\\":{\\\"ports\\\":[{\\\"port\\\":80,\\\"protocol\\\":\\\"TCP\\\",\\\"targetPort\\\":8080}],\\\"selector\\\":{\\\"app\\\":\\\"nginx\\\"}}}\"]}"}'
|
|
kind: ConfigMap
|
|
metadata:
|
|
name: app-v1
|
|
namespace: default
|
|
`
|
|
revision = &oamcore.ApplicationRevision{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "app-v1",
|
|
},
|
|
}
|
|
)
|
|
|
|
type testTaskRunner struct {
|
|
name string
|
|
run func(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error)
|
|
checkPending func(ctx wfContext.Context, stepStatus map[string]common.StepStatus) bool
|
|
skip func(dependsOnPhase common.WorkflowStepPhase, stepStatus map[string]common.StepStatus) (common.StepStatus, bool)
|
|
}
|
|
|
|
// Name return step name.
|
|
func (tr *testTaskRunner) Name() string {
|
|
return tr.name
|
|
}
|
|
|
|
// Run execute task.
|
|
func (tr *testTaskRunner) Run(ctx wfContext.Context, options *wfTypes.TaskRunOptions) (common.StepStatus, *wfTypes.Operation, error) {
|
|
return tr.run(ctx, options)
|
|
}
|
|
|
|
// Pending check task should be executed or not.
|
|
func (tr *testTaskRunner) Pending(ctx wfContext.Context, stepStatus map[string]common.StepStatus) bool {
|
|
return tr.checkPending(ctx, stepStatus)
|
|
}
|
|
|
|
func (tr *testTaskRunner) Skip(dependsOnPhase common.WorkflowStepPhase, stepStatus map[string]common.StepStatus) (common.StepStatus, bool) {
|
|
return tr.skip(dependsOnPhase, stepStatus)
|
|
}
|
|
|
|
func cleanStepTimeStamp(wfStatus *common.WorkflowStatus) {
|
|
wfStatus.StartTime = metav1.Time{}
|
|
for index, step := range wfStatus.Steps {
|
|
wfStatus.Steps[index].FirstExecuteTime = metav1.Time{}
|
|
wfStatus.Steps[index].LastExecuteTime = metav1.Time{}
|
|
if step.SubStepsStatus != nil {
|
|
for indexSubStep := range step.SubStepsStatus {
|
|
wfStatus.Steps[index].SubStepsStatus[indexSubStep].FirstExecuteTime = metav1.Time{}
|
|
wfStatus.Steps[index].SubStepsStatus[indexSubStep].LastExecuteTime = metav1.Time{}
|
|
}
|
|
}
|
|
}
|
|
}
|