mirror of
https://github.com/kubevela/kubevela.git
synced 2026-08-18 20:17:04 +00:00
8ee9eb2ebd
* Fix: vela status reports Healthy on workflowFailed with empty services
getAppHealth returned true when status.services was empty (vacuous truth),
so failed apps that never produced component status showed Healthy: ✅.
Treat terminal/unhealthy phases, failed workflow steps, and empty services
as unhealthy, with unit tests.
* Style: fix import order in status_health_test.go
* Fix: treat failed workflow substeps as unhealthy in vela status
Address review feedback: scan SubStepsStatus for failed phases so
step-group workflows do not report Healthy when a nested substep failed.
* Fix: satisfy exhaustive linter on ApplicationPhase switch
Add default case so golangci exhaustive does not fail on intentional
partial phase handling in getAppHealth.
---------
(cherry picked from commit ca9152164f)
Signed-off-by: kampitojha <kampitojha@users.noreply.github.com>
Co-authored-by: Kampit Ojha <97059622+kampitojha@users.noreply.github.com>
Co-authored-by: kampitojha <kampitojha@users.noreply.github.com>