mirror of
https://github.com/kubevela/kubevela.git
synced 2026-03-06 03:31:12 +00:00
Some checks failed
CodeQL / Analyze (go) (push) Failing after 1m43s
Definition-Lint / definition-doc (push) Failing after 6m13s
E2E MultiCluster Test / detect-noop (push) Successful in 24s
E2E Test / detect-noop (push) Successful in 17s
Go / detect-noop (push) Successful in 21s
license / Check for unapproved licenses (push) Failing after 2m38s
Registry / publish-core-images (push) Failing after 40s
Unit-Test / detect-noop (push) Successful in 20s
E2E MultiCluster Test / e2e-multi-cluster-tests (v1.29) (push) Failing after 1m55s
E2E Test / e2e-tests (v1.29) (push) Failing after 1m18s
Go / staticcheck (push) Successful in 18m35s
Go / lint (push) Failing after 19m38s
Go / check-diff (push) Failing after 15m7s
Go / check-core-image-build (push) Failing after 3m45s
Go / check-cli-image-build (push) Failing after 2m23s
Unit-Test / unit-tests (push) Failing after 12m43s
Go / check-windows (push) Has been cancelled
Scorecards supply-chain security / Scorecards analysis (push) Failing after 48s
* feature: Add Semantic versioning to KubeVela Definitions Fixes https://github.com/kubevela/kubevela/issues/6435 Fixes https://github.com/kubevela/kubevela/issues/6534 Changes: - Adds an optional "Version" field for all Definition Specs. - Adds the following new validations to Webhooks for Definitions: - Validate the "Version" field follows Semantic versioning. - Dis-allow conflicting versioning fields ( Name annotation, Spec.Version) - Adds the following new validations to Webhooks for Application: - Dis-allow the use of both the "publishVersion" & "autoUpdate" annotations. - Enahnce "multiStageComponentApply" feature to support auto updates. Boy Scout Changes: - Fixes Plugin e2e tests broken by the fix for 6534. - Fixes the dryRun and livediff commands to respect the "-n" namespace flag. - Fixes the Application ValidationWebhook to respect the "-n" namespace flag. Co-authored-by: Rahul Kumar <35751394+bugbounce@users.noreply.github.com> Co-authored-by: Chaitanya Reddy <chaitanyareddy0702@gmail.com> Co-authored-by: Vibhor Chinda <vibhorchinda@gmail.com> Co-authored-by: Shivin Gopalani <gopalanishivin@gmail.com> Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com> * feature: Add KEP to define the proposal Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com> * fix: Rebase and fix merge conflicts Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com> * Fix: Adds unit test cases Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com> --------- Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com> Co-authored-by: bugbounce <35751394+bugbounce@users.noreply.github.com>
114 lines
3.5 KiB
Go
114 lines
3.5 KiB
Go
/*
|
|
Copyright 2021. The KubeVela Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package utils
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"cuelang.org/go/cue/cuecontext"
|
|
cueErrors "cuelang.org/go/cue/errors"
|
|
"github.com/pkg/errors"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/apimachinery/pkg/util/validation"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
"github.com/oam-dev/kubevela/apis/core.oam.dev/v1beta1"
|
|
"github.com/oam-dev/kubevela/pkg/controller/core.oam.dev/v1beta1/core"
|
|
)
|
|
|
|
// ContextRegex to match '**: reference "context" not found'
|
|
var ContextRegex = `^.+:\sreference\s\"context\"\snot\sfound$`
|
|
|
|
// ValidateDefinitionRevision validate whether definition will modify the immutable object definitionRevision
|
|
func ValidateDefinitionRevision(ctx context.Context, cli client.Client, def runtime.Object, defRevNamespacedName types.NamespacedName) error {
|
|
if errs := validation.IsQualifiedName(defRevNamespacedName.Name); len(errs) != 0 {
|
|
return errors.Errorf("invalid definitionRevision name %s:%s", defRevNamespacedName.Name, strings.Join(errs, ","))
|
|
}
|
|
defRev := new(v1beta1.DefinitionRevision)
|
|
if err := cli.Get(ctx, defRevNamespacedName, defRev); err != nil {
|
|
return client.IgnoreNotFound(err)
|
|
}
|
|
|
|
newRev, _, err := core.GatherRevisionInfo(def)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if defRev.Spec.RevisionHash != newRev.Spec.RevisionHash {
|
|
return errors.New("the definition's spec is different with existing definitionRevision's spec")
|
|
}
|
|
if !core.DeepEqualDefRevision(defRev, newRev) {
|
|
return errors.New("the definition's spec is different with existing definitionRevision's spec")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateCueTemplate validate cueTemplate
|
|
func ValidateCueTemplate(cueTemplate string) error {
|
|
|
|
val := cuecontext.New().CompileString(cueTemplate)
|
|
if e := checkError(val.Err()); e != nil {
|
|
return e
|
|
}
|
|
|
|
err := val.Validate()
|
|
return checkError(err)
|
|
}
|
|
|
|
func checkError(err error) error {
|
|
re := regexp.MustCompile(ContextRegex)
|
|
if err != nil {
|
|
// ignore context not found error
|
|
for _, e := range cueErrors.Errors(err) {
|
|
if !re.MatchString(e.Error()) {
|
|
return cueErrors.New(e.Error())
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateSemanticVersion validates if a Definition's version includes all of
|
|
// major,minor & patch version values.
|
|
func ValidateSemanticVersion(version string) error {
|
|
if version != "" {
|
|
versionParts := strings.Split(version, ".")
|
|
if len(versionParts) != 3 {
|
|
return errors.New("Not a valid version")
|
|
}
|
|
|
|
for _, versionPart := range versionParts {
|
|
if _, err := strconv.Atoi(versionPart); err != nil {
|
|
return errors.New("Not a valid version")
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateMultipleDefVersionsNotPresent validates that both Name Annotation Revision and Spec.Version are not present
|
|
func ValidateMultipleDefVersionsNotPresent(version, revisionName, objectType string) error {
|
|
if version != "" && revisionName != "" {
|
|
return fmt.Errorf("%s has both spec.version and revision name annotation. Only one can be present", objectType)
|
|
}
|
|
return nil
|
|
}
|