mirror of
https://github.com/kubevela/kubevela.git
synced 2026-05-20 08:13:23 +00:00
* feat(env): Add comprehensive unit tests for environment management This commit introduces a comprehensive suite of unit tests for the environment management functions in `pkg/utils/env`. Key changes include: - Refactoring the test setup to use `TestMain` for better test environment control. - Adding new test cases for `CreateEnv`, `GetEnvByName`, `ListEnvs`, `SetCurrentEnv`, `SetEnvLabels`, and `DeleteEnv`. These tests improve the overall test coverage and ensure the correctness and reliability of environment-related operations. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * feat(errors): Add unit tests for error handling utilities This commit introduces new unit tests for the error handling utilities located in `pkg/utils/errors/`. Specifically, new test files have been added for: - `crd_test.go`: Tests for CRD-related error checks. - `list_test.go`: Tests for error list aggregation. - `reason_test.go`: Tests for specific error reasons like label conflicts and CUE path not found. - `resourcetracker_test.go`: Tests for resource tracker errors. These additions improve the test coverage and ensure the robustness of KubeVela's error handling mechanisms. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * refactor(schema): Refactor ui_schema_test.go to use testify/assert and add new test cases This commit refactors `pkg/utils/schema/ui_schema_test.go` to improve its readability and maintainability. Key changes include: - Migrating from Ginkgo/Gomega to testify/assert for assertions. - Restructuring `TestGetDefaultUIType` into a table-driven test. - Adding new comprehensive test cases for `Condition_Validate` function. These changes enhance the test suite for UI schema utilities, making it more robust and easier to extend. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * refactor(system): Refactor system_test.go and add comprehensive unit tests This commit refactors `pkg/utils/system/system_test.go` to improve its structure, readability, and test coverage. Key changes include: - Converting existing tests to a table-driven format using `testify/assert`. - Adding new comprehensive test cases for: - `CreateIfNotExist` - `GetVelaHomeDir` - `GetDirectoryFunctions` (e.g., `GetCapCenterDir`, `GetCapabilityDir`) - `InitFunctions` (e.g., `InitCapabilityDir`, `InitCapCenterDir`, `InitDirs`) - `BindEnvironmentVariables` These changes enhance the test suite for system utilities, ensuring their correctness and robustness. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * feat(types): Add unit tests for QL types This commit introduces new unit tests for the types defined in `pkg/utils/types`, specifically focusing on types related to KubeVela Query Language (QL). New test cases cover: - `ServiceEndpoint.String()`: Verifies the string representation of service endpoints, including various protocols, ports, and paths. - `AppliedResource.GroupVersionKind()`: Ensures correct extraction of GroupVersionKind from applied resources. - `ResourceTreeNode.GroupVersionKind()`: Verifies correct extraction of GroupVersionKind from resource tree nodes. These tests improve the coverage and reliability of core data structures used in KubeVela. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * feat(util): Add and refactor unit tests for utility functions This commit introduces new unit tests and refactors existing ones within the `pkg/utils/util` package. Key changes include: - **`pkg/utils/util/cmd_test.go`**: Adds comprehensive tests for `IOStreams` and its print functions, as well as `NewDefaultIOStreams` and `NewTestIOStreams`. - **`pkg/utils/util/factory_test.go`**: Refactors the `GenerateLeaderElectionID` test to a table-driven format and adds new tests for `computeDiscoverCacheDir` and `RestConfigGetter` methods, ensuring the correctness of Kubernetes client configuration and discovery. These additions and refactorings enhance the test coverage and reliability of core utility functions. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * feat(utils): Add and refactor unit tests for json, jwt, parse, and strings utilities This commit introduces new unit tests and refactors existing ones across several utility packages within `pkg/utils/`. Key changes include: - **`pkg/utils/json`**: Adds tests for `StrictUnmarshal` to ensure proper JSON unmarshaling. - **`pkg/utils/jwt`**: Adds tests for JWT token subject extraction and certificate subject retrieval. - **`pkg/utils/parse`**: Expands test coverage for URL parsing functions (`Parse`, `ParseGitlab`). - **`pkg/utils/strings`**: Refactors existing tests to a table-driven format and adds tests for box drawing string generation. These additions and refactorings significantly improve the test coverage and reliability of KubeVela's utility functions. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * fix(tests): Address test and error handling issues This commit addresses several issues identified in unit tests and error handling utilities, improving test reliability and code safety. Key fixes and improvements include: - **`pkg/utils/errors`**: - Added nil check to `IsCuePathNotFound` to prevent panics. - Corrected `fmt.Errorf` usage to `errors.New` in `reason_test.go` (SA1006 fix). - Used `assert.EqualError` for clearer error message comparisons in `resourcetracker_test.go`. - **`pkg/utils/jwt_test.go`**: Marked `generateTestCert` as a test helper using `t.Helper()` for better error reporting. - **`pkg/utils/system_test.go`**: - Removed unused `verifyCleanup` field. - Modified `TestGetVelaHomeDir` to use a temporary home directory, preventing destructive operations on the user's system. - **`pkg/utils/util/cmd_test.go`**: Swapped `assert.Equal` arguments to follow `expected, actual` convention. These changes enhance the robustness and correctness of the test suite and related utility functions. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> * chore(tests): Apply gofmt and import ordering to test files This commit applies standard Go formatting (`gofmt`) and corrects import ordering in several test files. Affected files: - `pkg/utils/schema/ui_schema_test.go`: Added missing newline at EOF. - `pkg/utils/system/system_test.go`: Corrected import ordering. - `pkg/utils/util/factory_test.go`: Corrected import ordering. These changes ensure consistency with project coding standards. Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com> --------- Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com>
280 lines
5.3 KiB
Go
280 lines
5.3 KiB
Go
/*
|
|
Copyright 2022 The KubeVela Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package schema
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGetDefaultUIType(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
apiType string
|
|
haveOptions bool
|
|
subType string
|
|
haveSub bool
|
|
expected string
|
|
}{
|
|
{
|
|
name: "string with options",
|
|
apiType: "string",
|
|
haveOptions: true,
|
|
expected: "Select",
|
|
},
|
|
{
|
|
name: "string without options",
|
|
apiType: "string",
|
|
haveOptions: false,
|
|
expected: "Input",
|
|
},
|
|
{
|
|
name: "number",
|
|
apiType: "number",
|
|
expected: "Number",
|
|
},
|
|
{
|
|
name: "integer",
|
|
apiType: "integer",
|
|
expected: "Number",
|
|
},
|
|
{
|
|
name: "boolean",
|
|
apiType: "boolean",
|
|
expected: "Switch",
|
|
},
|
|
{
|
|
name: "array of strings",
|
|
apiType: "array",
|
|
subType: "string",
|
|
expected: "Strings",
|
|
},
|
|
{
|
|
name: "array of numbers",
|
|
apiType: "array",
|
|
subType: "number",
|
|
expected: "Numbers",
|
|
},
|
|
{
|
|
name: "array of integers",
|
|
apiType: "array",
|
|
subType: "integer",
|
|
expected: "Numbers",
|
|
},
|
|
{
|
|
name: "array of structs",
|
|
apiType: "array",
|
|
subType: "object",
|
|
expected: "Structs",
|
|
},
|
|
{
|
|
name: "object with sub-parameters",
|
|
apiType: "object",
|
|
haveSub: true,
|
|
expected: "Group",
|
|
},
|
|
{
|
|
name: "object without sub-parameters",
|
|
apiType: "object",
|
|
haveSub: false,
|
|
expected: "KV",
|
|
},
|
|
{
|
|
name: "unknown type",
|
|
apiType: "unknown",
|
|
expected: "Input",
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
uiType := GetDefaultUIType(tc.apiType, tc.haveOptions, tc.subType, tc.haveSub)
|
|
assert.Equal(t, tc.expected, uiType)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestUISchema_Validate(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
u UISchema
|
|
wantErr bool
|
|
errContains string
|
|
}{
|
|
{
|
|
name: "valid schema",
|
|
u: UISchema{
|
|
{
|
|
Conditions: []Condition{
|
|
{
|
|
JSONKey: "key",
|
|
Op: "==",
|
|
Action: "enable",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "invalid condition with empty jsonkey",
|
|
u: UISchema{
|
|
{
|
|
Conditions: []Condition{
|
|
{
|
|
JSONKey: "",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
errContains: "the json key of the condition can not be empty",
|
|
},
|
|
{
|
|
name: "invalid condition with bad action",
|
|
u: UISchema{
|
|
{
|
|
Conditions: []Condition{
|
|
{
|
|
JSONKey: "key",
|
|
Action: "badAction",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
errContains: "the action of the condition only supports enable, disable or leave it empty",
|
|
},
|
|
{
|
|
name: "invalid condition with bad op",
|
|
u: UISchema{
|
|
{
|
|
Conditions: []Condition{
|
|
{
|
|
JSONKey: "key",
|
|
Op: "badOp",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
errContains: "the op of the condition must be `==` 、`!=` and `in`",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
err := tt.u.Validate()
|
|
if tt.wantErr {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.errContains)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCondition_Validate(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
c Condition
|
|
wantErr bool
|
|
errContains string
|
|
}{
|
|
{
|
|
name: "valid case with defaults",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Value: "myValue",
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid case with all fields",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Op: "==",
|
|
Value: "myValue",
|
|
Action: "enable",
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid op !=",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Op: "!=",
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid op in",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Op: "in",
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid action disable",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Action: "disable",
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "invalid empty jsonkey",
|
|
c: Condition{
|
|
JSONKey: "",
|
|
},
|
|
wantErr: true,
|
|
errContains: "the json key of the condition can not be empty",
|
|
},
|
|
{
|
|
name: "invalid action",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Action: "invalidAction",
|
|
},
|
|
wantErr: true,
|
|
errContains: "the action of the condition only supports enable, disable or leave it empty",
|
|
},
|
|
{
|
|
name: "invalid op",
|
|
c: Condition{
|
|
JSONKey: "myKey",
|
|
Op: ">",
|
|
},
|
|
wantErr: true,
|
|
errContains: "the op of the condition must be `==` 、`!=` and `in`",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
err := tt.c.Validate()
|
|
if tt.wantErr {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.errContains)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|