mirror of
https://github.com/kubevela/kubevela.git
synced 2026-08-18 20:17:04 +00:00
Anurag PappulaandGitHub
24ae77d39f
* fix(controller): set Ready condition to False on reconcile failure endWithNegativeCondition set only the failing sub-condition (e.g. Parsed=False/ReconcileError) but left the rollup Ready condition unchanged, so a reconcile failure left Ready at True/ReconcileSuccess from the last successful reconcile. Health checkers polling Ready as the application health signal missed the failure. Also set Ready=False/ReconcileError alongside the sub-condition with the same message, so the rollup reflects the failure on every path that ends through endWithNegativeCondition. Fixes #7164 Signed-off-by: Anuragp22 <anuragp2003b@gmail.com> * test(controller): assert Ready condition propagates sub-condition message Address cubic review on #7168: verify the persisted Ready condition's Message field equals the failing sub-condition's Message, so a future refactor that drops the message propagation in endWithNegativeCondition gets caught by the test. Signed-off-by: Anuragp22 <anuragp2003b@gmail.com> --------- Signed-off-by: Anuragp22 <anuragp2003b@gmail.com>