mirror of
https://github.com/kubevela/kubevela.git
synced 2026-08-19 04:26:39 +00:00
66e9107688
K8SVersion, velaCorePodUsage, and velaCLusterGatewayPodUsage in references/cli/top/model/info.go called kubernetes.NewForConfig / metrics.NewForConfig without checking for a nil *rest.Config first. client-go panics with a nil-pointer dereference in that case instead of returning an error, so vela top crashes instead of showing Unknown/N/A for those fields. Confirmed via two independent call paths that both panicked before this fix: InfoBoard.Init (references/cli/top/component) and App.Init (references/cli/top/view). Added regression tests for all three functions with a nil config. Signed-off-by: sakirr05 <sakirahmed75531@gmail.com> Co-authored-by: sakirr05 <sakirahmed75531@gmail.com>
80 lines
2.1 KiB
Go
80 lines
2.1 KiB
Go
/*
|
|
Copyright 2022 The KubeVela Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package model
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
clicommon "github.com/oam-dev/kubevela/references/common"
|
|
)
|
|
|
|
func TestInfo_CurrentContext(t *testing.T) {
|
|
info := NewInfo()
|
|
assert.NotEqual(t, info.CurrentContext(), "UNKNOWN")
|
|
}
|
|
|
|
func TestInfo_ClusterNum(t *testing.T) {
|
|
info := NewInfo()
|
|
assert.NotEmpty(t, info.ClusterNum())
|
|
}
|
|
|
|
func TestInfo_VelaCLIVersion(t *testing.T) {
|
|
assert.NotEmpty(t, VelaCLIVersion())
|
|
}
|
|
|
|
func TestInfo_VelaCoreVersion(t *testing.T) {
|
|
assert.NotEmpty(t, VelaCoreVersion())
|
|
}
|
|
|
|
func TestInfo_GOLangVersion(t *testing.T) {
|
|
assert.Contains(t, GOLangVersion(), "go")
|
|
}
|
|
|
|
func TestInfo_K8SVersion_NilConfig(t *testing.T) {
|
|
assert.Equal(t, Unknown, K8SVersion(nil))
|
|
}
|
|
|
|
func TestInfo_VelaCoreRatio_NilConfig(t *testing.T) {
|
|
cpuL, memL, cpuR, memR := VelaCoreRatio(nil, nil)
|
|
assert.Equal(t, clicommon.MetricsNA, cpuL)
|
|
assert.Equal(t, clicommon.MetricsNA, memL)
|
|
assert.Equal(t, clicommon.MetricsNA, cpuR)
|
|
assert.Equal(t, clicommon.MetricsNA, memR)
|
|
}
|
|
|
|
func TestInfo_CLusterGatewayRatio_NilConfig(t *testing.T) {
|
|
cpuL, memL, cpuR, memR := CLusterGatewayRatio(nil, nil)
|
|
assert.Equal(t, clicommon.MetricsNA, cpuL)
|
|
assert.Equal(t, clicommon.MetricsNA, memL)
|
|
assert.Equal(t, clicommon.MetricsNA, cpuR)
|
|
assert.Equal(t, clicommon.MetricsNA, memR)
|
|
}
|
|
|
|
var _ = Describe("test info", func() {
|
|
It("running app num", func() {
|
|
Expect(ApplicationRunningNum(cfg)).To(Equal("1/1"))
|
|
})
|
|
|
|
It("test kubernetes version", func() {
|
|
Expect(K8SVersion(cfg) != "UNKNOWN").To(BeTrue())
|
|
})
|
|
})
|