mirror of
https://github.com/kubevela/kubevela.git
synced 2026-02-14 18:10:21 +00:00
* Docs(KEP): Go SDK for X-Definition Authoring (defkit) Introduces KEP proposal for defkit, a Go SDK that enables platform engineers to author X-Definitions using native Go code instead of CUE. Key proposed features: - Fluent builder API for Component, Trait, Policy, and WorkflowStep definitions - Transparent Go-to-CUE compilation - IDE support with autocomplete and type checking - Schema-agnostic resource construction - Collection operations (map, filter, dedupe) - Composable health and status expressions - Addon integration with godef/ folder support - Module dependencies for definition sharing via go get Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(KEP): Examples and minor api changes given in the document Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(KEP): align defkit examples - Fix golang version in CI - Fix variable declaration in example for testing - Add Is() comparison method to status check Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Docs(KEP): add security considerations section - Add goal #7 for secure code execution model - Add Security Considerations section covering: - Code execution model (compile-time only, not runtime) - Security benefits over CUE (static analysis, dependency scanning) - Threat model with mitigations Addresses PR feedback about code execution safety. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Docs(KEP): add module versioning and definition placement sections - Add Module Versioning section explaining git-based version derivation - Add Definition Placement section covering: - Motivation for placement constraints in multi-cluster environments - Fluent API for placement (RunOn, NotRunOn, label conditions) - Logical combinators (And, Or, Not) - Module-level placement defaults - Placement evaluation logic - CLI experience for managing cluster labels - Add Module Hooks section for lifecycle callbacks - Minor fixes and clarifications throughout Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Docs(KEP): add module hooks and update addon integration sections - Add Module Hooks section covering: - Use cases (CRD installation, setup scripts, post-install samples) - Hook configuration in module.yaml (pre-apply, post-apply) - Hook types (path for manifests, script for shell scripts) - waitFor field with condition names and CUE expressions - CLI usage (--skip-hooks, --dry-run) - Update Addon Integration section with implementation details: - godef/ folder structure with module.yaml - CLI flags (--godef, --components, --traits, --policies, --workflowsteps) - Conflict detection and --override-definitions flag - Development workflow Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Docs(KEP): address PR review comments and clarify placement labels - Fix misleading "Sandboxed Compilation" claim (cubic-ai feedback) - renamed to "Isolated Compilation" and clarified that security relies on trust model, not technical sandboxing - Fix inconsistent apiVersion in module hooks example (defkit.oam.dev/v1 → core.oam.dev/v1beta1) - Clarify that placement uses vela-cluster-identity ConfigMap directly, not the vela cluster labels command (which is planned for future) - Add --stats flag to apply-module CLI documentation Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Docs(KEP): fix API documentation Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add core fluent API types for Go-based definitions Introduce the defkit package providing a fluent Go API for defining KubeVela X-Definitions (components, traits, policies, workflow steps). Core types added: - types.go: Value, Condition, Param interfaces - base.go: Base definition types and interfaces - param.go: Parameter builders (String, Int, Bool, Array, Map, Struct, Enum) - expr.go: Expression builders for conditions and comparisons - resource.go: Resource operations (Set, SetIf, Spread) - context.go: KubeVela context references (appName, namespace, etc.) - test_context.go: Test utilities for definition validation This enables writing type-safe Go definitions that compile to CUE. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add collection operations and helper builders Add fluent API for array/collection transformations: - CollectionOp with Filter, Map, Pick, Wrap, Dedupe operations - From() and Each() entry points for collection pipelines - FieldRef, FieldEquals, FieldMap for field-level operations - MultiSource for complex multi-array comprehensions - Add helper builders for template variables - Add value transformation utilities Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add CUE code generator Implement CUEGenerator that transforms Go definitions into CUE code Added helper methods and writers for conversion Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add status and health policy builders Add fluent builders for customStatus and healthPolicy CUE generation Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add definition type builders Add fluent builders for all four KubeVela X-Definition types: - ComponentDefinition - TraitDefinition - PolicyDefinition - WorkflowStepDefinition Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(goloader): add Go module loader for definitions - Definition interface and registry for runtime discovery - Discover and parse Go-based definition files - Compile Go definitions to CUE at runtime - Module environment for batch processing - Parallel generation for better performance Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(cli): add vela def commands for Go-based definitions - init-module: scaffold a new Go definition module - apply-module: compile and apply definitions to cluster - list-module: show definitions in a module - validate-module: validate definitions without applying - Also support the cue commands for xdefintions for go code Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add testing utilities and matchers - CUE comparison matchers for Ginkgo/Gomega tests - Test helpers for definition validation Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add patch container helpers for container mod operations Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(cli): update the go module to 1.23.8 for defkit init-module command Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Refactor: Add grouped help output for vela def command Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add definition placement for cluster-aware deployments Enable definitions to specify which clusters they should run on based on cluster identity labels stored in a well-known ConfigMap. Also derives module version from git tags and improves init-module to create directories from --name flag. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add RunOn/NotRunOn fluent API for placement constraints Add placement methods to all definition builders allowing definitions to specify cluster eligibility using the placement package's fluent API. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Docs(defkit): add commented placement example to module.yaml template Show users the placement syntax in generated module.yaml without setting actual values. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add module-level placement support Add placement constraints at the module level in module.yaml that apply to all definitions unless overridden at definition level. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add CLI placement enforcement in apply-module Add placement constraint checking to `vela def apply-module` command. Definitions are skipped if cluster labels don't match module placement. - Add --ignore-placement flag to bypass placement checks - Display placement status during apply with clear skip reasons - Track placement-skipped count in summary output Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(defkit): show all flags in subcommand help output Fix custom help function to properly display flags for def subcommands like init-module and apply-module instead of only showing parent flags. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(defkit): apply name prefix to definitions in apply-module The --prefix flag was not being applied to definition names. The prefix was set in module loader metadata but not used when creating Kubernetes objects from parsed CUE. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Chore(defkit): align module command help with standard vela pattern Remove argument placeholders from command Use field to align with other vela commands (addon, cluster, workflow). Arguments are shown in examples and individual --help output instead of the listing. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(goloader): use json.Unmarshal for go mod download output The downloadGoModule function parses JSON output from 'go mod download -json' but was incorrectly using yaml.Unmarshal with json struct tags. The yaml.v3 library ignores json tags, resulting in empty field values. This would cause remote Go module loading (e.g., github.com/foo/bar@v1.0.0) to fail with "go mod download did not return a directory" because result.Dir would be empty. Fix: Use json.Unmarshal instead since the data is JSON from the Go toolchain. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(goloader): use semver for MinVelaVersion comparison String comparison of version numbers is incorrect for cases like "v1.10.0" > "v1.9.0" which returns false due to lexicographic ordering. Use the Masterminds/semver library (already a dependency) for proper semantic version comparison in ValidateModule(). Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(placement): validate operator in module placement conditions Add validation to catch invalid placement operators at module load time instead of silently failing at runtime evaluation. - Add Operator.IsValid() method to check for valid operators - Add ValidOperators() helper function - Add validatePlacementConditions() in ValidateModule() - Provides clear error message with valid operator list Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(cli): validate conflict strategy in apply-module Invalid --conflict values like "invalid" were silently accepted and would fall through the switch statement, behaving like "overwrite". Add ConflictStrategy.IsValid() method and validation at flag parsing to provide clear error message for invalid values. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(placement): support definition-level placement constraints Previously only module-level placement was enforced. Now individual definitions can specify their own placement constraints that override module defaults. Changes: - Add Placement field to DefinitionInfo and DefinitionPlacement types - Add GetPlacement/HasPlacement to Definition interface - Update registry ToJSON to include placement in output - Update goloader to capture definition placement from registry - Update CLI apply-module to use GetEffectivePlacement() for combining module-level and definition-level placement - Add comprehensive tests for definition placement Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Chore(defkit): remove dead PatchTemplate code PatchTemplate, PatchOp, SetPatchOp, and SetIfPatchOp were defined but never used anywhere in the codebase. The PatchResource type already provides the same functionality and is the one actually being used through Template.Patch(). Removed: - PatchTemplate struct and its methods (ToCue, SetIf, Set) - PatchOp interface - SetPatchOp struct and its ToCue method - SetIfPatchOp struct and its ToCue method - NewPatchTemplate constructor This cleanup reduces maintenance burden without affecting any functionality. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(cli): pass actual VelaVersion to validate-module command The help text for `vela def validate-module` promised to check minVelaVersion requirements but ValidateModule() was called with an empty string, causing the check to be silently skipped. Now passes velaversion.VelaVersion so modules specifying a minimum KubeVela version will be properly validated against the current CLI version. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): implement WithDetails() and FromTyped() APIs WithDetails(): - Adds WithDetails(message, details...) method to StatusBuilder - Allows adding structured key-value details alongside status messages - Uses existing StatusDetail and statusWithDetailsExpr infrastructure - Example: s.WithDetails(s.Format("Ready: %v", ...), s.Detail("endpoint", ...)) FromTyped(): - Converts typed Kubernetes objects (runtime.Object) to Resource - Provides compile-time type safety for building resources - Requires TypeMeta to be set on the object - Includes MustFromTyped() variant that panics on error - Example: defkit.FromTyped(&appsv1.Deployment{...}) Both APIs were documented in the KEP but not implemented. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Style(defkit): apply gofmt formatting Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(defkit): fix remote module download with @latest version When downloading a Go module without an explicit version, always append @latest to ensure go mod download fetches from the remote repository instead of skipping the download. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(defkit): support running def commands from any directory Previously, module commands like `vela def list-module` only worked when run from within the kubevela repository. Now they work from any directory by honoring replace directives in the source module's go.mod. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): generate doc.go files in init-module Create doc.go files with package documentation in each definition directory (components, traits, policies, workflowsteps). This ensures go mod tidy works correctly by making each directory a valid Go package, and provides helpful examples for users creating new definitions. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(defkit): deduplicate definitions from overlapping directory scans The module loader scans both conventional directories (components/, traits/, etc.) and the root directory. Since DiscoverDefinitions uses recursive filepath.Walk, files in subdirectories were found twice. Added file tracking to skip already-processed files. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(defkit): validate placement constraints and fix GOWORK interference Add validation for conflicting placement constraints at registration time. Definitions with logically impossible placement (e.g., same condition in both RunOn and NotRunOn) now fail fast with a clear error message. Also fix placement loading when parent directories contain go.work files by setting GOWORK=off when running the registry generator. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add parameter schema constraints and runtime condition methods Extend the parameter fluent API with comprehensive validation and conditional logic support: - Schema constraints for input validation (Min/Max, Pattern, MinLen/MaxLen, MinItems/MaxItems) - Runtime conditions for template logic (In, Contains, Matches, StartsWith/EndsWith, Len*, IsEmpty/IsNotEmpty, HasKey, IsFalse) Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(defkit): add waitFor support with CUE expressions for module hooks Add the ability to specify custom readiness conditions for module hooks using the new `waitFor` field. This allows users to define precise conditions for when resources should be considered ready. The waitFor field supports two formats: - Simple condition name (e.g., "Ready", "Established") - checks status.conditions for the named condition with status "True" - CUE expression (e.g., "status.replicas == status.readyReplicas") - evaluated against the full resource for flexible readiness checks Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Feat(addon): add godef support for Go-based definitions in addons Add support for a godef/ folder in addons that allows writing definitions in Go instead of CUE. When an addon is enabled, Go definitions are automatically compiled to CUE and deployed alongside traditional CUE definitions. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: lint issues and make reviewable Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: lint and build failure Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: lint and ci errors Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: golangci-lint errors for defkit package - Use standard library errors (errors.Is/As) instead of pkg/errors - Fix ineffassign issues by scoping variables correctly - Add nolint comments for intentional nilerr, makezero patterns - Combine chained appends in addon init.go - Add gosec nolint for CLI file operations and permissions - Increase gocyclo threshold to 35, nolint complex CLI commands Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: kubectl installation with retry and fallback version in github actions Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix(ci): hardcode kubectl version to avoid flaky CDN endpoint Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Chore: improve test coverage for codecov Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Chore: add more tests for codecov and CI to pass Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: ci failure on style Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: OperatorNotEquals to fail closed with empty values Change NotEquals operator to return false when Values slice is empty, matching the fail-closed behavior of Equals operator. This prevents silent widening of placement eligibility when a malformed constraint is created. Following Kubernetes label selector semantics where In/NotIn operators require non-empty values, we apply a fail-closed approach for safety in placement decisions. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: OpenArrayParam field shadowing and remove redundant GetName() Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: path traversal vulnerability in Go definition scaffolding Validate Go definition names before using them in file paths to prevent creation of files outside the addon directory. Unsanitized names could contain path traversal segments (e.g., "../../../etc/passwd") allowing arbitrary file writes. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: unescaped string interpolation in health_expr CUE generation Use %q format verb in formatValue() to properly escape quotes and special characters when generating CUE strings. Update fieldContainsExpr to use formatValue() instead of raw string interpolation. This prevents invalid CUE when substring values contain quotes or backslashes. Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: Guard against typed nil in Gomega matchers to prevent panic Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: Guard against malformed bracket path in parseBracketAccess Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: incomplete AppRevision test to actually verify resolution Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Fix: apply fail-closed behavior to NotIn with empty values Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> * Doc: Added note about RawCUE and some alignment style Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in> --------- Signed-off-by: Anoop Gopalakrishnan <anoop2811@aol.in>
1288 lines
42 KiB
Go
1288 lines
42 KiB
Go
/*
|
|
Copyright 2021 The KubeVela Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cli
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"sort"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/fatih/color"
|
|
"github.com/getkin/kin-openapi/openapi3"
|
|
"github.com/gosuri/uitable"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
"helm.sh/helm/v3/pkg/strvals"
|
|
types2 "k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/client-go/discovery"
|
|
"k8s.io/client-go/rest"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
common2 "github.com/oam-dev/kubevela/apis/core.oam.dev/common"
|
|
"github.com/oam-dev/kubevela/apis/core.oam.dev/v1beta1"
|
|
"github.com/oam-dev/kubevela/apis/types"
|
|
pkgaddon "github.com/oam-dev/kubevela/pkg/addon"
|
|
"github.com/oam-dev/kubevela/pkg/oam"
|
|
addonutil "github.com/oam-dev/kubevela/pkg/utils/addon"
|
|
"github.com/oam-dev/kubevela/pkg/utils/apply"
|
|
"github.com/oam-dev/kubevela/pkg/utils/common"
|
|
cmdutil "github.com/oam-dev/kubevela/pkg/utils/util"
|
|
)
|
|
|
|
const (
|
|
statusEnabled = "enabled"
|
|
statusDisabled = "disabled"
|
|
statusSuspend = "suspend"
|
|
)
|
|
|
|
var enabledAddonColor = color.New(color.Bold, color.FgGreen)
|
|
|
|
var (
|
|
forceDisable bool
|
|
addonRegistry string
|
|
addonVersion string
|
|
addonClusters string
|
|
verboseStatus bool
|
|
skipValidate bool
|
|
overrideDefs bool
|
|
dryRun bool
|
|
yes2all bool
|
|
)
|
|
|
|
// NewAddonCommand create `addon` command
|
|
func NewAddonCommand(c common.Args, order string, ioStreams cmdutil.IOStreams) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "addon",
|
|
Short: "Manage addons for extension.",
|
|
Long: "Manage addons for extension.",
|
|
Annotations: map[string]string{
|
|
types.TagCommandOrder: order,
|
|
types.TagCommandType: types.TypeApp,
|
|
},
|
|
}
|
|
cmd.AddCommand(
|
|
NewAddonListCommand(c),
|
|
NewAddonEnableCommand(c, ioStreams),
|
|
NewAddonDisableCommand(c, ioStreams),
|
|
NewAddonStatusCommand(c, ioStreams),
|
|
NewAddonRegistryCommand(c, ioStreams),
|
|
NewAddonUpgradeCommand(c, ioStreams),
|
|
NewAddonPackageCommand(c),
|
|
NewAddonInitCommand(),
|
|
NewAddonPushCommand(c),
|
|
)
|
|
return cmd
|
|
}
|
|
|
|
// NewAddonListCommand create addon list command
|
|
func NewAddonListCommand(c common.Args) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "list",
|
|
Aliases: []string{"ls"},
|
|
Short: "List addons",
|
|
Long: "List addons in KubeVela",
|
|
Example: ` List addon by:
|
|
vela addon ls
|
|
List addons in a specific registry, useful to reveal addons with duplicated names:
|
|
vela addon ls --registry <registry-name>
|
|
`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
k8sClient, err := c.GetClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
table, err := listAddons(context.Background(), k8sClient, addonRegistry)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fmt.Println(table.String())
|
|
return nil
|
|
},
|
|
}
|
|
cmd.Flags().StringVarP(&addonRegistry, "registry", "r", "", "specify the registry name to list")
|
|
return cmd
|
|
}
|
|
|
|
// NewAddonEnableCommand create addon enable command
|
|
func NewAddonEnableCommand(c common.Args, ioStream cmdutil.IOStreams) *cobra.Command {
|
|
ctx := context.Background()
|
|
cmd := &cobra.Command{
|
|
Use: "enable",
|
|
Aliases: []string{"install"},
|
|
Short: "enable an addon",
|
|
Long: "enable an addon in cluster.",
|
|
Example: ` Enable addon by:
|
|
vela addon enable <addon-name>
|
|
Enable addon with specify version:
|
|
vela addon enable <addon-name> --version <addon-version>
|
|
Enable addon for specific clusters, (local means control plane):
|
|
vela addon enable <addon-name> --clusters={local,cluster1,cluster2}
|
|
Enable addon locally:
|
|
vela addon enable <your-local-addon-path>
|
|
Enable addon with specified args (the args should be defined in addon's parameters):
|
|
vela addon enable <addon-name> <my-parameter-of-addon>=<my-value>
|
|
Enable addon with specified registry:
|
|
vela addon enable <registryName>/<addonName>
|
|
`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
var additionalInfo string
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("must specify addon name")
|
|
}
|
|
addonArgs, err := parseAddonArgsToMap(args[1:])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
clusterArgs := transClusters(addonClusters)
|
|
if len(clusterArgs) != 0 {
|
|
addonArgs[types.ClustersArg] = clusterArgs
|
|
}
|
|
config, err := c.GetConfig()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
k8sClient, err := c.GetClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
dc, err := c.GetDiscoveryClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
addonOrDir := args[0]
|
|
var name = addonOrDir
|
|
// inject runtime info
|
|
addonArgs[pkgaddon.InstallerRuntimeOption] = map[string]interface{}{
|
|
"upgrade": false,
|
|
}
|
|
var addonName string
|
|
if file, err := os.Stat(addonOrDir); err == nil {
|
|
if !file.IsDir() {
|
|
return fmt.Errorf("%s is not addon dir", addonOrDir)
|
|
}
|
|
ioStream.Infof("%s", color.New(color.FgYellow).Sprintf("enabling addon by local dir: %s \n", addonOrDir))
|
|
// args[0] is a local path install with local dir, use base dir name as addonName
|
|
abs, err := filepath.Abs(addonOrDir)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "directory %s is invalid", addonOrDir)
|
|
}
|
|
addonName = filepath.Base(abs)
|
|
if !yes2all {
|
|
if err := checkUninstallFromClusters(ctx, k8sClient, addonName, addonArgs); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
additionalInfo, err = enableAddonByLocal(ctx, addonName, addonOrDir, k8sClient, dc, config, addonArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
if filepath.IsAbs(addonOrDir) || strings.HasPrefix(addonOrDir, ".") || strings.HasSuffix(addonOrDir, "/") {
|
|
return fmt.Errorf("addon directory %s not found in local file system", addonOrDir)
|
|
}
|
|
_, addonName, err = splitSpecifyRegistry(name)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to split addonName and addonRegistry: %w", err)
|
|
}
|
|
if !yes2all {
|
|
if err := checkUninstallFromClusters(ctx, k8sClient, addonName, addonArgs); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
additionalInfo, err = enableAddon(ctx, k8sClient, dc, config, name, addonVersion, addonArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if dryRun {
|
|
return nil
|
|
}
|
|
fmt.Printf("Addon %s enabled successfully.\n", addonName)
|
|
AdditionalEndpointPrinter(ctx, c, k8sClient, addonName, additionalInfo, false)
|
|
return nil
|
|
},
|
|
}
|
|
|
|
cmd.Flags().StringVarP(&addonVersion, "version", "v", "", "specify the addon version to enable")
|
|
cmd.Flags().StringVarP(&addonClusters, types.ClustersArg, "c", "", "specify the runtime-clusters to enable")
|
|
cmd.Flags().BoolVarP(&skipValidate, "skip-version-validating", "s", false, "skip validating system version requirement")
|
|
cmd.Flags().BoolVarP(&overrideDefs, "override-definitions", "", false, "override existing definitions if conflict with those contained in this addon")
|
|
cmd.Flags().BoolVarP(&dryRun, FlagDryRun, "", false, "render all yaml files out without real execute it")
|
|
cmd.Flags().BoolVarP(&yes2all, "yes", "y", false, "all checks will be skipped and the default answer is yes for all validation check.")
|
|
return cmd
|
|
}
|
|
|
|
// AdditionalEndpointPrinter will print endpoints
|
|
func AdditionalEndpointPrinter(ctx context.Context, c common.Args, _ client.Client, name, info string, _ bool) {
|
|
err := printAppEndpoints(ctx, addonutil.Addon2AppName(name), types.DefaultKubeVelaNS, Filter{}, c, true)
|
|
if err != nil {
|
|
fmt.Println("Get application endpoints error:", err)
|
|
return
|
|
}
|
|
if len(info) > 0 {
|
|
fmt.Println(info)
|
|
}
|
|
}
|
|
|
|
// NewAddonUpgradeCommand create addon upgrade command
|
|
func NewAddonUpgradeCommand(c common.Args, ioStream cmdutil.IOStreams) *cobra.Command {
|
|
ctx := context.Background()
|
|
cmd := &cobra.Command{
|
|
Use: "upgrade",
|
|
Short: "upgrade an addon",
|
|
Long: "upgrade an addon in cluster.",
|
|
Example: `
|
|
Upgrade addon by:
|
|
vela addon upgrade <addon-name>
|
|
Upgrade addon with specify version:
|
|
vela addon upgrade <addon-name> --version <addon-version>
|
|
Upgrade addon for specific clusters, (local means control plane):
|
|
vela addon upgrade <addon-name> --clusters={local,cluster1,cluster2}
|
|
Upgrade addon locally:
|
|
vela addon upgrade <your-local-addon-path>
|
|
Upgrade addon with specified args (the args should be defined in addon's parameters):
|
|
vela addon upgrade <addon-name> <my-parameter-of-addon>=<my-value>
|
|
The specified args will be merged with legacy args, what user specified in 'vela addon enable', and non-empty legacy arg will be overridden by
|
|
non-empty new arg
|
|
`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("must specify addon name")
|
|
}
|
|
config, err := c.GetConfig()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
k8sClient, err := c.GetClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
dc, err := c.GetDiscoveryClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
addonInputArgs, err := parseAddonArgsToMap(args[1:])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
clusterArgs := transClusters(addonClusters)
|
|
if len(clusterArgs) != 0 {
|
|
addonInputArgs[types.ClustersArg] = clusterArgs
|
|
}
|
|
addonOrDir := args[0]
|
|
|
|
// inject runtime info
|
|
addonInputArgs[pkgaddon.InstallerRuntimeOption] = map[string]interface{}{
|
|
"upgrade": true,
|
|
}
|
|
|
|
var name, additionalInfo string
|
|
if file, err := os.Stat(addonOrDir); err == nil {
|
|
if !file.IsDir() {
|
|
return fmt.Errorf("%s is not addon dir", addonOrDir)
|
|
}
|
|
ioStream.Infof("%s", color.New(color.FgYellow).Sprintf("enabling addon by local dir: %s \n", addonOrDir))
|
|
// args[0] is a local path install with local dir
|
|
abs, err := filepath.Abs(addonOrDir)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "cannot open directory %s", addonOrDir)
|
|
}
|
|
name = filepath.Base(abs)
|
|
_, err = pkgaddon.FetchAddonRelatedApp(context.Background(), k8sClient, name)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "cannot fetch addon related addon %s", name)
|
|
}
|
|
addonArgs, err := pkgaddon.MergeAddonInstallArgs(ctx, k8sClient, name, addonInputArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
additionalInfo, err = enableAddonByLocal(ctx, name, addonOrDir, k8sClient, dc, config, addonArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
if filepath.IsAbs(addonOrDir) || strings.HasPrefix(addonOrDir, ".") || strings.HasSuffix(addonOrDir, "/") {
|
|
return fmt.Errorf("addon directory %s not found in local", addonOrDir)
|
|
}
|
|
name = addonOrDir
|
|
_, err = pkgaddon.FetchAddonRelatedApp(context.Background(), k8sClient, addonOrDir)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "cannot fetch addon related addon %s", addonOrDir)
|
|
}
|
|
addonArgs, err := pkgaddon.MergeAddonInstallArgs(ctx, k8sClient, name, addonInputArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
additionalInfo, err = enableAddon(ctx, k8sClient, dc, config, addonOrDir, addonVersion, addonArgs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
fmt.Printf("Addon %s enabled successfully.\n", name)
|
|
AdditionalEndpointPrinter(ctx, c, k8sClient, name, additionalInfo, true)
|
|
return nil
|
|
},
|
|
}
|
|
cmd.Flags().StringVarP(&addonVersion, "version", "v", "", "specify the addon version to upgrade")
|
|
cmd.Flags().StringVarP(&addonClusters, types.ClustersArg, "c", "", "specify the runtime-clusters to upgrade")
|
|
cmd.Flags().BoolVarP(&skipValidate, "skip-version-validating", "s", false, "skip validating system version requirement")
|
|
cmd.Flags().BoolVarP(&overrideDefs, "override-definitions", "", false, "override existing definitions if conflict with those contained in this addon")
|
|
return cmd
|
|
}
|
|
|
|
func parseAddonArgsToMap(args []string) (map[string]interface{}, error) {
|
|
res := map[string]interface{}{}
|
|
for _, arg := range args {
|
|
if err := strvals.ParseInto(arg, res); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
return res, nil
|
|
}
|
|
|
|
// NewAddonDisableCommand create addon disable command
|
|
func NewAddonDisableCommand(c common.Args, _ cmdutil.IOStreams) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "disable",
|
|
Aliases: []string{"uninstall"},
|
|
Short: "disable an addon",
|
|
Long: "disable an addon in cluster.",
|
|
Example: "vela addon disable <addon-name>",
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("must specify addon name")
|
|
}
|
|
name := args[0]
|
|
k8sClient, err := c.GetClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
config, err := c.GetConfig()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = disableAddon(k8sClient, name, config, forceDisable)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fmt.Printf("Successfully disable addon:%s\n", name)
|
|
return nil
|
|
},
|
|
}
|
|
cmd.Flags().BoolVarP(&forceDisable, "force", "f", false, "skip checking if applications are still using this addon")
|
|
return cmd
|
|
}
|
|
|
|
// NewAddonStatusCommand create addon status command
|
|
func NewAddonStatusCommand(c common.Args, ioStream cmdutil.IOStreams) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "status",
|
|
Short: "get an addon's status.",
|
|
Long: "get an addon's status from cluster.",
|
|
Example: "vela addon status <addon-name>",
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("must specify addon name")
|
|
}
|
|
name := args[0]
|
|
err := statusAddon(name, ioStream, cmd, c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
},
|
|
}
|
|
cmd.Flags().BoolVarP(&verboseStatus, "verbose", "v", false, "show addon descriptions and parameters in addition to status")
|
|
return cmd
|
|
}
|
|
|
|
// NewAddonInitCommand creates an addon scaffold
|
|
func NewAddonInitCommand() *cobra.Command {
|
|
var path string
|
|
initCmd := pkgaddon.InitCmd{}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "init",
|
|
Short: "create an addon scaffold",
|
|
Long: "Create an addon scaffold for quick starting.",
|
|
Example: ` Store the scaffold in a different directory:
|
|
vela addon init mongodb -p path/to/addon
|
|
|
|
Add a Helm component:
|
|
vela addon init mongodb --helm-repo https://marketplace.azurecr.io/helm/v1/repo --chart mongodb --chart-version 12.1.16
|
|
|
|
Add resources from URL using ref-objects component
|
|
vela addon init my-addon --url https://domain.com/resource.yaml
|
|
|
|
Use --no-samples options to skip creating sample files
|
|
vela addon init my-addon --no-sample
|
|
|
|
Create addon with Go-based definition scaffolding (defkit)
|
|
vela addon init my-addon --godef
|
|
|
|
Create addon with specific Go-based definitions
|
|
vela addon init my-addon --godef --components webservice,worker --traits scaler
|
|
|
|
You can combine all the options together.`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("an addon name is required")
|
|
}
|
|
|
|
addonName := args[0]
|
|
|
|
// Scaffold will be created in ./addonName, unless the user specifies a path
|
|
// validity of addon names will be checked later
|
|
addonPath := addonName
|
|
if len(path) > 0 {
|
|
addonPath = path
|
|
}
|
|
|
|
if addonName == "" || addonPath == "" {
|
|
return fmt.Errorf("addon name or path should not be empty")
|
|
}
|
|
|
|
initCmd.AddonName = addonName
|
|
initCmd.Path = addonPath
|
|
|
|
// Validate that godef-specific flags require --godef
|
|
hasGoDefFlags := initCmd.GoDefComponents != "" || initCmd.GoDefTraits != "" ||
|
|
initCmd.GoDefPolicies != "" || initCmd.GoDefWorkflowSteps != ""
|
|
if hasGoDefFlags && !initCmd.EnableGoDef {
|
|
return fmt.Errorf("--components, --traits, --policies, and --workflowsteps flags require --godef to be set")
|
|
}
|
|
|
|
return initCmd.CreateScaffold()
|
|
},
|
|
}
|
|
|
|
f := cmd.Flags()
|
|
f.StringVar(&initCmd.HelmRepoURL, "helm-repo", "", "URL that points to a Helm repo")
|
|
f.StringVar(&initCmd.HelmChartName, "chart", "", "Helm Chart name")
|
|
f.StringVar(&initCmd.HelmChartVersion, "chart-version", "", "version of the Chart")
|
|
f.StringVarP(&path, "path", "p", "", "path to the addon directory (default is ./<addon-name>)")
|
|
f.StringArrayVarP(&initCmd.RefObjURLs, "url", "u", []string{}, "add URL resources using ref-object component")
|
|
f.BoolVarP(&initCmd.NoSamples, "no-samples", "", false, "do not generate sample files")
|
|
f.BoolVarP(&initCmd.Overwrite, "force", "f", false, "overwrite existing addon files")
|
|
f.BoolVar(&initCmd.EnableGoDef, "godef", false, "generate Go-based definition scaffolding in godef/ folder")
|
|
f.StringVar(&initCmd.GoDefComponents, "components", "", "comma-separated list of component names to scaffold (requires --godef)")
|
|
f.StringVar(&initCmd.GoDefTraits, "traits", "", "comma-separated list of trait names to scaffold (requires --godef)")
|
|
f.StringVar(&initCmd.GoDefPolicies, "policies", "", "comma-separated list of policy names to scaffold (requires --godef)")
|
|
f.StringVar(&initCmd.GoDefWorkflowSteps, "workflowsteps", "", "comma-separated list of workflow step names to scaffold (requires --godef)")
|
|
|
|
return cmd
|
|
}
|
|
|
|
// NewAddonPushCommand pushes an addon dir/package to a ChartMuseum
|
|
func NewAddonPushCommand(c common.Args) *cobra.Command {
|
|
p := &pkgaddon.PushCmd{}
|
|
cmd := &cobra.Command{
|
|
Use: "push",
|
|
Short: "uploads an addon package to ChartMuseum",
|
|
Long: `Uploads an addon package to ChartMuseum.
|
|
|
|
Two arguments are needed <addon directory/package> and <name/URL of ChartMuseum>.
|
|
|
|
The first argument <addon directory/package> can be:
|
|
- your conventional addon directory (containing metadata.yaml). We will package it for you.
|
|
- packaged addon (.tgz) generated by 'vela addon package' command
|
|
|
|
The second argument <name/URL of ChartMuseum> can be:
|
|
- registry name (helm type). You can add your ChartMuseum registry using 'vela addon registry add'.
|
|
- ChartMuseum URL, e.g. http://localhost:8080`,
|
|
Example: `# Push the addon in directory <your-addon> to a ChartMuseum registry named <localcm>
|
|
$ vela addon push your-addon localcm
|
|
|
|
# Push packaged addon mongo-1.0.0.tgz to a ChartMuseum registry at http://localhost:8080
|
|
$ vela addon push mongo-1.0.0.tgz http://localhost:8080
|
|
|
|
# Force push, overwriting existing ones
|
|
$ vela addon push your-addon localcm -f
|
|
|
|
# If you already written your own Chart.yaml and don't want us to generate it for you:
|
|
$ vela addon push your-addon localcm --keep-chartmeta
|
|
# Note: when using .tgz packages, we will always keep the original Chart.yaml
|
|
|
|
# In addition to cli flags, you can also use environment variables
|
|
$ HELM_REPO_USERNAME=name HELM_REPO_PASSWORD=pswd vela addon push mongo-1.0.0.tgz http://localhost:8080`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if len(args) != 2 {
|
|
return fmt.Errorf("two arguments are needed: addon directory/package, name/URL of Chart repository")
|
|
}
|
|
|
|
c, err := c.GetClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
p.Client = c
|
|
p.Out = cmd.OutOrStdout()
|
|
p.ChartName = args[0]
|
|
p.RepoName = args[1]
|
|
p.SetFieldsFromEnv()
|
|
|
|
return p.Push(context.Background())
|
|
},
|
|
}
|
|
|
|
f := cmd.Flags()
|
|
f.StringVarP(&p.ChartVersion, "version", "v", "", "override chart version pre-push")
|
|
f.StringVarP(&p.AppVersion, "app-version", "a", "", "override app version pre-push")
|
|
f.StringVarP(&p.Username, "username", "u", "", "override HTTP basic auth username [$HELM_REPO_USERNAME]")
|
|
f.StringVarP(&p.Password, "password", "p", "", "override HTTP basic auth password [$HELM_REPO_PASSWORD]")
|
|
f.StringVarP(&p.AccessToken, "access-token", "", "", "send token in Authorization header [$HELM_REPO_ACCESS_TOKEN]")
|
|
f.StringVarP(&p.AuthHeader, "auth-header", "", "", "alternative header to use for token auth [$HELM_REPO_AUTH_HEADER]")
|
|
f.StringVarP(&p.ContextPath, "context-path", "", "", "ChartMuseum context path [$HELM_REPO_CONTEXT_PATH]")
|
|
f.StringVarP(&p.CaFile, "ca-file", "", "", "verify certificates of HTTPS-enabled servers using this CA bundle [$HELM_REPO_CA_FILE]")
|
|
f.StringVarP(&p.CertFile, "cert-file", "", "", "identify HTTPS client using this SSL certificate file [$HELM_REPO_CERT_FILE]")
|
|
f.StringVarP(&p.KeyFile, "key-file", "", "", "identify HTTPS client using this SSL key file [$HELM_REPO_KEY_FILE]")
|
|
f.BoolVarP(&p.InsecureSkipVerify, "insecure", "", false, "connect to server with an insecure way by skipping certificate verification [$HELM_REPO_INSECURE]")
|
|
f.BoolVarP(&p.ForceUpload, "force", "f", false, "force upload even if chart version exists")
|
|
f.BoolVarP(&p.UseHTTP, "use-http", "", false, "use HTTP")
|
|
f.BoolVarP(&p.KeepChartMetadata, "keep-chartmeta", "", false, "do not update Chart.yaml automatically according to addon metadata (only when addon dir provided)")
|
|
f.Int64VarP(&p.Timeout, "timeout", "t", 30, "The duration (in seconds) vela cli will wait to get response from ChartMuseum")
|
|
|
|
return cmd
|
|
}
|
|
|
|
func enableAddon(ctx context.Context, k8sClient client.Client, dc *discovery.DiscoveryClient, config *rest.Config, name string, version string, args map[string]interface{}) (string, error) {
|
|
var err error
|
|
var additionalInfo string
|
|
registryDS := pkgaddon.NewRegistryDataStore(k8sClient)
|
|
registries, err := registryDS.ListRegistries(ctx)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
registryName, addonName, err := splitSpecifyRegistry(name)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if len(registryName) != 0 {
|
|
foundRegistry := false
|
|
for _, registry := range registries {
|
|
if registry.Name == registryName {
|
|
foundRegistry = true
|
|
}
|
|
}
|
|
if !foundRegistry {
|
|
return "", fmt.Errorf("specified registry %s not exist", registryName)
|
|
}
|
|
}
|
|
for i, registry := range registries {
|
|
opts := addonOptions()
|
|
if len(registryName) != 0 && registryName != registry.Name {
|
|
continue
|
|
}
|
|
additionalInfo, err = pkgaddon.EnableAddon(ctx, addonName, version, k8sClient, dc, apply.NewAPIApplicator(k8sClient), config, registry, args, nil, pkgaddon.FilterDependencyRegistries(i, registries), opts...)
|
|
if errors.Is(err, pkgaddon.ErrNotExist) || errors.Is(err, pkgaddon.ErrFetch) {
|
|
continue
|
|
}
|
|
if unMatchErr := new(pkgaddon.VersionUnMatchError); errors.As(err, unMatchErr) {
|
|
// Get available version of the addon
|
|
availableVersion, err := unMatchErr.GetAvailableVersion()
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
input := NewUserInput()
|
|
if input.AskBool(unMatchErr.Error(), &UserInputOptions{AssumeYes: false}) {
|
|
return pkgaddon.EnableAddon(ctx, addonName, availableVersion, k8sClient, dc, apply.NewAPIApplicator(k8sClient), config, registry, args, nil, pkgaddon.FilterDependencyRegistries(i, registries))
|
|
}
|
|
// The user does not agree to use the version provided by us
|
|
return "", fmt.Errorf("you can try another version by command: \"vela addon enable %s --version <version> \" ", addonName)
|
|
}
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if err = waitApplicationRunning(k8sClient, addonName); err != nil {
|
|
return "", err
|
|
}
|
|
return additionalInfo, nil
|
|
}
|
|
if len(registryName) != 0 {
|
|
return "", fmt.Errorf("addon: %s not found in registry %s", addonName, registryName)
|
|
}
|
|
return "", fmt.Errorf("addon: %s not found in all candidate registries", addonName)
|
|
}
|
|
|
|
func addonOptions() []pkgaddon.InstallOption {
|
|
var opts []pkgaddon.InstallOption
|
|
if skipValidate || yes2all {
|
|
opts = append(opts, pkgaddon.SkipValidateVersion)
|
|
}
|
|
if overrideDefs || yes2all {
|
|
opts = append(opts, pkgaddon.OverrideDefinitions)
|
|
}
|
|
if dryRun {
|
|
opts = append(opts, pkgaddon.DryRunAddon)
|
|
}
|
|
return opts
|
|
}
|
|
|
|
// enableAddonByLocal enable addon in local dir and return the addon name
|
|
func enableAddonByLocal(ctx context.Context, name string, dir string, k8sClient client.Client, dc *discovery.DiscoveryClient, config *rest.Config, args map[string]interface{}) (string, error) {
|
|
opts := addonOptions()
|
|
// overrideDefs flag also allows Go definitions to override CUE definitions within the same addon
|
|
info, err := pkgaddon.EnableAddonByLocalDir(ctx, name, dir, k8sClient, dc, apply.NewAPIApplicator(k8sClient), config, args, overrideDefs, opts...)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if err = waitApplicationRunning(k8sClient, name); err != nil {
|
|
return "", err
|
|
}
|
|
return info, nil
|
|
}
|
|
|
|
func disableAddon(client client.Client, name string, config *rest.Config, force bool) error {
|
|
return pkgaddon.DisableAddon(context.Background(), client, name, config, force)
|
|
}
|
|
|
|
func statusAddon(name string, ioStreams cmdutil.IOStreams, cmd *cobra.Command, c common.Args) error {
|
|
k8sClient, err := c.GetClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
statusString, status, err := generateAddonInfo(k8sClient, name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
fmt.Print(statusString)
|
|
|
|
if status.AddonPhase != statusEnabled && status.AddonPhase != statusDisabled {
|
|
fmt.Printf("diagnose addon info from application %s", addonutil.Addon2AppName(name))
|
|
err := printAppStatus(context.Background(), k8sClient, ioStreams, addonutil.Addon2AppName(name), types.DefaultKubeVelaNS, cmd, c, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func addonNotExist(err error) bool {
|
|
if errors.Is(err, pkgaddon.ErrNotExist) || errors.Is(err, pkgaddon.ErrRegistryNotExist) {
|
|
return true
|
|
}
|
|
if strings.Contains(err.Error(), "not found") {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
// generateAddonInfo will get addon status, description, version, dependencies (and whether they are installed),
|
|
// and parameters (and their current values).
|
|
// The first return value is the formatted string for printing.
|
|
// The second return value is just for diagnostic purposes, as it is needed in statusAddon to print diagnostic info.
|
|
func generateAddonInfo(c client.Client, name string) (string, pkgaddon.Status, error) {
|
|
var res string
|
|
var phase string
|
|
var installed bool
|
|
var addonPackage *pkgaddon.WholeAddonPackage
|
|
|
|
// Check current addon status
|
|
status, err := pkgaddon.GetAddonStatus(context.Background(), c, name)
|
|
if err != nil {
|
|
return res, status, err
|
|
}
|
|
|
|
// Get addon install package
|
|
if verboseStatus || status.AddonPhase == statusDisabled {
|
|
// We need the metadata to get descriptions about parameters
|
|
addonPackages, err := pkgaddon.FindAddonPackagesDetailFromRegistry(context.Background(), c, []string{name}, nil)
|
|
// If the state of addon is not disabled, we don't check the error, because it could be installed from local.
|
|
if status.AddonPhase == statusDisabled && err != nil {
|
|
if addonNotExist(err) {
|
|
return "", pkgaddon.Status{}, fmt.Errorf("addon '%s' not found in cluster or any registry", name)
|
|
}
|
|
return "", pkgaddon.Status{}, err
|
|
}
|
|
if len(addonPackages) != 0 {
|
|
addonPackage = addonPackages[0]
|
|
if status.InstalledRegistry != "" {
|
|
for _, ap := range addonPackages {
|
|
if ap.RegistryName == status.InstalledRegistry {
|
|
addonPackage = ap
|
|
break
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
switch status.AddonPhase {
|
|
case statusEnabled:
|
|
installed = true
|
|
c := color.New(color.FgGreen)
|
|
phase = c.Sprintf("%s", status.AddonPhase)
|
|
case statusSuspend:
|
|
installed = true
|
|
c := color.New(color.FgRed)
|
|
phase = c.Sprintf("%s", status.AddonPhase)
|
|
case statusDisabled:
|
|
c := color.New(color.Faint)
|
|
phase = c.Sprintf("%s", status.AddonPhase)
|
|
// If the addon is
|
|
// 1. disabled,
|
|
// 2. does not exist in the registry,
|
|
// 3. verbose is on (when off, it is not possible to know whether the addon is in registry or not),
|
|
// means the addon does not exist at all.
|
|
// So, no need to go further, we return error message saying that we can't find it.
|
|
if addonPackage == nil && verboseStatus {
|
|
return res, pkgaddon.Status{}, fmt.Errorf("addon %s is not found in registries nor locally installed", name)
|
|
}
|
|
default:
|
|
c := color.New(color.Faint)
|
|
phase = c.Sprintf("%s", status.AddonPhase)
|
|
}
|
|
|
|
// Addon name
|
|
res += color.New(color.Bold).Sprintf("%s", name)
|
|
res += fmt.Sprintf(": %s ", phase)
|
|
if installed {
|
|
res += fmt.Sprintf("(%s)", status.InstalledVersion)
|
|
}
|
|
res += "\n"
|
|
|
|
// Description
|
|
// Skip this if addon is installed from local sources.
|
|
// Description is fetched from the Internet, which is not useful for local sources.
|
|
if status.InstalledRegistry != pkgaddon.LocalAddonRegistryName && addonPackage != nil {
|
|
res += fmt.Sprintln(addonPackage.Description)
|
|
}
|
|
|
|
// Installed Clusters
|
|
if len(status.Clusters) != 0 {
|
|
res += color.New(color.FgHiBlue).Sprint("==> ") + color.New(color.Bold).Sprintln("Installed Clusters")
|
|
var ic []string
|
|
for c := range status.Clusters {
|
|
ic = append(ic, c)
|
|
}
|
|
sort.Strings(ic)
|
|
res += fmt.Sprintln(ic)
|
|
}
|
|
|
|
// Registry name
|
|
registryName := status.InstalledRegistry
|
|
// Disabled addons will have empty InstalledRegistry, so if the addon exists in the registry, we use the registry name.
|
|
if registryName == "" && addonPackage != nil {
|
|
registryName = addonPackage.RegistryName
|
|
}
|
|
if registryName != "" {
|
|
res += color.New(color.FgHiBlue).Sprint("==> ") + color.New(color.Bold).Sprintln("Registry Name")
|
|
res += fmt.Sprintln(registryName)
|
|
}
|
|
|
|
// If the addon is installed from local sources, or does not exist at all, stop here!
|
|
// The following information is fetched from the Internet, which is not useful for local sources.
|
|
if registryName == pkgaddon.LocalAddonRegistryName || registryName == "" || addonPackage == nil {
|
|
return res, status, nil
|
|
}
|
|
|
|
// Available Versions
|
|
res += color.New(color.FgHiBlue).Sprint("==> ") + color.New(color.Bold).Sprintln("Available Versions")
|
|
res += genAvailableVersionInfo(addonPackage.AvailableVersions, status.InstalledVersion, 8)
|
|
res += "\n"
|
|
|
|
// Dependencies
|
|
dependenciesString, allInstalled := generateDependencyString(c, addonPackage.Dependencies)
|
|
res += color.New(color.FgHiBlue).Sprint("==> ") + color.New(color.Bold).Sprint("Dependencies ")
|
|
if allInstalled {
|
|
res += color.GreenString("✔")
|
|
} else {
|
|
res += color.RedString("✘")
|
|
}
|
|
res += "\n"
|
|
res += dependenciesString
|
|
res += "\n"
|
|
|
|
// Parameters
|
|
parameterString := generateParameterString(status, addonPackage)
|
|
if len(parameterString) != 0 {
|
|
res += color.New(color.FgHiBlue).Sprint("==> ") + color.New(color.Bold).Sprintln("Parameters")
|
|
res += parameterString
|
|
}
|
|
|
|
return res, status, nil
|
|
}
|
|
|
|
func generateParameterString(status pkgaddon.Status, addonPackage *pkgaddon.WholeAddonPackage) string {
|
|
ret := ""
|
|
|
|
if addonPackage.APISchema == nil {
|
|
return ret
|
|
}
|
|
ret = printSchema(addonPackage.APISchema, status.Parameters, 0)
|
|
|
|
return ret
|
|
}
|
|
|
|
func convertInterface2StringList(l []interface{}) []string {
|
|
var strl []string
|
|
for _, s := range l {
|
|
str, ok := s.(string)
|
|
if !ok {
|
|
continue
|
|
}
|
|
strl = append(strl, str)
|
|
}
|
|
return strl
|
|
}
|
|
|
|
// printSchema prints the parameters in an addon recursively to a string
|
|
// Deeper the parameter is nested, more the indentations.
|
|
func printSchema(ref *openapi3.Schema, currentParams map[string]interface{}, indent int) string {
|
|
ret := ""
|
|
|
|
if ref == nil {
|
|
return ret
|
|
}
|
|
|
|
addIndent := func(n int) string {
|
|
r := ""
|
|
for i := 0; i < n; i++ {
|
|
r += "\t"
|
|
}
|
|
return r
|
|
}
|
|
|
|
// Required parameters
|
|
required := make(map[string]bool)
|
|
for _, k := range ref.Required {
|
|
required[k] = true
|
|
}
|
|
|
|
for propKey, propValue := range ref.Properties {
|
|
desc := propValue.Value.Description
|
|
defaultValue := propValue.Value.Default
|
|
if defaultValue == nil {
|
|
defaultValue = ""
|
|
}
|
|
required := required[propKey]
|
|
|
|
// Extra indentation on nested objects
|
|
addedIndent := addIndent(indent)
|
|
|
|
var currentValue string
|
|
thisParam, hasParam := currentParams[propKey]
|
|
if hasParam {
|
|
currentValue = fmt.Sprintf("%#v", thisParam)
|
|
switch thisParam.(type) {
|
|
case int:
|
|
case int64:
|
|
case int32:
|
|
case float32:
|
|
case float64:
|
|
case string:
|
|
case bool:
|
|
default:
|
|
if js, err := json.MarshalIndent(thisParam, "", " "); err == nil {
|
|
currentValue = strings.ReplaceAll(string(js), "\n", "\n\t "+addedIndent)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Header: addon: description
|
|
ret += addedIndent
|
|
ret += color.New(color.FgCyan).Sprintf("-> ")
|
|
ret += color.New(color.Bold).Sprint(propKey) + ": "
|
|
ret += fmt.Sprintf("%s\n", desc)
|
|
|
|
// Show current value
|
|
if currentValue != "" {
|
|
ret += addedIndent
|
|
ret += "\tcurrent value: " + color.New(color.FgGreen).Sprintf("%s\n", currentValue)
|
|
}
|
|
|
|
// Show required or not
|
|
if required {
|
|
ret += addedIndent
|
|
ret += "\trequired: "
|
|
ret += color.GreenString("✔\n")
|
|
}
|
|
// Show Enum options
|
|
if len(propValue.Value.Enum) > 0 {
|
|
ret += addedIndent
|
|
ret += "\toptions: \"" + strings.Join(convertInterface2StringList(propValue.Value.Enum), "\", \"") + "\"\n"
|
|
}
|
|
// Show default value
|
|
if defaultValue != "" && currentValue == "" {
|
|
ret += addedIndent
|
|
ret += "\tdefault: " + fmt.Sprintf("%#v\n", defaultValue)
|
|
}
|
|
|
|
// Object type param, we will get inside the object.
|
|
// To show what's inside nested objects.
|
|
if propValue.Value.Type.Is(openapi3.TypeObject) {
|
|
nestedParam := make(map[string]interface{})
|
|
if hasParam {
|
|
nestedParam = currentParams[propKey].(map[string]interface{})
|
|
}
|
|
ret += printSchema(propValue.Value, nestedParam, indent+1)
|
|
}
|
|
}
|
|
|
|
return ret
|
|
}
|
|
|
|
func generateDependencyString(c client.Client, dependencies []*pkgaddon.Dependency) (string, bool) {
|
|
if len(dependencies) == 0 {
|
|
return "[]", true
|
|
}
|
|
|
|
ret := "["
|
|
allDependenciesInstalled := true
|
|
|
|
for idx, d := range dependencies {
|
|
name := d.Name
|
|
|
|
// Checks if the dependency is enabled, and mark it
|
|
status, err := pkgaddon.GetAddonStatus(context.Background(), c, name)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
|
|
var enabledString string
|
|
switch status.AddonPhase {
|
|
case statusEnabled:
|
|
enabledString = color.GreenString("✔")
|
|
case statusSuspend:
|
|
enabledString = color.RedString("✔")
|
|
default:
|
|
enabledString = color.RedString("✘")
|
|
allDependenciesInstalled = false
|
|
}
|
|
ret += fmt.Sprintf("%s %s", name, enabledString)
|
|
|
|
if idx != len(dependencies)-1 {
|
|
ret += ", "
|
|
}
|
|
}
|
|
|
|
ret += "]"
|
|
|
|
return ret, allDependenciesInstalled
|
|
}
|
|
|
|
func listAddons(ctx context.Context, clt client.Client, registry string) (*uitable.Table, error) {
|
|
var addons []*pkgaddon.UIData
|
|
var err error
|
|
registryDS := pkgaddon.NewRegistryDataStore(clt)
|
|
registries, err := registryDS.ListRegistries(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, r := range registries {
|
|
if registry != "" && r.Name != registry {
|
|
continue
|
|
}
|
|
var addonList []*pkgaddon.UIData
|
|
var err error
|
|
if !pkgaddon.IsVersionRegistry(r) {
|
|
meta, err := r.ListAddonMeta()
|
|
if err != nil {
|
|
continue
|
|
}
|
|
addonList, err = r.ListUIData(meta, pkgaddon.CLIMetaOptions)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
} else {
|
|
versionedRegistry := pkgaddon.BuildVersionedRegistry(r.Name, r.Helm.URL, &common.HTTPOption{
|
|
Username: r.Helm.Username,
|
|
Password: r.Helm.Password,
|
|
InsecureSkipTLS: r.Helm.InsecureSkipTLS,
|
|
})
|
|
addonList, err = versionedRegistry.ListAddon()
|
|
if err != nil {
|
|
continue
|
|
}
|
|
}
|
|
addons = mergeAddons(addons, addonList)
|
|
}
|
|
|
|
table := uitable.New()
|
|
table.AddRow("NAME", "REGISTRY", "DESCRIPTION", "AVAILABLE-VERSIONS", "STATUS")
|
|
|
|
// get locally installed addons first
|
|
locallyInstalledAddons := map[string]bool{}
|
|
appList := v1beta1.ApplicationList{}
|
|
if err := clt.List(ctx, &appList, client.MatchingLabels{oam.LabelAddonRegistry: pkgaddon.LocalAddonRegistryName}); err != nil {
|
|
return table, err
|
|
}
|
|
for _, app := range appList.Items {
|
|
labels := app.GetLabels()
|
|
addonName := labels[oam.LabelAddonName]
|
|
addonVersion := labels[oam.LabelAddonVersion]
|
|
table.AddRow(enabledAddonColor.Sprintf("%s", addonName), app.GetLabels()[oam.LabelAddonRegistry], "", genAvailableVersionInfo([]string{addonVersion}, addonVersion, 3), enabledAddonColor.Sprintf("%s", statusEnabled))
|
|
locallyInstalledAddons[addonName] = true
|
|
}
|
|
|
|
for _, addon := range addons {
|
|
// if the addon with same name has already installed locally, display the registry one as not installed
|
|
if locallyInstalledAddons[addon.Name] {
|
|
table.AddRow(addon.Name, addon.RegistryName, limitStringLength(addon.Description, 60), genAvailableVersionInfo(addon.AvailableVersions, "", 3), "-")
|
|
continue
|
|
}
|
|
status, err := pkgaddon.GetAddonStatus(ctx, clt, addon.Name)
|
|
if err != nil {
|
|
return table, err
|
|
}
|
|
statusRow := status.AddonPhase
|
|
name := addon.Name
|
|
if len(status.InstalledVersion) != 0 {
|
|
statusRow = enabledAddonColor.Sprintf("%s (%s)", statusRow, status.InstalledVersion)
|
|
name = enabledAddonColor.Sprintf("%s", name)
|
|
}
|
|
if statusRow == statusDisabled {
|
|
statusRow = "-"
|
|
}
|
|
table.AddRow(name, addon.RegistryName, limitStringLength(addon.Description, 60), genAvailableVersionInfo(addon.AvailableVersions, status.InstalledVersion, 3), statusRow)
|
|
}
|
|
|
|
return table, nil
|
|
}
|
|
|
|
func waitApplicationRunning(k8sClient client.Client, addonName string) error {
|
|
if dryRun {
|
|
return nil
|
|
}
|
|
trackInterval := 5 * time.Second
|
|
timeout := 600 * time.Second
|
|
start := time.Now()
|
|
ctx := context.Background()
|
|
var app v1beta1.Application
|
|
spinner := newTrackingSpinnerWithDelay("Waiting addon running ...", 1*time.Second)
|
|
spinner.Start()
|
|
defer spinner.Stop()
|
|
|
|
for {
|
|
err := k8sClient.Get(ctx, types2.NamespacedName{Name: addonutil.Addon2AppName(addonName), Namespace: types.DefaultKubeVelaNS}, &app)
|
|
if err != nil {
|
|
return client.IgnoreNotFound(err)
|
|
}
|
|
|
|
phase := app.Status.Phase
|
|
if app.Generation > app.Status.ObservedGeneration {
|
|
phase = common2.ApplicationStarting
|
|
} else {
|
|
switch app.Status.Phase {
|
|
case common2.ApplicationRunning:
|
|
return nil
|
|
case common2.ApplicationWorkflowSuspending:
|
|
fmt.Printf("Enabling suspend, please run \"vela workflow resume %s -n vela-system\" to continue", addonutil.Addon2AppName(addonName))
|
|
return nil
|
|
case common2.ApplicationWorkflowTerminated, common2.ApplicationWorkflowFailed:
|
|
return errors.Errorf("Enabling failed, please run \"vela status %s -n vela-system\" to check the status of the addon", addonutil.Addon2AppName(addonName))
|
|
default:
|
|
}
|
|
}
|
|
|
|
timeConsumed := int(time.Since(start).Seconds())
|
|
applySpinnerNewSuffix(spinner, fmt.Sprintf("Waiting addon application running. It is now in phase: %s (timeout %d/%d seconds)...",
|
|
phase, timeConsumed, int(timeout.Seconds())))
|
|
if timeConsumed > int(timeout.Seconds()) {
|
|
return errors.Errorf("Enabling timeout, please run \"vela status %s -n vela-system\" to check the status of the addon", addonutil.Addon2AppName(addonName))
|
|
}
|
|
time.Sleep(trackInterval)
|
|
}
|
|
|
|
}
|
|
|
|
// generate the available version
|
|
// this func put the installed version as the first version and keep the origin order
|
|
// print ... if available version too much
|
|
func genAvailableVersionInfo(versions []string, installedVersion string, limit int) string {
|
|
var v []string
|
|
|
|
// put installed-version as the first version and keep the origin order
|
|
if len(installedVersion) != 0 {
|
|
for i, version := range versions {
|
|
if version == installedVersion {
|
|
v = append(v, version)
|
|
versions = append(versions[:i], versions[i+1:]...)
|
|
}
|
|
}
|
|
}
|
|
v = append(v, versions...)
|
|
|
|
res := "["
|
|
var count int
|
|
for _, version := range v {
|
|
if count == limit {
|
|
// just show newest 3 versions
|
|
res += "..."
|
|
break
|
|
}
|
|
if version == installedVersion {
|
|
res += enabledAddonColor.Sprintf("%s", version)
|
|
} else {
|
|
res += version
|
|
}
|
|
res += ", "
|
|
count++
|
|
}
|
|
res = strings.TrimSuffix(res, ", ")
|
|
res += "]"
|
|
return res
|
|
}
|
|
|
|
// limitStringLength limits the length of the string, and add ... if it is too long
|
|
func limitStringLength(str string, length int) string {
|
|
if length <= 0 {
|
|
return str
|
|
}
|
|
if len(str) > length {
|
|
return str[:length] + "..."
|
|
}
|
|
return str
|
|
}
|
|
|
|
// TransAddonName will turn addon's name from xxx/yyy to xxx-yyy
|
|
func TransAddonName(name string) string {
|
|
return strings.ReplaceAll(name, "/", "-")
|
|
}
|
|
|
|
func mergeAddons(a1, a2 []*pkgaddon.UIData) []*pkgaddon.UIData {
|
|
for _, item := range a2 {
|
|
if hasAddon(a1, item.Name) {
|
|
continue
|
|
}
|
|
a1 = append(a1, item)
|
|
}
|
|
return a1
|
|
}
|
|
|
|
func hasAddon(addons []*pkgaddon.UIData, name string) bool {
|
|
for _, addon := range addons {
|
|
if addon.Name == name {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func transClusters(cstr string) []interface{} {
|
|
if len(cstr) == 0 {
|
|
return nil
|
|
}
|
|
cstr = strings.TrimPrefix(strings.TrimSuffix(cstr, "}"), "{")
|
|
var clusterL []interface{}
|
|
clusterList := strings.Split(cstr, ",")
|
|
for _, v := range clusterList {
|
|
clusterL = append(clusterL, strings.TrimSpace(v))
|
|
}
|
|
return clusterL
|
|
}
|
|
|
|
// NewAddonPackageCommand create addon package command
|
|
func NewAddonPackageCommand(_ common.Args) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "package",
|
|
Short: "package an addon directory",
|
|
Long: "package an addon directory into a helm chart archive.",
|
|
Example: "vela addon package <addon directory>",
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("must specify addon directory path")
|
|
}
|
|
addonDict, err := filepath.Abs(args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
archive, err := pkgaddon.PackageAddon(addonDict)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "fail to package %s into helm chart archive", addonDict)
|
|
}
|
|
|
|
fmt.Printf("Successfully package addon to: %s\n", archive)
|
|
return nil
|
|
},
|
|
}
|
|
return cmd
|
|
}
|
|
|
|
func splitSpecifyRegistry(name string) (string, string, error) {
|
|
res := strings.Split(name, "/")
|
|
switch len(res) {
|
|
case 2:
|
|
return res[0], res[1], nil
|
|
case 1:
|
|
return "", res[0], nil
|
|
default:
|
|
return "", "", fmt.Errorf("invalid addon name, you should specify name only <addonName> or with registry as prefix <registryName>/<addonName>")
|
|
}
|
|
}
|
|
|
|
func checkUninstallFromClusters(ctx context.Context, k8sClient client.Client, addonName string, args map[string]interface{}) error {
|
|
status, err := pkgaddon.GetAddonStatus(ctx, k8sClient, addonName)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to check addon status: %w", err)
|
|
}
|
|
if status.AddonPhase == statusDisabled {
|
|
return nil
|
|
}
|
|
if _, ok := args["clusters"]; !ok {
|
|
return nil
|
|
}
|
|
cList, ok := args["clusters"].([]interface{})
|
|
if !ok {
|
|
return fmt.Errorf("clusters parameter must be a list of string")
|
|
}
|
|
|
|
clusters := map[string]struct{}{}
|
|
for _, c := range cList {
|
|
clusterName := c.(string)
|
|
clusters[clusterName] = struct{}{}
|
|
}
|
|
var disableClusters, installedClusters []string
|
|
for c := range status.Clusters {
|
|
if _, ok := clusters[c]; !ok {
|
|
disableClusters = append(disableClusters, c)
|
|
}
|
|
installedClusters = append(installedClusters, c)
|
|
}
|
|
if len(disableClusters) == 0 {
|
|
return nil
|
|
}
|
|
fmt.Println(color.New(color.FgRed).Sprintf("'%s' addon was currently installed on clusters %s, but this operation will uninstall from these clusters: %s \n", addonName, generateClustersInfo(installedClusters), generateClustersInfo(disableClusters)))
|
|
input := NewUserInput()
|
|
if !input.AskBool("Do you want to continue?", &UserInputOptions{AssumeYes: false}) {
|
|
return fmt.Errorf("operation abort")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func generateClustersInfo(clusters []string) string {
|
|
ret := "["
|
|
for i, cluster := range clusters {
|
|
ret += cluster
|
|
if i < len(clusters)-1 {
|
|
ret += ","
|
|
}
|
|
}
|
|
ret += "]"
|
|
return ret
|
|
}
|