Kampit Ojha ca9152164f Fix: vela status reports Healthy on workflowFailed with empty services (#7233) ...

* Fix: vela status reports Healthy on workflowFailed with empty services

getAppHealth returned true when status.services was empty (vacuous truth),
so failed apps that never produced component status showed Healthy: ✅.
Treat terminal/unhealthy phases, failed workflow steps, and empty services
as unhealthy, with unit tests.

Signed-off-by: kampitojha <kampitojha@users.noreply.github.com>

* Style: fix import order in status_health_test.go

Signed-off-by: kampitojha <kampitojha@users.noreply.github.com>

* Fix: treat failed workflow substeps as unhealthy in vela status

Address review feedback: scan SubStepsStatus for failed phases so
step-group workflows do not report Healthy when a nested substep failed.

Signed-off-by: kampitojha <kampitojha@users.noreply.github.com>

* Fix: satisfy exhaustive linter on ApplicationPhase switch

Add default case so golangci exhaustive does not fail on intentional
partial phase handling in getAppHealth.

Signed-off-by: kampitojha <kampitojha@users.noreply.github.com>

---------

Signed-off-by: kampitojha <kampitojha@users.noreply.github.com>
Co-authored-by: kampitojha <kampitojha@users.noreply.github.com>

2026-07-14 16:10:48 +01:00

..

adopt-templates

Chore: Upgrade cuelang version to v0.14.1 (#6877)

2025-10-23 10:56:37 +01:00

log

…

resource-topology

…

test-data

Fix: inconsistent dry-run behavior with non-existent namespaces in CLI vs app.yaml (#6896)

2025-09-17 03:10:10 +08:00

top

fix: update YAML import path to use go.yaml.in/yaml/v3 and adjust dependencies in go.mod and go.sum (#6944)

2025-11-06 10:37:19 +00:00

addon_suite_test.go

Chore: update helm repo path in tests (#6797)

2025-06-13 07:13:25 -07:00

addon_test.go

…

addon-registry.go

Chore: update go version to 1.22 (#6560)

2024-07-03 16:10:56 +08:00

addon.go

Fix: Corrects CLI generation and documentation issues (#7095)

2026-04-16 10:25:28 -07:00

adopt_test.go

…

adopt.go

Feat: Cue 0.14.1 Preupgrade CLI Check (#6983)

2026-03-18 21:05:24 -07:00

auth.go

…

cli.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

cluster_test.go

Fix: update apps with topology policy during cluster join (#6768)

2025-05-01 14:31:11 +05:30

cluster.go

Fix: update apps with topology policy during cluster join (#6768)

2025-05-01 14:31:11 +05:30

common.go

Feat: Defkit implementation (#7037)

2026-02-10 15:00:44 +00:00

completion.go

Fix: Corrects CLI generation and documentation issues (#7095)

2026-04-16 10:25:28 -07:00

components.go

Refactor: capabilities and workload in appfile parsing (#6250)

2023-08-10 14:41:20 +08:00

config_test.go

…

config.go

Refactor: use cuex engine (#6575)

2024-07-27 17:44:20 +08:00

cuex_test.go

…

cuex.go

…

debug_test.go

…

debug.go

Chore: imports workflow crd from pkg repo (#6954)

2025-11-06 18:56:04 -08:00

def_compat_test.go

Feat: auto remediate cue issues (#7199)

2026-06-26 05:57:23 -07:00

def_compat.go

Feat: auto remediate cue issues (#7199)

2026-06-26 05:57:23 -07:00

def_go_new_test.go

Feat: Defkit implementation (#7037)

2026-02-10 15:00:44 +00:00

def_module_test.go

fix(cli): pin scaffolded go.mod to running vela binary's version (#7097)

2026-04-19 08:51:17 -07:00

def_module.go

fix(cli): pin scaffolded go.mod to running vela binary's version (#7097)

2026-04-19 08:51:17 -07:00

def_test.go

Fix(cli): return non-zero exit code on vela def render error (#6818)

2025-09-03 06:00:58 +08:00

def_upgrade_flags_test.go

feat: add configurable CUE compatibility upgrade controls (#7229)

2026-07-09 17:37:52 +01:00

def.go

feat: add configurable CUE compatibility upgrade controls (#7229)

2026-07-09 17:37:52 +01:00

defapply_test.go

…

delete.go

Chore: (deps): Update k8s to 1.29 (#6654)

2025-01-03 07:54:42 +08:00

dryrun_test.go

Chore: bumps up pkg and workflow dependency versions (#7026)

2026-01-20 15:32:03 +00:00

dryrun.go

Chore: bumps up pkg and workflow dependency versions (#7026)

2026-01-20 15:32:03 +00:00

env_test.go

…

env.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00

exec.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00

export.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00

help.go

…

init.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

install_test.go

Chore: swtich between old and new registry in vela install (#6173)

2023-07-04 12:15:30 +08:00

install.go

Chore: update go and golangci version (#6767)

2025-04-29 03:46:08 +08:00

kube_test.go

…

kube.go

fix: update YAML import path to use go.yaml.in/yaml/v3 and adjust dependencies in go.mod and go.sum (#6944)

2025-11-06 10:37:19 +00:00

livediff.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00

logs.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

ls_test.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

ls.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

pods.go

…

policy_test.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

policy.go

feat: application-scoped policies (#7067)

2026-03-19 07:58:15 -07:00

portforward_test.go

…

portforward.go

Chore: upgrade Kubernetes dependencies to v0.31.10 & enhance CLI, workflows, tests, and documentation (#6837)

2025-07-31 07:46:56 -07:00

print.go

Feature: Enhanced Status Reporting (#6828)

2025-08-06 09:55:30 -07:00

provider_test.go

…

provider.go

…

registry_test.go

…

registry.go

Refactor: use cuex engine (#6575)

2024-07-27 17:44:20 +08:00

revision_test.go

Chore: Upgrade cuelang version to v0.14.1 (#6877)

2025-10-23 10:56:37 +01:00

revision.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00

show_test.go

…

show.go

Feat: Defkit implementation (#7037)

2026-02-10 15:00:44 +00:00

showdef_test.go

…

status_health_test.go

Fix: vela status reports Healthy on workflowFailed with empty services (#7233)

2026-07-14 16:10:48 +01:00

status.go

Fix: vela status reports Healthy on workflowFailed with empty services (#7233)

2026-07-14 16:10:48 +01:00

suite_test.go

Chore: (deps): Update k8s to 1.29 (#6654)

2025-01-03 07:54:42 +08:00

system.go

…

top.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00

traits_test.go

…

traits.go

Refactor: capabilities and workload in appfile parsing (#6250)

2023-08-10 14:41:20 +08:00

uischema_test.go

…

uischema.go

Fix: Corrects CLI generation and documentation issues (#7095)

2026-04-16 10:25:28 -07:00

uninstall_test.go

…

uninstall.go

…

up_test.go

Fix: vela up command to behave similarly with kubectl (#6809)

2025-06-23 21:25:45 -07:00

up.go

Fix: vela up command to behave similarly with kubectl (#6809)

2025-06-23 21:25:45 -07:00

utils_test.go

…

utils.go

Refactor: use cuex engine (#6575)

2024-07-27 17:44:20 +08:00

velaql_test.go

Feat: webhook reject unknown cr outputs (#6932)

2025-09-30 09:30:53 -07:00

velaql.go

Fix: Corrects CLI generation and documentation issues (#7095)

2026-04-16 10:25:28 -07:00

workflow_test.go

Chore: bumps up pkg and workflow dependency versions (#7026)

2026-01-20 15:32:03 +00:00

workflow.go

Chore: bumps up pkg and workflow dependency versions (#7026)

2026-01-20 15:32:03 +00:00

workloads.go

Fix: vela cli namespace behaviour (#6805)

2025-06-17 10:25:59 +08:00