Anas Khan and GitHub
6fd0e71e50
Fix: prevent panics in ParseGitlab on malformed addon registry URLs ( #7206 )
...
ParseGitlab indexed the results of splitting the address without bounds
checks, so a malformed (but repo-name-matching) GitLab registry URL crashed
the controller/CLI instead of returning an error. Three inputs panic today:
- https://gitlab.com/catalog -> slice bounds out of range [:-1]
- https://gitlab.com/kubevela/catalog/tree -> index out of range [2]
- https://catalog.gitlab.com/kubevela/foo -> index out of range [1]
Add length/empty guards that return the existing invalid-format error
(errInvalidFormatMsg, consistent with Parse) for the empty owner slice, the
short host split, and the missing tree branch segment. Behaviour for all
currently-valid inputs is unchanged.
Also fix the caller NewAsyncReader, which dereferenced the returned content
before checking the error: on any ParseGitlab error content is nil, so the
assignment nil-panicked before the error could be returned. Move the error
check above the dereference.
Extend TestParseGitlab with the three malformed cases (wantErr).
Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com >
2026-07-15 11:16:48 +01:00
Daniel Higuero and GitHub
1a001e5b29
Address GolangCI lint 1.55 errors ( #6453 )
...
Signed-off-by: Daniel Higuero <daniel@napptive.com >
2024-02-07 17:27:32 +08:00
83fe4a160e
Feat(lang): add addons gitlab support ( #3543 )
...
* add addons gitlab support
Signed-off-by: Namo <lgj112113@163.com >
* add addons gitlab support
Signed-off-by: Namo <lgj112113@163.com >
* test file edit
Signed-off-by: Namo <lgj112113@163.com >
* typo edit
Signed-off-by: Namo <lgj112113@163.com >
* notes edit
Signed-off-by: Namo <lgj112113@163.com >
* move third party imports block
Signed-off-by: Namo <lgj112113@163.com >
* code format edit
Signed-off-by: Namo <lgj112113@163.com >
* notes edit
Signed-off-by: Namo <lgj112113@163.com >
* create addon registry bug fix
Signed-off-by: Namo <lgj112113@163.com >
* add gitlab addon registry bug fix
Signed-off-by: Namo <lgj112113@163.com >
* add addon gitlab support test file
Signed-off-by: Namo <lgj112113@163.com >
* add addon gitlab support test note edit
Signed-off-by: Namo <lgj112113@163.com >
* add addon gitlab branch support and fix bug
Signed-off-by: Namo <lgj112113@163.com >
* addon gitlab registry repo name invalid
Signed-off-by: Namo <lgj112113@163.com >
Co-authored-by: Namo <lgj112113@163.com >
2022-04-07 11:05:14 +08:00
Somefive and GitHub
795231ceb5
Feat: add revision command ( #3506 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2022-03-28 14:47:47 +08:00
52f3636a2d
Feat: support gitee repository in addon registry ( #3393 )
...
* Feat: support gitee repository in addon registry
Signed-off-by: fourierr <maxiangboo@163.com >
* Feat: support gitee repository in addon registry
Signed-off-by: maxiangbo <maxiangboo@cmbchina.com >
Signed-off-by: fourierr <maxiangboo@yeah.net >
* Feat: support gitee repository in addon registry Signed-off-by: maxiangbo <maxiangboo@cmbchina.com >
* Feat: support gitee repository in addon registry Signed-off-by: maxiangbo <maxiangboo@cmbchina.com >
Signed-off-by: fourierr <maxiangboo@qq.com >
Co-authored-by: fourierr <maxiangboo@yeah.net >
2022-03-10 10:11:45 +08:00
wyike and GitHub
c170cecd34
fix addon panic bug ( #3026 )
...
Signed-off-by: wangyike <wangyike_wyk@163.com >
Fix lint
Signed-off-by: wangyike <wangyike_wyk@163.com >
2022-01-05 13:40:51 +08:00
qiaozp and GitHub
a6ef0644ff
Feat: oss suppurt for addon ( #2848 )
...
* Add OSS source support for addon
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* add unit test for pkg/addon
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* fix lint
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* add license
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
2021-12-01 19:15:48 +08:00
Hongchao Deng
5c46aa2f7f
fix header
2021-11-22 19:07:13 +08:00
3ebc94394c
Feat: addon service impl ( #2515 )
...
* Feat: addon service impl
* get addon from git/configmap
* add ListAddonRegistries
* add GetAddonModel
* add CreateAddonRegistry and bcode/addon.go
* add applyAddonData
* update
* Fix: getAddonFromGit
* Fix: getAddonFromGit, remove trailing .git
* add comment
* add enable/disable/status impl
* add deleteAddonRegistry and check dup addon
* read addon without accessing database
* change to query parameter, add addon detail
* Feat: add addon readme for apiserver
* Make enable/disable/status runnable
* chore: fix bcode
* Fix: refactor parse to util
* Fix: refactor addonutil to pkg
* add addon test for create and delete addon registry
* fix version prefix
* add post func
* add enable/disable test
* add provider aws readme
* done testing
* fix comment and refactor statusAddon
* move enable/disable logic to usecase
* add GITHUB_TOKEN env
* Fix: Add github token support and use it in test
* add license
Co-authored-by: qiaozp <chivalry.pp@gmail.com >
2021-10-26 17:52:34 +08:00