lif
e65938087d
Feat: Validate undeclared parameters in application definitions ( #7075 )
...
* Feat: Validate undeclared parameters in application definitions (#6862 )
Add a new feature gate ValidateUndeclaredParameters that rejects
parameters not declared in the CUE definition schema at admission time.
When enabled, any parameter field not present in the template's parameter
stanza will cause a validation error.
Signed-off-by: majiayu000 <1835304752@qq.com >
* Fix: Handle CUE pattern constraints and improve undeclared param validation
- Detect pattern constraints ([string]: T) using LookupPath to avoid
false positives on webservice labels/annotations fields
- Use GetSelectorLabel() for safe selector extraction
- Add klog debug logging when schema compilation fails
- Sort undeclared field names for deterministic error messages
- Add test cases for pattern constraints and sorted output
Signed-off-by: majiayu000 <1835304752@qq.com >
* Fix: go fmt alignment in validate_test.go
Signed-off-by: majiayu000 <1835304752@qq.com >
* fix: address review feedback on PR #7075
- Handle conditional parameter declarations via two-pass schema
compilation: first without params for base fields, then with
declared params to resolve CUE conditionals
- Return nil from findUndeclaredFields when schema.Fields() errors
to prevent false positives from empty declared map
- Recurse into list elements containing structs using cue.AnyIndex
so undeclared fields inside arrays are detected
- Save/restore previous feature gate state in tests instead of
resetting to fixed values
Signed-off-by: majiayu000 <1835304752@qq.com >
---------
Signed-off-by: majiayu000 <1835304752@qq.com >
2026-03-22 12:45:02 -07:00
Brian Kane
38dea0b56c
feat: application-scoped policies ( #7067 )
...
Introduces application-scoped policies and global auto-applied policies
for KubeVela.
Key changes:
- PolicyDefinition gains `scope`, `global`, and `priority` fields
- Global policies (global=true, scope=Application) are auto-applied to
every Application in their namespace (and vela-system globals apply
cluster-wide) without being listed in spec.policies
- PolicyScopeIndex: in-memory singleton index of PolicyDefinition
metadata, bootstrapped at startup and kept live via watch events.
Follows KubeVela's 2-step lookup (local namespace → vela-system)
- ApplicationPolicyCache: per-app cache of rendered policy results,
invalidated by spec hash, revision hash, or TTL; cleared on deletion
- Policy rendering pipeline extended to inject global policies before
user-specified ones, respecting priority ordering
- Appfile.Context carries context.Context from controller into rendering
- Feature gates: EnableApplicationScopedPolicies and EnableGlobalPolicies
(both Alpha, default false); admission webhook warns when a
PolicyDefinition targets a disabled gate
Signed-off-by: Brian Kane <briankane1@gmail.com >
2026-03-19 07:58:15 -07:00
Brian Kane
61e06c0bbb
Feat: Immutable Parameters ( #7059 )
...
Signed-off-by: Brian Kane <briankane1@gmail.com >
2026-03-18 21:11:22 -07:00
Brian Kane
7c06ee2060
Fix: Prevent app validation errors when traits are used alongside workflow data passing ( #7031 )
...
Webhook Upgrade Validation / webhook-upgrade-check (push) Failing after 51m50s
Signed-off-by: Brian Kane <briankane1@gmail.com >
2026-01-23 18:03:09 +00:00
Amit Singh
5ead6db8d7
Chore: bumps up pkg and workflow dependency versions ( #7026 )
...
Webhook Upgrade Validation / webhook-upgrade-check (push) Failing after 1m29s
* chore: bumps up workflow and pkg versions and updates import statements
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* chore: minor linter fixes
Signed-off-by: Amit Singh <singhamitch@outlook.com >
---------
Signed-off-by: Amit Singh <singhamitch@outlook.com >
2026-01-20 15:32:03 +00:00
Amit Singh
0b85d55e68
Feat: post dispatch output context ( #7008 )
...
Webhook Upgrade Validation / webhook-upgrade-check (push) Failing after 1m46s
* exploring context data passing
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* adds output status fetch logic
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: standardize import in dispatcher.
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* feat: Allow traits to access workload output status in CUE context
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* feat: Implement PostDispatch traits that apply after component health is confirmed.
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* feat: Refactor trait handling and status propagation in application dispatch.
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: run make reviewable
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* feat: Implement and document PostDispatch traits, applying them after component health is confirmed and guarded by a feature flag, along with new example applications.
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* feat: Add comments
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Fix: Restore the status field in ctx.
Signed-off-by: Vaibhav Agrawal <vaibhav.agrawal0096@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Fix: Error for evaluating the status of the trait
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* refactor: removes minor unnecessary changes
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* refactor: minor linter changes
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* test: Add comprehensive tests for PostDispatch traits and their status handling
Signed-off-by: Reetika Malhotra <malhotra.reetika25@gmail.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Fix: Increase multi-cluster test time
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Chore: Add focus and print the application status
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Chore: print deployment status in the multicluster test
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Chore: add labels for the deployment
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* debugging test failure
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* debugging test failure by updating multi cluster ctx
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* undoes multi cluster ctx change
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Feat: enable MultiStageComponentApply feature by default
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Feat: implement post-dispatch traits application in workflow states
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Chore: remove unnecessary blank lines in application_controller.go
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Feat: enhance output readiness handling in health checks
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Feat: add logic to determine need for post-dispatch outputs in workload processing
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* Feat: enhance output extraction and dependency checking for post-dispatch traits
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix code to exclude validation of post dispatch trait in webhook
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix code to exclude validation of post dispatch trait in webhook
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* commit for running the test again
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* commit for running the test again
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* commit for running the test again
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* triggering checks
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* chore: adds explanation comments
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* chore: adds errors to context
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* chore: minor improvements
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* fix: update output handling for pending PostDispatch traits
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: improve output handling for PostDispatch traits in deploy process
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: streamline output handling in PostDispatch process
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* chore: commit to re run the pipeline
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* chore: commit to re run the pipeline
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* chore: commit to re run the pipeline
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: enhance output status handling in PostDispatch context for multi-stage support
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* chore: commit to re run the pipeline
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: increase timeout for PostDispatch trait verification in tests
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* fix: enhance output status handling in PostDispatch context for multi-stage support
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* chore: commit to re run the pipeline
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
---------
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
Signed-off-by: Chaitanyareddy0702 <chaitanyareddy0702@gmail.com >
Signed-off-by: Vaibhav Agrawal <vaibhav.agrawal0096@gmail.com >
Signed-off-by: Reetika Malhotra <malhotra.reetika25@gmail.com >
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
Co-authored-by: Chitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
Co-authored-by: Vishal Kumar <vishal210893@gmail.com >
2026-01-14 10:28:13 +00:00
Brian Kane
432ffd3ddd
Feat: Improve Cue Error Reporting ( #6984 )
...
Webhook Upgrade Validation / webhook-upgrade-check (push) Failing after 11m49s
Signed-off-by: Brian Kane <briankane1@gmail.com >
2026-01-07 14:37:06 +00:00
Bryan Leong
358e46e628
Style: clean up dry-run ( #7007 )
...
Webhook Upgrade Validation / webhook-upgrade-check (push) Failing after 13m45s
- Remove trailing whitespace on dryrun outputs
- Fixed the relevant plugin-test outputs
- Refactor to avoid partial lines that codecov flags out
Signed-off-by: Bryan Leong <leong.bryan@gmail.com >
2025-12-16 11:18:14 +00:00
AshvinBambhaniya2003
3f5b698dac
Feat(appfile): Add comprehensive unit tests for appfile and component package ( #6908 )
...
* feat(appfile): Add comprehensive unit tests for appfile package
This commit significantly enhances the test coverage for the `pkg/appfile` package by adding a comprehensive suite of new unit tests. These tests improve the reliability of core application parsing, generation, and validation logic.
Key additions include:
- **Parsing:** New tests for policy parsing, legacy application revision handling, and dynamic component loading.
- **Manifest Generation:** Added coverage for `GenerateComponentManifests` and `GeneratePolicyManifests` to ensure correctness of generated resources.
- **OAM Contracts:** New tests for `SetOAMContract` and `setWorkloadRefToTrait` to verify OAM label and reference injection.
- **Template & Context:** Added tests for loading templates from revisions (`LoadTemplateFromRevision`) and preparing the process context (`PrepareProcessContext`).
- **Validation:** Enhanced validation tests for component parameters and uniqueness of output names.
As part of this effort, the existing tests were also migrated from Ginkgo to the standard `testing` package with `testify/assert` to maintain consistency across the codebase.
Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com >
* refactor(pkg/component): Migrate ref-objects tests to standard Go testing and add new test cases
This commit refactors the unit tests for `pkg/component/ref-objects` from a Ginkgo-based suite to the standard Go `testing` package. Additionally, new unit test cases have been added to further enhance test coverage and ensure the robustness of the `ref-objects` functionality.
Key changes include:
- Deletion of `pkg/component/ref_objects_suite_test.go`.
- Introduction of `pkg/component/main_test.go` to manage test environment setup and teardown using `TestMain`.
- Creation of `pkg/component/ref_objects_test.go` containing all the ref-objects related unit tests, now using standard Go testing functions, along with newly added test cases for improved coverage.
This migration improves consistency with other unit tests in the codebase and leverages the native Go testing framework.
Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com >
* chore(pkg/component): Reorder imports in ref_objects_test.go
This commit reorders the import statements in `pkg/component/ref_objects_test.go` to adhere to standard Go formatting and import grouping conventions. This change improves code readability and consistency.
Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com >
---------
Signed-off-by: Ashvin Bambhaniya <ashvin.bambhaniya@improwised.com >
2025-10-17 10:45:45 +01:00
Ayush Kumar
36f217e258
Feat: webhook reject unknown cr outputs ( #6932 )
...
* feat: implement output resource existence validation in component, trait, and policy definitions
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add validation tests for ComponentDefinition and TraitDefinition outputs
- Implement tests for ComponentDefinition with non-existent CRDs in outputs, ensuring they are rejected.
- Add tests for valid outputs in ComponentDefinition, confirming acceptance.
- Include tests for mixed valid and non-K8s outputs in ComponentDefinition, verifying they pass validation.
- Test handling of empty outputs in ComponentDefinition, ensuring they are accepted.
- Introduce tests for invalid apiVersion formats in ComponentDefinition, confirming rejection.
- Add tests for TraitDefinition with mixed valid and invalid outputs, ensuring proper rejection.
- Create YAML manifests for valid and invalid ComponentDefinitions and TraitDefinitions to support e2e tests.
- Ensure comprehensive coverage of edge cases in output validation logic.
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
fix: handle errors in resource validation for component, trait, and policy definitions
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
fix: improve error handling in Go module tidy and resource validation
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add webhook debugging setup and validation tests for ComponentDefinition and TraitDefinition
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add VS Code launch configuration for debugging webhook validation
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
refactor: streamline error handling in Go module tidy and remove obsolete test manifests
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add mock context support for CUE template compilation
Signed-off-by: Reetika Malhotra <malhotra.reetika25@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: enhance validation for WorkflowStepDefinition resources and improve output resource checks
Signed-off-by: viskumar <viskumar@guidewire.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: implement resource validation for CUE templates and add unit tests
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: enhance logging and validation for component, policy, and trait definitions
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: improve error handling and logging in validation handlers for component, policy, trait, and workflow step definitions
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Remove testUnknownResource folder from repository
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: implement structured logging for validation handlers and remove deprecated request_logger
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: enhance structured logging and error handling in admission validation handlers
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: improve logging messages in validating handlers for better clarity
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: refactor logging field definitions for consistency and improve error handling in resource validation
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
chore: add license header to invalid_resource_check.go and invalid_resource_check_test.go
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: enhance validation tests for WorkflowStepDefinition and improve error messages
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add e2e-test-local target for k3d cluster setup and webhook validation
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add webhook configuration for workflow step definitions with validation rules
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: update e2e-test-local configuration and improve Ingress API version compatibility
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add installation of FluxCD CRDs in pre-hook to prevent webhook validation errors
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add ValidateResourcesExist feature gate and enhance resource validation in webhook handlers
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: enhance resource validation in e2e tests and improve addon definition checks
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: enhance addon definition detection by using owner references for validation
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: add ValidateResourcesExist feature gate and implement webhook validation for resource existence
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: update Ingress API version to v1 and adjust service references in tests
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
chore: remove webhook test commands and related YAML files from makefiles and tests
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
chore: remove architecture section from webhook debugging guide
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
feat: update webhook setup script with k3d host gateway IP note and improve cluster creation logic
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
* Fix: Correct path in Ingress resource definition in template tests
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
* Chore: add empty line to re-trigger failing workflow
Signed-off-by: Vaibhav Agrawal <vaibhav.agrawal0096@gmail.com >
* Chore: remove space to re-trigger workflow
Signed-off-by: Chaitanya Reddy Onteddu <co@guidewire.com >
---------
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: Vaibhav Agrawal <vaibhav.agrawal0096@gmail.com >
Signed-off-by: Chaitanya Reddy Onteddu <co@guidewire.com >
Co-authored-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
Co-authored-by: Amit Singh <amisingh@guidewire.com >
2025-09-30 09:30:53 -07:00
Vaibhav Agrawal
90e601a51e
Fix: inconsistent dry-run behavior with non-existent namespaces in CLI vs app.yaml ( #6896 )
2025-09-17 03:10:10 +08:00
Brian Kane
56bc3b02e9
Feat: Consolidate Health & Status and Pass Status Context Data ( #6860 )
...
Signed-off-by: Brian Kane <briankane1@gmail.com >
2025-08-24 02:30:06 +08:00
Brian Kane
a27261bd14
Feature: Enhanced Status Reporting ( #6828 )
...
Signed-off-by: Brian Kane <briankane1@gmail.com >
2025-08-06 09:55:30 -07:00
Vishal Kumar
d3ce7ad118
Feat(validation): fail-fast CUE validation for required parameters (incl. dynamic sources) ( #6774 )
...
* Chore: Added fail fast validation logic of component having multiple steps including workflow, component etc.
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* testing updated param filter logic
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* Added validation logic for struct type parameter
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* fixed code when struct type parameter is provided in component
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* refactor: minor code improvements
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* fixed go lint issue
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Chore: Add test cases for fail fast logic
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
* updated expect logic
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Added e2e test cases for required param validation
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Added feature gate in e2e test cases for required param validation
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Added feature gate make e2e_test file and removed for ginkgo test file
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Fixed code to quoted string
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Added logic and test case for policy type override
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
* Added license header
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
---------
Signed-off-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: Vishal Kumar <vishal210893@gmail.com >
Co-authored-by: Amit Singh <singhamitch@outlook.com >
Co-authored-by: Chaitanya Reddy Onteddu <chaitanyareddy0702@gmail.com >
2025-05-03 12:54:05 +05:30
Jonatas Teixeira
853a077107
Fix(parser) - The app.Spec.Policies[idx].Name must be a valid string ( #6723 )
...
* Fix(parser) - Valid value must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character
Signed-off-by: Jonatas Teixeira <jonatas.teixeira@hellofresh.com >
* Fix(e2e) - Increase waiting to prevent test start before port-forwared be finished
Signed-off-by: Jonatas Teixeira <jonatas.teixeira@hellofresh.com >
* Fix(e2e) - Adjust the time
Signed-off-by: Jonatas Teixeira <jonatas.teixeira@hellofresh.com >
* Fix(e2e) - Increase waiting to prevent test start before port-forwared be finished - By using gomega
Signed-off-by: Jonatas Teixeira <jonatas.teixeira@hellofresh.com >
* Fix(e2e) - Change vela command to get app status
Signed-off-by: Jonatas Teixeira <jonatas.teixeira@hellofresh.com >
---------
Signed-off-by: Jonatas Teixeira <jonatas.teixeira@hellofresh.com >
2025-03-25 02:28:45 +05:30
Kanchan Dhamane
bc15e5b359
Feat: Semantic versioning support for Definitions ( #6648 )
...
CodeQL / Analyze (go) (push) Failing after 1m43s
Definition-Lint / definition-doc (push) Failing after 6m13s
E2E MultiCluster Test / detect-noop (push) Successful in 24s
E2E Test / detect-noop (push) Successful in 17s
Go / detect-noop (push) Successful in 21s
license / Check for unapproved licenses (push) Failing after 2m38s
Registry / publish-core-images (push) Failing after 40s
Unit-Test / detect-noop (push) Successful in 20s
E2E MultiCluster Test / e2e-multi-cluster-tests (v1.29) (push) Failing after 1m55s
E2E Test / e2e-tests (v1.29) (push) Failing after 1m18s
Go / staticcheck (push) Successful in 18m35s
Go / lint (push) Failing after 19m38s
Go / check-diff (push) Failing after 15m7s
Go / check-core-image-build (push) Failing after 3m45s
Go / check-cli-image-build (push) Failing after 2m23s
Unit-Test / unit-tests (push) Failing after 12m43s
Go / check-windows (push) Has been cancelled
Scorecards supply-chain security / Scorecards analysis (push) Failing after 48s
* feature: Add Semantic versioning to KubeVela Definitions
Fixes https://github.com/kubevela/kubevela/issues/6435
Fixes https://github.com/kubevela/kubevela/issues/6534
Changes:
- Adds an optional "Version" field for all Definition Specs.
- Adds the following new validations to Webhooks for Definitions:
- Validate the "Version" field follows Semantic versioning.
- Dis-allow conflicting versioning fields ( Name annotation, Spec.Version)
- Adds the following new validations to Webhooks for Application:
- Dis-allow the use of both the "publishVersion" & "autoUpdate" annotations.
- Enahnce "multiStageComponentApply" feature to support auto updates.
Boy Scout Changes:
- Fixes Plugin e2e tests broken by the fix for 6534.
- Fixes the dryRun and livediff commands to respect the "-n" namespace flag.
- Fixes the Application ValidationWebhook to respect the "-n" namespace flag.
Co-authored-by: Rahul Kumar <35751394+bugbounce@users.noreply.github.com >
Co-authored-by: Chaitanya Reddy <chaitanyareddy0702@gmail.com >
Co-authored-by: Vibhor Chinda <vibhorchinda@gmail.com >
Co-authored-by: Shivin Gopalani <gopalanishivin@gmail.com >
Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com >
* feature: Add KEP to define the proposal
Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com >
* fix: Rebase and fix merge conflicts
Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com >
* Fix: Adds unit test cases
Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com >
---------
Signed-off-by: kanchan-dhamane <74534570+kanchan-dhamane@users.noreply.github.com >
Co-authored-by: bugbounce <35751394+bugbounce@users.noreply.github.com >
2025-02-03 11:09:28 +08:00
Ai Ranthem
a5606b7808
Chore: (deps): Update k8s to 1.29 ( #6654 )
...
CodeQL / Analyze (go) (push) Failing after 6m23s
Definition-Lint / definition-doc (push) Failing after 3m8s
E2E MultiCluster Test / detect-noop (push) Successful in 6s
E2E Test / detect-noop (push) Successful in 3s
Go / detect-noop (push) Successful in 2s
license / Check for unapproved licenses (push) Failing after 18s
Registry / publish-core-images (push) Failing after 1m4s
Unit-Test / detect-noop (push) Successful in 20s
Sync SDK / sync_sdk (push) Failing after 3m9s
Go / staticcheck (push) Successful in 6m17s
Go / check-diff (push) Failing after 19m4s
Go / check-core-image-build (push) Failing after 5m44s
Go / check-cli-image-build (push) Failing after 3m31s
Unit-Test / unit-tests (push) Failing after 13m54s
Go / lint (push) Failing after 1h53m27s
Scorecards supply-chain security / Scorecards analysis (push) Failing after 1m27s
E2E MultiCluster Test / e2e-multi-cluster-tests (v1.29) (push) Has been cancelled
E2E Test / e2e-tests (v1.29) (push) Has been cancelled
Go / check-windows (push) Has been cancelled
* chore: update k8s to 1.29
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* fix: unit test
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* fix: lint
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* fix: lint
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* fix: e2e
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* fix: lint and e2e test
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* test(e2e): increase timeout
Signed-off-by: phantomnat <w.nattadej@gmail.com >
* fix e2e and scripts
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com >
* make reviewable
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com >
* rollback a unnecessary ut change
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com >
* update go.mod to import merged workflow
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com >
---------
Signed-off-by: phantomnat <w.nattadej@gmail.com >
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com >
Co-authored-by: phantomnat <w.nattadej@gmail.com >
2025-01-03 07:54:42 +08:00
Tianxin Dong
4f8bf44684
Refactor: use cuex engine ( #6575 )
...
* refactor: use cuex engine
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix lint
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix unit test
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix static check and sdk tests
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix testdata
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix velaql unit test
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix docgen parser
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix cuegen
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix velaql
Signed-off-by: FogDong <fog@bentoml.com >
* fix: delete useless print
Signed-off-by: FogDong <fog@bentoml.com >
* fix: set client for ql
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix mt tests
Signed-off-by: FogDong <fog@bentoml.com >
* fix: set kubeclient in generator
Signed-off-by: FogDong <fog@bentoml.com >
* fix: use pass kube client
Signed-off-by: FogDong <fog@bentoml.com >
* fix: simplify ql
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix lint
Signed-off-by: FogDong <fog@bentoml.com >
* fix: add wf debug back
Signed-off-by: FogDong <fog@bentoml.com >
* fix: add loader
Signed-off-by: FogDong <fog@bentoml.com >
---------
Signed-off-by: FogDong <fog@bentoml.com >
2024-07-27 17:44:20 +08:00
Daniel Higuero
1a001e5b29
Address GolangCI lint 1.55 errors ( #6453 )
...
Signed-off-by: Daniel Higuero <daniel@napptive.com >
2024-02-07 17:27:32 +08:00
qiaozp
94cbcad471
Chore: tidy appHandler ( #6300 )
2023-08-28 11:01:33 +08:00
qiaozp
bab5bb2caf
Refactor: capabilities and workload in appfile parsing ( #6250 )
2023-08-10 14:41:20 +08:00
qiaozp
00ae0c9494
Feat: support offline dryrun with deploy step ( #6234 )
2023-07-26 18:09:01 +08:00
JohnJan
f3e920ab60
Refactor: parse workloads ( #6185 )
...
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com >
2023-07-05 09:49:34 +08:00
StevenLeiZhang
90246065d9
Fix: vela dry-run can not render Applicaiton, if x-definition(Compnent/Trait) is not installed to vela-system namespace ( #6135 )
...
Signed-off-by: StevenLeiZhang <zhangleiic@163.com >
2023-06-27 23:08:23 +08:00
Somefive
f1bae16723
Chore: remove schematic kube and helm ( #6099 )
...
* Chore: remove unused code
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* Chore: remove schematic Kube & Helm
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-06-12 10:41:02 +08:00
Somefive
c255d21ad6
Chore: remove unnecessary go mod ( #6093 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-06-08 15:32:57 +08:00
Somefive
f15eba2c5f
Chore: remove legacy rollout and scope ( #6068 )
...
* Chore: remove legacy rollout & scope
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* remove outdated params
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* fix
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-06-05 10:57:38 +08:00
Somefive
dd899c2b39
Chore: remove outdated apis(v1alppha2 ApplicationConfiguration Component, and HealthScope, Rollout) ( #6041 )
...
* remove outdated api
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* fix rt test: no component rt
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* recover context.revision to component hash
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-06-01 09:32:49 +08:00
Somefive
ef4bb07fb3
Chore: remove dm ( #6036 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-05-25 13:54:35 +08:00
Somefive
0df7803022
Feat: add validation for invalid definition attribute ( #6029 )
...
* Feat: add validation for invalid definition attribute
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* fix flaky test
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-05-24 16:40:42 +08:00
yyzxw
3cb0f7b330
refactor: parse trait & scope ( #6017 )
...
Signed-off-by: yyzxw <1020938856@qq.com >
2023-05-22 19:21:01 +08:00
Somefive
530d7c5bd6
Feat: support resource update policy ( #6003 )
2023-05-17 16:11:06 +08:00
yyzxw
1af82cd282
cleanup: remove unused code and fix typo ( #5986 )
...
Signed-off-by: yyzxw <1020938856@qq.com >
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io >
Co-authored-by: xiaowu.zhu <xiaowu.zhu@daocloud.io >
2023-05-16 12:37:00 +08:00
Somefive
d59b116d06
Feat: upgrade ginkgo to v2 ( #5940 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-05-15 16:07:51 +08:00
Somefive
e828d3c8cf
Feat: allow empty policy name ( #5917 )
2023-05-04 16:48:43 +08:00
Somefive
0174e9aa1f
Fix: multi cluster inline policy load extra definitions ( #5901 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-04-24 10:19:25 +08:00
Somefive
d8af202242
Feat: upgrade k8s.io to 0.26 ( #5758 )
...
* Feat: upgrade k8s.io to 0.26
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* Feat: replace temp replace
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-04-10 11:19:05 +08:00
Somefive
542b32bcf4
Chore: fix definition parse logic and allow if/for comprehension & use op.#Suspend for deploy ( #5743 )
...
* Chore: fix definition parse logic and allow if/for comprehension & use op.#Suspend for deploy
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* Fix: flaky mc test
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* Fix: flaky mc test
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-03-28 15:35:15 +08:00
Somefive
5790e57423
Feat: remove comp name dup check ( #5727 )
2023-03-24 15:21:58 +08:00
Somefive
50458bc455
Feat: memory optimization via enhance informer cache ( #5683 )
2023-03-20 10:19:21 +08:00
barnettZQG
79f1d5cb03
Chore: optimize the package dependencies ( #5596 )
...
* Chore: optimize the package dependces
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Fix: the code style
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Fix: remove the repetitive context
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Fix: change the context key
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Fix: Optimize the e2e test case
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
---------
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
2023-03-07 16:19:37 +08:00
Somefive
65215c00e4
Feat: refactor prometheus metrics ( #5592 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-03-01 14:32:35 +08:00
Somefive
b7e0cd86be
Feat: add deploy inline policy and support loading definitions when lack in the revision ( #5416 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-02-06 15:58:44 +08:00
Somefive
ce63df6b26
Feat: enhance health check to support bypass component check and add parameter to context ( #5412 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-02-03 15:49:13 +08:00
Somefive
cca8338832
Fix: ignore validation webhook for ref-objects typed component ( #5397 )
...
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-02-01 16:00:38 +08:00
barnettZQG
fbaea02408
Fix: the developer user can't load the definition ( #5317 )
...
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
2023-01-11 18:27:56 +08:00
cezhang
1ce5c6d8ea
Feat: vela dry-run render results should be affected by override policy and deploy workflowstep ( #4815 )
...
* [Feature] vela dry-run render results should be affected by override policy and deploy workflowstep
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
* multiple input files support; policy,workflow support; new flag: merge orphan policy or workflow
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
* add more tests
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
* fix comment issues
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
* add tests
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
* fix e2e
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
* fix tests
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
Signed-off-by: cezhang <c1zhang.dev@gmail.com >
2023-01-11 13:52:49 +08:00
my-git9
2fb0633354
cleanup ioutil for newer go version ( #5238 )
...
Signed-off-by: xin.li <xin.li@daocloud.io >
Signed-off-by: xin.li <xin.li@daocloud.io >
2022-12-29 19:34:45 +08:00
Joshua Agboola
a9bc43a9dd
Feat: Support SSH for retrieving terraform modules in private git repo ( #5059 )
...
* Feat: Support SSH for retrieving terraform modules in private git repo
Signed-off-by: motilayo <44736801+motilayo@users.noreply.github.com >
* fix lint errors
Signed-off-by: motilayo <44736801+motilayo@users.noreply.github.com >
* fix gofmt lint error
Signed-off-by: motilayo <joshuaagboola@live.ca >
* update gitCredentialsReference to gitCredentialsSecretReference, validate secret, improve known_hosts logic
Signed-off-by: motilayo <joshuaagboola@live.ca >
* SImplify logic to get publickey
Signed-off-by: motilayo <joshuaagboola@live.ca >
* Set known_hosts and export SSH_KNOWN_HOSTS
Signed-off-by: motilayo <joshuaagboola@live.ca >
* Call GetGitSSHPublicKey for cli
Signed-off-by: motilayo <joshuaagboola@live.ca >
* fix parser.go - nil check for ref.Client
Signed-off-by: motilayo <joshuaagboola@live.ca >
* Unit test for GetGitSSHPublicKey
Signed-off-by: motilayo <joshuaagboola@live.ca >
* improve test coverage
Signed-off-by: motilayo <joshuaagboola@live.ca >
* make reviewable
Signed-off-by: motilayo <joshuaagboola@live.ca >
* minor improvements & cleanup
Signed-off-by: motilayo <joshuaagboola@live.ca >
* update secret name in test
Signed-off-by: motilayo <joshuaagboola@live.ca >
Signed-off-by: motilayo <44736801+motilayo@users.noreply.github.com >
Signed-off-by: motilayo <joshuaagboola@live.ca >
2022-12-23 16:27:27 +08:00
qiaozp
4ad8a13b5e
Feat: support data-passing in deploy step ( #5161 )
...
* Feat: support component data-passing in deploy step
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* health check with input
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* add union test for io and replication
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* format
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* format
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* use pkg/slices.parMap
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* reduce the GET request
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* reviewable
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
* fix break test
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com >
2022-12-23 14:50:28 +08:00