34e018d16c
Fix: mock OSS registry server serves file bytes directly instead of through html/template ( #7297 )
...
* Fix: mock OSS registry server serves file bytes directly instead of through html/template
ossHandler parsed static file content as a Go template before serving
it, with no placeholders actually used anywhere. On a parse failure
the error branch didn't stop execution and fell through to the
success render right after. Turns out worse than that: Parse returns
a nil *Template on failure, so Execute on it panics.
Drops the templating, writes bytes directly. Added tests, including
a fixture that reproduces the parse failure; confirmed it panics on
the old code and passes with the fix.
Fixes #7296
Signed-off-by: sakirr05 <sakirahmed75531@gmail.com >
* Chore: retrigger CI
Signed-off-by: sakirr05 <sakirahmed75531@gmail.com >
---------
Signed-off-by: sakirr05 <sakirahmed75531@gmail.com >
Co-authored-by: sakirr05 <sakirahmed75531@gmail.com >
2026-08-12 11:32:08 +01:00
ad9cda63c9
Chore: update helm repo path in tests ( #6797 )
...
* chore: fixes the breaking tests with older helm chart address
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Co-authored-by: Amit Singh <singhamitch@outlook.com >
Co-authored-by: Vaibhav Agrawal <vaibhav.agrawal0096@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
* tests: update the registery url
Signed-off-by: semmet95 <singhamitch@outlook.com >
* updates the default url
Signed-off-by: semmet95 <singhamitch@outlook.com >
* test: reverts the changes
Signed-off-by: semmet95 <singhamitch@outlook.com >
* fix: sets github repo directory as the default definition registry
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
* chore: reverts the default definition registry url
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* test: overwrites custom definition registry url
Signed-off-by: Amit Singh <singhamitch@outlook.com >
* debugging test failure
Signed-off-by: Amit Singh <singhamitch@outlook.com >
---------
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com >
Signed-off-by: semmet95 <singhamitch@outlook.com >
Signed-off-by: Amit Singh <singhamitch@outlook.com >
Co-authored-by: Amit Singh <singhamitch@outlook.com >
Co-authored-by: Vaibhav Agrawal <vaibhav.agrawal0096@gmail.com >
2025-06-13 07:13:25 -07:00
Tianxin Dong and GitHub
82dad1ebbb
Chore: update go version to 1.22 ( #6560 )
...
* chore: update go version to 1.22
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix lint
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix unit test
Signed-off-by: FogDong <fog@bentoml.com >
* fix: update static check tool
Signed-off-by: FogDong <fog@bentoml.com >
* fix: add debug
Signed-off-by: FogDong <fog@bentoml.com >
* fix: use ghcr to fix dockerhub rate limit
Signed-off-by: FogDong <fog@bentoml.com >
* fix: use ghcr for addons
Signed-off-by: FogDong <fog@bentoml.com >
* fix: add more timeout for e2e multicluster test
Signed-off-by: FogDong <fog@bentoml.com >
* fix: use ghcr
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix e2e addon image
Signed-off-by: FogDong <fog@bentoml.com >
* fix: test addon terraform version
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix admission image
Signed-off-by: FogDong <fog@bentoml.com >
* fix: fix terraform version
Signed-off-by: FogDong <fog@bentoml.com >
---------
Signed-off-by: FogDong <fog@bentoml.com >
2024-07-03 16:10:56 +08:00
zhaohuiweixiao and GitHub
189555ba16
Refactor: addon dependency installation logic ( #6045 )
...
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
2023-06-15 11:20:50 +08:00
Somefive and GitHub
f15eba2c5f
Chore: remove legacy rollout and scope ( #6068 )
...
* Chore: remove legacy rollout & scope
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* remove outdated params
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* fix
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-06-05 10:57:38 +08:00
Somefive and GitHub
dd899c2b39
Chore: remove outdated apis(v1alppha2 ApplicationConfiguration Component, and HealthScope, Rollout) ( #6041 )
...
* remove outdated api
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* fix rt test: no component rt
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
* recover context.revision to component hash
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
---------
Signed-off-by: Somefive <yd219913@alibaba-inc.com >
2023-06-01 09:32:49 +08:00
zhaohuiweixiao and GitHub
98deab08f5
Fix: install dependency is invalid for runtime addon when it's cluster arg is nil ( #5865 )
...
* Fix: install dependency is invalid for runtime addon when it's clusters arg is nil
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
* Fix: add unit test for getDependencyArgs and checkDependencyNeedInstall
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
* Fix: Simplified the checkDependencyNeedInstall func logic
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
* Fix: add comments for checkDependencyNeedInstall
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
---------
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
2023-04-28 10:16:33 +08:00
zhaohuiweixiao and GitHub
76dc154e92
Refactor: the addon dependency installation logic is accurate to the cluster ( #5206 )
...
* Refactor: the addon dependency installation logic is accurate to the cluster
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
* Fix: optimize the code based on the review
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
* Feat: add unit test for func checkDependencyNeedInstall
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
---------
Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com >
2023-04-07 17:15:44 +08:00
wyike and GitHub
277d94f447
Fix: bug when addon dependent an addon in other registry ( #5083 )
...
* fix several bugs of addon
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix golint error
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix error and add tests
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix comments and fix apiserver test
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix typo
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix tests
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* small fix
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* small fix
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* add parameter in apiserver and test
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
2022-11-24 09:42:28 +08:00
wyike and GitHub
560dad3873
more error info for apiservice and add tests ( #4927 )
...
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
change the mock addon version
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
2022-10-28 17:35:46 +08:00
wyike and GitHub
258d816184
Feat: Check def binding to a component ( #4531 )
...
* finish logic
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* finish tests
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
small fix
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
fix ci
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix comments
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
fix ci
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix test
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
* fix tests
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
2022-08-02 21:36:58 +08:00
b77cdaf5f5
Fix(cli): avoid incorrect addon name when using dot as local addon path ( #4126 )
...
* Fix(cli): avoid issues when using dot as local addon path
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Test(cli): add tests for `vela addon enable .`
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Test(cli): use sample addon to test
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Test(cli): fix typos in tests accordingly
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Test(cli): correct file path
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Test(cli): do not focus single test
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Test(cli): fix typos in tests accordingly
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
* Refactor: correct error output
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com >
Co-authored-by: Zheng Xi Zhou <zzxwill@gmail.com >
Co-authored-by: Zheng Xi Zhou <zzxwill@gmail.com >
2022-06-09 10:12:19 +08:00
wyike and GitHub
28e2284284
mock an addon to fix flaky test ( #3665 )
...
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com >
2022-04-15 10:30:05 +08:00
barnettZQG and GitHub
3d0b9b7c71
Feat: rollout controller is disabled by default ( #3250 )
...
* Feat: rollout controller is disabled by default
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Feat: change rollout image pull policy
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Fix: remove controller from the rollout addon in testdata
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Feat: rollout controller is disabled by default
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
* Fix: extended waiting time for the addon mock server
Signed-off-by: barnettZQG <barnett.zqg@gmail.com >
2022-02-16 14:25:04 +08:00
qiaozp and GitHub
0fc65eb787
Feat: add mock server ( #2911 )
...
* add mock server
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* use mock server
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* reviewable
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* reviewable
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* fix test
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* complate terraform-alibaba addon
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* move to test dir
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* fix test
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* complete terraform
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* fix test
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* add back oss
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* fix test
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
* remove useless readme
Signed-off-by: qiaozp <chivalry.pp@gmail.com >
2021-12-14 14:52:10 +08:00