From fd70aa96e9d89e32affb9ab5b82be470b054897b Mon Sep 17 00:00:00 2001 From: Somefive Date: Thu, 7 Jul 2022 15:32:46 +0800 Subject: [PATCH] Fix: disable apprev status update when apprev disabled (#4337) Signed-off-by: Somefive --- pkg/controller/core.oam.dev/v1alpha2/application/revision.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/core.oam.dev/v1alpha2/application/revision.go b/pkg/controller/core.oam.dev/v1alpha2/application/revision.go index 03617b7a3..6e3438560 100644 --- a/pkg/controller/core.oam.dev/v1alpha2/application/revision.go +++ b/pkg/controller/core.oam.dev/v1alpha2/application/revision.go @@ -1004,7 +1004,7 @@ func (h historiesByComponentRevision) Less(i, j int) bool { // UpdateApplicationRevisionStatus update application revision status func (h *AppHandler) UpdateApplicationRevisionStatus(ctx context.Context, appRev *v1beta1.ApplicationRevision, succeed bool, wfStatus *common.WorkflowStatus) { - if appRev == nil { + if appRev == nil || DisableAllApplicationRevision { return } appRev.Status.Succeeded = succeed