From ec5159c2ca159c03d48edfc51be1ead53016b63f Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 7 Jul 2022 15:51:35 +0800 Subject: [PATCH] Fix: disable apprev status update when apprev disabled (#4338) Signed-off-by: Somefive (cherry picked from commit b4c8e3265a66faf98a333429a1f6a349575b73bc) Co-authored-by: Somefive --- pkg/controller/core.oam.dev/v1alpha2/application/revision.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/core.oam.dev/v1alpha2/application/revision.go b/pkg/controller/core.oam.dev/v1alpha2/application/revision.go index a190632d2..c1528e4af 100644 --- a/pkg/controller/core.oam.dev/v1alpha2/application/revision.go +++ b/pkg/controller/core.oam.dev/v1alpha2/application/revision.go @@ -967,7 +967,7 @@ func (h historiesByComponentRevision) Less(i, j int) bool { // UpdateApplicationRevisionStatus update application revision status func (h *AppHandler) UpdateApplicationRevisionStatus(ctx context.Context, appRev *v1beta1.ApplicationRevision, succeed bool, wfStatus *common.WorkflowStatus) { - if appRev == nil { + if appRev == nil || DisableAllApplicationRevision { return } appRev.Status.Succeeded = succeed