From dd22f27e3954e583ed128b89749c39b6ebcb2546 Mon Sep 17 00:00:00 2001
From: Somefive <yd219913@alibaba-inc.com>
Date: Mon, 19 Sep 2022 11:17:24 +0800
Subject: [PATCH] Fix: panic when properties empty (#4745)

Signed-off-by: Somefive <yd219913@alibaba-inc.com>

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
---
 pkg/workflow/step/generator.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pkg/workflow/step/generator.go b/pkg/workflow/step/generator.go
index 9d5107ce6..3ad5300e5 100644
--- a/pkg/workflow/step/generator.go
+++ b/pkg/workflow/step/generator.go
@@ -193,7 +193,9 @@ func (g *DeployPreApproveWorkflowStepGenerator) Generate(app *v1beta1.Applicatio
 	for _, step := range existingSteps {
 		if step.Type == "deploy" && !lastSuspend {
 			props := DeployWorkflowStepSpec{}
-			_ = utils.StrictUnmarshal(step.Properties.Raw, &props)
+			if step.Properties != nil {
+				_ = utils.StrictUnmarshal(step.Properties.Raw, &props)
+			}
 			if props.Auto != nil && !*props.Auto {
 				steps = append(steps, workflowv1alpha1.WorkflowStep{
 					WorkflowStepBase: workflowv1alpha1.WorkflowStepBase{