From d466897e5a2665ea0f06e8009918fd0124cf0f6a Mon Sep 17 00:00:00 2001 From: Charlie Chiang Date: Tue, 26 Jul 2022 21:15:57 +0800 Subject: [PATCH] Feat: show warnings about addon rendering logic Signed-off-by: Charlie Chiang --- pkg/addon/render.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pkg/addon/render.go b/pkg/addon/render.go index 227617907..c3a7a62c7 100644 --- a/pkg/addon/render.go +++ b/pkg/addon/render.go @@ -28,6 +28,7 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime" + "k8s.io/klog/v2" "sigs.k8s.io/controller-runtime/pkg/client" common2 "github.com/oam-dev/kubevela/apis/core.oam.dev/common" @@ -189,9 +190,17 @@ func generateAppFramework(addon *InstallPackage, parameters map[string]interface } } + if app.Name != "" && app.Name != addonutil.Addon2AppName(addon.Name) { + klog.Warningf("Application name %s will be overwritten with %s. Consider removing app name in template.", app.Name, addonutil.Addon2AppName(addon.Name)) + } app.Name = addonutil.Addon2AppName(addon.Name) - // force override the namespace defined vela with DefaultVelaNS,this value can be modified by Env + + if app.Namespace != "" && app.Namespace != types.DefaultKubeVelaNS { + klog.Warningf("Namespace %s will be overwritten with %s. Consider removing namespace in template.", app.Namespace, types.DefaultKubeVelaNS) + } + // force override the namespace defined vela with DefaultVelaNS. this value can be modified by Env app.SetNamespace(types.DefaultKubeVelaNS) + if app.Labels == nil { app.Labels = make(map[string]string) } @@ -345,6 +354,7 @@ func checkNeedAttachTopologyPolicy(app *v1beta1.Application, addon *InstallPacka } for _, policy := range app.Spec.Policies { if policy.Type == v1alpha1.TopologyPolicyType { + klog.Warningf("deployTo in metadata will NOT have any effect. It conflicts with %s policy named %s. Consider removing deployTo field in addon metadata.", v1alpha1.TopologyPolicyType, policy.Name) return false } }