diff --git a/e2e/application/application_test.go b/e2e/application/application_test.go index a39ace586..46adcc8c6 100644 --- a/e2e/application/application_test.go +++ b/e2e/application/application_test.go @@ -128,6 +128,15 @@ var ApplicationExecContext = func(context string, appName string) bool { var ApplicationPortForwardContext = func(context string, appName string) bool { return ginkgo.It(context+": should get output of port-forward successfully", func() { + ginkgo.By(fmt.Sprintf("waiting for the application [%s] to reach the desired status", appName)) + gomega.Eventually(func() string { + cli := fmt.Sprintf("vela status %s", appName) + output, err := e2e.Exec(cli) + gomega.Expect(err).NotTo(gomega.HaveOccurred()) + return output + }, 90*time.Second, 1*time.Second).Should(gomega.ContainSubstring("running")) + + ginkgo.By("executing port-forward") cli := fmt.Sprintf("vela port-forward %s 8080:80 ", appName) output, err := e2e.ExecAndTerminate(cli) gomega.Expect(err).NotTo(gomega.HaveOccurred()) diff --git a/pkg/appfile/parser.go b/pkg/appfile/parser.go index 3eb059296..4cf940249 100644 --- a/pkg/appfile/parser.go +++ b/pkg/appfile/parser.go @@ -104,7 +104,7 @@ func (p *Parser) GenerateAppFileFromApp(ctx context.Context, app *v1beta1.Applic for idx := range app.Spec.Policies { if app.Spec.Policies[idx].Name == "" { - app.Spec.Policies[idx].Name = fmt.Sprintf("%s:auto-gen:%d", app.Spec.Policies[idx].Type, idx) + app.Spec.Policies[idx].Name = fmt.Sprintf("%s-auto-gen-%d", app.Spec.Policies[idx].Type, idx) } }