From 82dad1ebbbfbfb2a28fe22d21977e2977419a1a5 Mon Sep 17 00:00:00 2001 From: Tianxin Dong Date: Wed, 3 Jul 2024 16:10:56 +0800 Subject: [PATCH] Chore: update go version to 1.22 (#6560) * chore: update go version to 1.22 Signed-off-by: FogDong * fix: fix lint Signed-off-by: FogDong * fix: fix unit test Signed-off-by: FogDong * fix: update static check tool Signed-off-by: FogDong * fix: add debug Signed-off-by: FogDong * fix: use ghcr to fix dockerhub rate limit Signed-off-by: FogDong * fix: use ghcr for addons Signed-off-by: FogDong * fix: add more timeout for e2e multicluster test Signed-off-by: FogDong * fix: use ghcr Signed-off-by: FogDong * fix: fix e2e addon image Signed-off-by: FogDong * fix: test addon terraform version Signed-off-by: FogDong * fix: fix admission image Signed-off-by: FogDong * fix: fix terraform version Signed-off-by: FogDong --------- Signed-off-by: FogDong --- .github/workflows/core-api-test.yml | 4 +-- .github/workflows/definition-lint.yml | 2 +- .github/workflows/e2e-multicluster-test.yml | 2 +- .github/workflows/e2e-test.yml | 2 +- .github/workflows/go.yml | 4 +-- .github/workflows/release.yml | 2 +- .github/workflows/sdk-test.yml | 4 +-- .github/workflows/sync-api.yml | 2 +- .github/workflows/sync-sdk.yaml | 2 +- .github/workflows/unit-test.yml | 2 +- Dockerfile | 2 +- Dockerfile.cli | 2 +- Dockerfile.e2e | 2 +- cmd/core/app/server.go | 5 +-- cmd/plugin/main.go | 4 --- .../resources/deployment/helm-controller.yaml | 2 +- .../deployment/kustomize-controller.yaml | 2 +- .../deployment/source-controller.yaml | 2 +- .../mock/testdata/terraform/template.yaml | 5 ++- go.mod | 2 +- go.sum | 32 +++++++++++++++++++ makefiles/dependency.mk | 4 +-- makefiles/e2e.mk | 12 +++++-- pkg/addon/addon.go | 5 +-- pkg/addon/helper.go | 5 +-- pkg/addon/registry.go | 20 +++--------- .../v1beta1/application/revision.go | 9 ++++-- .../componentdefinition_controller.go | 5 +-- .../policydefinition_controller.go | 5 +-- .../traitdefinition_controller.go | 5 +-- .../workflowstepdefinition_controller.go | 5 +-- pkg/definition/gen_sdk/gen_sdk.go | 1 + pkg/definition/gen_sdk/gen_sdk_test.go | 5 +-- pkg/resourcekeeper/dispatch.go | 5 +-- pkg/utils/common/common.go | 5 +-- pkg/utils/env/env.go | 5 +-- pkg/utils/system/system.go | 5 +-- pkg/webhook/utils/utils.go | 5 +-- pkg/workflow/operation/operation.go | 17 +++------- pkg/workflow/providers/oam/apply.go | 5 +-- references/cli/addon-registry.go | 15 ++------- references/cli/addon.go | 5 +-- references/cli/debug.go | 10 ++---- references/cli/exec.go | 5 +-- references/cli/logs.go | 5 +-- references/cli/portforward.go | 5 +-- references/cli/registry.go | 5 +-- references/cli/show.go | 5 +-- references/cli/top/model/namespace.go | 1 + references/cli/top/view/app.go | 5 +-- references/cli/workflow.go | 1 + references/cmd/cli/main.go | 3 -- references/common/application.go | 5 +-- .../multicluster_standalone_test.go | 2 +- 54 files changed, 114 insertions(+), 172 deletions(-) diff --git a/.github/workflows/core-api-test.yml b/.github/workflows/core-api-test.yml index f77b34896..5f6371a69 100644 --- a/.github/workflows/core-api-test.yml +++ b/.github/workflows/core-api-test.yml @@ -16,10 +16,10 @@ jobs: core-api-test: runs-on: ubuntu-22.04 steps: - - name: Set up Go 1.19 + - name: Set up Go 1.22 uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 env: - GO_VERSION: '1.19' + GO_VERSION: '1.22' with: go-version: ${{ env.GO_VERSION }} id: go diff --git a/.github/workflows/definition-lint.yml b/.github/workflows/definition-lint.yml index 951bd5f9d..3616c00c3 100644 --- a/.github/workflows/definition-lint.yml +++ b/.github/workflows/definition-lint.yml @@ -16,7 +16,7 @@ permissions: env: # Common versions - GO_VERSION: '1.19' + GO_VERSION: '1.22' jobs: definition-doc: diff --git a/.github/workflows/e2e-multicluster-test.yml b/.github/workflows/e2e-multicluster-test.yml index 5fd8d9a7f..0df92729a 100644 --- a/.github/workflows/e2e-multicluster-test.yml +++ b/.github/workflows/e2e-multicluster-test.yml @@ -18,7 +18,7 @@ permissions: env: # Common versions - GO_VERSION: '1.19' + GO_VERSION: '1.22' jobs: diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index 5aaf34be2..e3e96aba4 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -18,7 +18,7 @@ permissions: env: # Common versions - GO_VERSION: '1.19' + GO_VERSION: '1.22' jobs: diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 8e1f27ee8..f9bc86d5b 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -16,8 +16,8 @@ permissions: # added using https://github.com/step-security/secure-workflows env: # Common versions - GO_VERSION: '1.19' - GOLANGCI_VERSION: 'v1.49' + GO_VERSION: '1.22' + GOLANGCI_VERSION: 'v1.54.2' jobs: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9552be587..d2bd55a50 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -31,7 +31,7 @@ jobs: - name: Set up Go uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 with: - go-version: 1.19 + go-version: 1.22 cache: true - uses: goreleaser/goreleaser-action@7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8 # v5.0.0 with: diff --git a/.github/workflows/sdk-test.yml b/.github/workflows/sdk-test.yml index f47f1a112..8c89f303c 100644 --- a/.github/workflows/sdk-test.yml +++ b/.github/workflows/sdk-test.yml @@ -18,8 +18,8 @@ permissions: env: # Common versions - GO_VERSION: '1.19' - GOLANGCI_VERSION: 'v1.49' + GO_VERSION: '1.22' + GOLANGCI_VERSION: 'v1.54.2' jobs: sdk-tests: diff --git a/.github/workflows/sync-api.yml b/.github/workflows/sync-api.yml index c73c1e872..7a86f8512 100644 --- a/.github/workflows/sync-api.yml +++ b/.github/workflows/sync-api.yml @@ -11,7 +11,7 @@ permissions: contents: read env: - GO_VERSION: '1.19' + GO_VERSION: '1.22' jobs: sync-core-api: diff --git a/.github/workflows/sync-sdk.yaml b/.github/workflows/sync-sdk.yaml index 1a5a484c9..1afe8151c 100644 --- a/.github/workflows/sync-sdk.yaml +++ b/.github/workflows/sync-sdk.yaml @@ -15,7 +15,7 @@ permissions: contents: read env: - GO_VERSION: '1.19' + GO_VERSION: '1.22' jobs: sync_sdk: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index ff2cc3ea3..5c5c7db77 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -16,7 +16,7 @@ permissions: env: # Common versions - GO_VERSION: '1.19' + GO_VERSION: '1.22' jobs: diff --git a/Dockerfile b/Dockerfile index 418f1b708..af89b1a4b 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,6 +1,6 @@ ARG BASE_IMAGE # Build the manager binary -FROM golang:1.19-alpine3.18 as builder +FROM golang:1.22-alpine3.18 as builder WORKDIR /workspace # Copy the Go Modules manifests diff --git a/Dockerfile.cli b/Dockerfile.cli index 33b738c0d..0c5929ceb 100644 --- a/Dockerfile.cli +++ b/Dockerfile.cli @@ -1,6 +1,6 @@ ARG BASE_IMAGE # Build the cli binary -FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.19-alpine@sha256:2381c1e5f8350a901597d633b2e517775eeac7a6682be39225a93b22cfd0f8bb as builder +FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22-alpine@sha256:d1a601b64de09e2fa38c95e55838961811d5ca11062a8f4230a5c434b3ae2a34 as builder ARG GOPROXY ENV GOPROXY=${GOPROXY:-https://proxy.golang.org} WORKDIR /workspace diff --git a/Dockerfile.e2e b/Dockerfile.e2e index 7822fa14c..65d1682f5 100644 --- a/Dockerfile.e2e +++ b/Dockerfile.e2e @@ -1,6 +1,6 @@ ARG BASE_IMAGE # Build the manager binary -FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.19-alpine@sha256:2381c1e5f8350a901597d633b2e517775eeac7a6682be39225a93b22cfd0f8bb as builder +FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22-alpine@sha256:d1a601b64de09e2fa38c95e55838961811d5ca11062a8f4230a5c434b3ae2a34 as builder WORKDIR /workspace # Copy the Go Modules manifests diff --git a/cmd/core/app/server.go b/cmd/core/app/server.go index 98d6c0095..566ade772 100644 --- a/cmd/core/app/server.go +++ b/cmd/core/app/server.go @@ -258,10 +258,7 @@ func registerHealthChecks(mgr ctrl.Manager) error { return err } // TODO: change the health check to be different from readiness check - if err := mgr.AddHealthzCheck("ping", healthz.Ping); err != nil { - return err - } - return nil + return mgr.AddHealthzCheck("ping", healthz.Ping) } // waitWebhookSecretVolume waits for webhook secret ready to avoid mgr running crash diff --git a/cmd/plugin/main.go b/cmd/plugin/main.go index f0374f43c..a61a8d507 100644 --- a/cmd/plugin/main.go +++ b/cmd/plugin/main.go @@ -17,16 +17,12 @@ package main import ( - "math/rand" "os" - "time" "github.com/oam-dev/kubevela/references/cli" ) func main() { - rand.Seed(time.Now().UnixNano()) - command := cli.NewCommand() if err := command.Execute(); err != nil { diff --git a/e2e/addon/mock/testdata/fluxcd/resources/deployment/helm-controller.yaml b/e2e/addon/mock/testdata/fluxcd/resources/deployment/helm-controller.yaml index 95bceb005..1e7bcc1d1 100644 --- a/e2e/addon/mock/testdata/fluxcd/resources/deployment/helm-controller.yaml +++ b/e2e/addon/mock/testdata/fluxcd/resources/deployment/helm-controller.yaml @@ -31,7 +31,7 @@ spec: valueFrom: fieldRef: fieldPath: metadata.namespace - image: fluxcd/helm-controller:v0.11.1 + image: ghcr.io/fluxcd/helm-controller:v0.11.1 imagePullPolicy: IfNotPresent livenessProbe: httpGet: diff --git a/e2e/addon/mock/testdata/fluxcd/resources/deployment/kustomize-controller.yaml b/e2e/addon/mock/testdata/fluxcd/resources/deployment/kustomize-controller.yaml index b84e14323..618128209 100644 --- a/e2e/addon/mock/testdata/fluxcd/resources/deployment/kustomize-controller.yaml +++ b/e2e/addon/mock/testdata/fluxcd/resources/deployment/kustomize-controller.yaml @@ -31,7 +31,7 @@ spec: valueFrom: fieldRef: fieldPath: metadata.namespace - image: fluxcd/kustomize-controller:v0.13.1 + image: ghcr.io/fluxcd/kustomize-controller:v0.13.1 imagePullPolicy: IfNotPresent livenessProbe: httpGet: diff --git a/e2e/addon/mock/testdata/fluxcd/resources/deployment/source-controller.yaml b/e2e/addon/mock/testdata/fluxcd/resources/deployment/source-controller.yaml index 290fd053f..a5d1a8822 100644 --- a/e2e/addon/mock/testdata/fluxcd/resources/deployment/source-controller.yaml +++ b/e2e/addon/mock/testdata/fluxcd/resources/deployment/source-controller.yaml @@ -35,7 +35,7 @@ spec: valueFrom: fieldRef: fieldPath: metadata.namespace - image: fluxcd/source-controller:v0.15.3 + image: ghcr.io/fluxcd/source-controller:v0.15.3 imagePullPolicy: IfNotPresent livenessProbe: httpGet: diff --git a/e2e/addon/mock/testdata/terraform/template.yaml b/e2e/addon/mock/testdata/terraform/template.yaml index 8ebfdc171..3ff244664 100644 --- a/e2e/addon/mock/testdata/terraform/template.yaml +++ b/e2e/addon/mock/testdata/terraform/template.yaml @@ -27,4 +27,7 @@ spec: url: https://charts.kubevela.net/addons chart: terraform-controller version: 0.2.11 - + values: + image: + repository: ghcr.io/kubevela/oamdev/terraform-controller + tag: v0.8.0 diff --git a/go.mod b/go.mod index cce333abd..1688601e2 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/oam-dev/kubevela -go 1.19 +go 1.22 require ( cuelang.org/go v0.5.0 diff --git a/go.sum b/go.sum index 368773364..49b1f792a 100644 --- a/go.sum +++ b/go.sum @@ -2,7 +2,9 @@ cloud.google.com/go v0.100.2 h1:t9Iw5QH5v4XtlEQaCtUY7x6sCABps8sW0acw7e2WQ6Y= cloud.google.com/go v0.100.2/go.mod h1:4Xra9TjzAeYHrl5+oeLlzbM2k3mjVhZh4UqTZ//w99A= cloud.google.com/go/compute v0.1.0/go.mod h1:GAesmwr110a34z04OlxYkATPBEfVhkymfTBXtfbBFow= cloud.google.com/go/compute v1.20.1 h1:6aKEtlUiwEpJzM001l0yFkpXmUVXaN8W+fbkb2AZNbg= +cloud.google.com/go/compute v1.20.1/go.mod h1:4tCnrn48xsqlwSAiLf1HXMQk8CONslYbdiEZc9FEIbM= cloud.google.com/go/compute/metadata v0.2.3 h1:mg4jlk7mCAj6xXp9UJ4fjI9VUI5rubuGBW5aJ7UnBMY= +cloud.google.com/go/compute/metadata v0.2.3/go.mod h1:VAV5nSsACxMJvgaAuX6Pk2AawlZn8kiOGuCv6gTkwuA= cloud.google.com/go/firestore v1.1.0/go.mod h1:ulACoGHTpvq5r8rxGJ4ddJZBZqakUQqClKRT5SZwBmk= cloud.google.com/go/storage v1.0.0/go.mod h1:IhtSnM/ZTZV8YYJWCY8RULGVqBDmpoyjwiyrjsg+URw= cuelang.org/go v0.5.0 h1:D6N0UgTGJCOxFKU8RU+qYvavKNsVc/+ZobmifStVJzU= @@ -30,6 +32,7 @@ github.com/BurntSushi/toml v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak github.com/BurntSushi/toml v1.2.1/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ= github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo= github.com/DATA-DOG/go-sqlmock v1.5.0 h1:Shsta01QNfFxHCfpW6YH2STWB0MudeXXEWMr20OEh60= +github.com/DATA-DOG/go-sqlmock v1.5.0/go.mod h1:f/Ixk793poVmq4qj/V1dPUg2JEAKC73Q5eFN3EC/SaM= github.com/FogDong/uitable v0.0.5 h1:1bJo/uvhGUC6i8JPHZCr8XKMHiDExE7mQkOCmDl0ryQ= github.com/FogDong/uitable v0.0.5/go.mod h1:1yEaP13SkkBUj3HvqKIUWnsb42XigyZbNle84mc5kLM= github.com/MakeNowJust/heredoc v1.0.0 h1:cXCdzVdstXyiTqTvfqk9SDHpKNjxuom+DOlyEeQ4pzQ= @@ -53,6 +56,7 @@ github.com/Microsoft/go-winio v0.5.2/go.mod h1:WpS1mjBmmwHBEWmogvA2mj8546UReBk4v github.com/Microsoft/go-winio v0.6.1 h1:9/kr64B9VUZrLm5YYwbGtUJnMgqWVOdUAXu6Migciow= github.com/Microsoft/go-winio v0.6.1/go.mod h1:LRdKpFKfdobln8UmuiYcKPot9D2v6svN5+sAH+4kjUM= github.com/Microsoft/hcsshim v0.10.0-rc.8 h1:YSZVvlIIDD1UxQpJp0h+dnpLUw+TrY0cx8obKsp3bek= +github.com/Microsoft/hcsshim v0.10.0-rc.8/go.mod h1:OEthFdQv/AD2RAdzR6Mm1N1KPCztGKDurW1Z8b8VGMM= github.com/NYTimes/gziphandler v0.0.0-20170623195520-56545f4a5d46/go.mod h1:3wb06e3pkSAbeQ52E9H9iFoQsEEwGN64994WTCIhntQ= github.com/NYTimes/gziphandler v1.1.1 h1:ZUDjpQae29j0ryrS0u/B8HZfJBtBQHjqw2rQ2cqUQ3I= github.com/NYTimes/gziphandler v1.1.1/go.mod h1:n/CVRwUEOgIxrgPvAQhUUr9oeUtvrhMomdKFjzJNB0c= @@ -64,6 +68,7 @@ github.com/ProtonMail/go-crypto v0.0.0-20230717121422-5aa5874ade95/go.mod h1:EjA github.com/PuerkitoBio/purell v1.1.1/go.mod h1:c11w/QuzBsJSee3cPx9rAFu61PvFxuPbtSwDGJws/X0= github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578/go.mod h1:uGdkoq3SwY9Y+13GIhn11/XLaGBb4BfwItxLd5jeuXE= github.com/Shopify/logrus-bugsnag v0.0.0-20171204204709-577dee27f20d h1:UrqY+r/OJnIp5u0s1SbQ8dVfLCZJsnvazdBP5hS4iRs= +github.com/Shopify/logrus-bugsnag v0.0.0-20171204204709-577dee27f20d/go.mod h1:HI8ITrYtUY+O+ZhtlqUnD8+KwNPOyugEhfP9fdUIaEQ= github.com/a8m/expect v1.0.0/go.mod h1:4IwSCMumY49ScypDnjNbYEjgVeqy1/U2cEs3Lat96eA= github.com/acomagu/bufpipe v1.0.4 h1:e3H4WUzM3npvo5uv95QuJM3cQspFNtFBzvJ2oNjKIDQ= github.com/acomagu/bufpipe v1.0.4/go.mod h1:mxdxdup/WdsKVreO5GpW4+M/1CE2sMG4jeGJ2sYmHc4= @@ -72,6 +77,7 @@ github.com/agext/levenshtein v1.2.2/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki github.com/agext/levenshtein v1.2.3 h1:YB2fHEn0UJagG8T1rrWknE3ZQzWM06O8AMAatNn7lmo= github.com/agext/levenshtein v1.2.3/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558= github.com/agiledragon/gomonkey/v2 v2.9.0 h1:PDiKKybR596O6FHW+RVSG0Z7uGCBNbmbUXh3uCNQ7Hc= +github.com/agiledragon/gomonkey/v2 v2.9.0/go.mod h1:ap1AmDzcVOAz1YpeJ3TCzIgstoaWLA6jbbgxfB4w2iY= github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc= github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc= github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0= @@ -82,6 +88,7 @@ github.com/alessio/shellescape v1.4.1/go.mod h1:PZAiSCk0LJaZkiCSkPv8qIobYglO3FPp github.com/aliyun/alibaba-cloud-sdk-go v1.61.1704 h1:PpfENOj/vPfhhy9N2OFRjpue0hjM5XqAp2thFmkXXIk= github.com/aliyun/alibaba-cloud-sdk-go v1.61.1704/go.mod h1:RcDobYh8k5VP6TNybz9m++gL3ijVI5wueVr0EM10VsU= github.com/anmitsu/go-shlex v0.0.0-20200514113438-38f4b401e2be h1:9AeTilPcZAjCFIImctFaOjnTIavg87rW78vTPkQqLI8= +github.com/anmitsu/go-shlex v0.0.0-20200514113438-38f4b401e2be/go.mod h1:ySMOLuWl6zY27l47sB3qLNK6tF2fkHG55UZxx8oIVo4= github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY= github.com/antlr/antlr4/runtime/Go/antlr v0.0.0-20210826220005-b48c857c3a0e/go.mod h1:F7bn7fEU90QkQ3tnmaTx3LTKLEDqnwWODIYppRQ5hnY= github.com/antlr/antlr4/runtime/Go/antlr v0.0.0-20220418222510-f25a4f6275ed/go.mod h1:F7bn7fEU90QkQ3tnmaTx3LTKLEDqnwWODIYppRQ5hnY= @@ -123,11 +130,15 @@ github.com/bluele/gcache v0.0.2/go.mod h1:m15KV+ECjptwSPxKhOhQoAFQVtUFjTVkc3H8o0 github.com/briandowns/spinner v1.23.0 h1:alDF2guRWqa/FOZZYWjlMIx2L6H0wyewPxo/CH4Pt2A= github.com/briandowns/spinner v1.23.0/go.mod h1:rPG4gmXeN3wQV/TsAY4w8lPdIM6RX3yqeBQJSrbXjuE= github.com/bshuster-repo/logrus-logstash-hook v1.0.0 h1:e+C0SB5R1pu//O4MQ3f9cFuPGoOVeF2fE4Og9otCc70= +github.com/bshuster-repo/logrus-logstash-hook v1.0.0/go.mod h1:zsTqEiSzDgAa/8GZR7E1qaXrhYNDKBYy5/dWPTIflbk= github.com/buger/jsonparser v1.1.1 h1:2PnMjfWD7wBILjqQbt530v576A/cAbQvEW9gGIpYMUs= github.com/buger/jsonparser v1.1.1/go.mod h1:6RYKKt7H4d4+iWqouImQ9R2FZql3VbhNgx27UK13J/0= github.com/bugsnag/bugsnag-go v0.0.0-20141110184014-b1d153021fcd h1:rFt+Y/IK1aEZkEHchZRSq9OQbsSzIT/OrI8YFFmRIng= +github.com/bugsnag/bugsnag-go v0.0.0-20141110184014-b1d153021fcd/go.mod h1:2oa8nejYd4cQ/b0hMIopN0lCRxU0bueqREvZLWFrtK8= github.com/bugsnag/osext v0.0.0-20130617224835-0dd3f918b21b h1:otBG+dV+YK+Soembjv71DPz3uX/V/6MMlSyD9JBQ6kQ= +github.com/bugsnag/osext v0.0.0-20130617224835-0dd3f918b21b/go.mod h1:obH5gd0BsqsP2LwDJ9aOkm/6J86V6lyAXCoQWGw3K50= github.com/bugsnag/panicwrap v0.0.0-20151223152923-e2c28503fcd0 h1:nvj0OLI3YqYXer/kZD8Ri1aaunCxIEsOst1BVJswV0o= +github.com/bugsnag/panicwrap v0.0.0-20151223152923-e2c28503fcd0/go.mod h1:D/8v3kj0zr8ZAKg1AQ6crr+5VwKN5eIywRkfhyM/+dE= github.com/bwesterb/go-ristretto v1.2.3/go.mod h1:fUIoIZaG73pV5biE2Blr2xEzDoMj7NFEuV9ekS419A0= github.com/cenkalti/backoff/v4 v4.1.1/go.mod h1:scbssz8iZGpm3xbr14ovlUdkxfGXNInqkPWOWmG2CLw= github.com/cenkalti/backoff/v4 v4.1.3/go.mod h1:scbssz8iZGpm3xbr14ovlUdkxfGXNInqkPWOWmG2CLw= @@ -166,9 +177,11 @@ github.com/cockroachdb/datadriven v0.0.0-20200714090401-bf6692d28da5/go.mod h1:h github.com/cockroachdb/errors v1.2.4/go.mod h1:rQD95gz6FARkaKkQXUksEje/d9a6wBJoCr5oaCLELYA= github.com/cockroachdb/logtags v0.0.0-20190617123548-eb05cc24525f/go.mod h1:i/u985jwjWRlyHXQbwatDASoW0RMlZ/3i9yJHE2xLkI= github.com/containerd/cgroups v1.1.0 h1:v8rEWFl6EoqHB+swVNjVoCJE8o3jX7e8nqBGPLaDFBM= +github.com/containerd/cgroups v1.1.0/go.mod h1:6ppBcbh/NOOUU+dMKrykgaBnK9lCIBxHqJDGwsa1mIw= github.com/containerd/containerd v1.7.5 h1:i9T9XpAWMe11BHMN7pu1BZqOGjXaKTPyz2v+KYOZgkY= github.com/containerd/containerd v1.7.5/go.mod h1:ieJNCSzASw2shSGYLHx8NAE7WsZ/gEigo5fQ78W5Zvw= github.com/containerd/continuity v0.4.2 h1:v3y/4Yz5jwnvqPKJJ+7Wf93fyWoCB3F5EclWG023MDM= +github.com/containerd/continuity v0.4.2/go.mod h1:F6PTNCKepoxEaXLQp3wDAjygEnImnZ/7o4JzpodfroQ= github.com/containerd/stargz-snapshotter/estargz v0.14.3 h1:OqlDCK3ZVUO6C3B/5FSkDwbkEETK84kQgEeFwDC+62k= github.com/containerd/stargz-snapshotter/estargz v0.14.3/go.mod h1:KY//uOCIkSuNAHhJogcZtrNHdKrA99/FCCRjE3HD36o= github.com/coreos/bbolt v1.3.2/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk= @@ -207,6 +220,7 @@ github.com/denisenkom/go-mssqldb v0.9.0/go.mod h1:xbL0rPBG9cCiLr28tMa8zpbdarY27N github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ= github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no= github.com/distribution/distribution/v3 v3.0.0-20221208165359-362910506bc2 h1:aBfCb7iqHmDEIp6fBvC/hQUddQfg+3qdYjwzaiP9Hnc= +github.com/distribution/distribution/v3 v3.0.0-20221208165359-362910506bc2/go.mod h1:WHNsWjnIn2V1LYOrME7e8KxSeKunYHsxEm4am0BUtcI= github.com/docker/cli v20.10.9+incompatible h1:OJ7YkwQA+k2Oi51lmCojpjiygKpi76P7bg91b2eJxYU= github.com/docker/cli v20.10.9+incompatible/go.mod h1:JLrzqnKDaYBop7H2jaqPtU4hHvMKP+vjCwu2uszcLI8= github.com/docker/distribution v2.8.2+incompatible h1:T3de5rq0dB1j30rp0sA2rER+m322EBzniBPB6ZIzuh8= @@ -216,16 +230,19 @@ github.com/docker/docker-credential-helpers v0.7.0/go.mod h1:rETQfLdHNT3foU5kuNk github.com/docker/go-connections v0.4.0 h1:El9xVISelRB7BuFusrZozjnkIM5YnzCViNKohAFqRJQ= github.com/docker/go-connections v0.4.0/go.mod h1:Gbd7IOopHjR8Iph03tsViu4nIes5XhDvyHbTtUxmeec= github.com/docker/go-events v0.0.0-20190806004212-e31b211e4f1c h1:+pKlWGMw7gf6bQ+oDZB4KHQFypsfjYlq/C4rfL7D3g8= +github.com/docker/go-events v0.0.0-20190806004212-e31b211e4f1c/go.mod h1:Uw6UezgYA44ePAFQYUehOuCzmy5zmg/+nl2ZfMWGkpA= github.com/docker/go-metrics v0.0.1 h1:AgB/0SvBxihN0X8OR4SjsblXkbMvalQ8cjmtKQ2rQV8= github.com/docker/go-metrics v0.0.1/go.mod h1:cG1hvH2utMXtqgqqYE9plW6lDxS3/5ayHzueweSI3Vw= github.com/docker/go-units v0.5.0 h1:69rxXcBk27SvSaaxTtLh/8llcHD8vYHT7WSdRZ/jvr4= github.com/docker/go-units v0.5.0/go.mod h1:fgPhTUdO+D/Jk86RDLlptpiXQzgHJF7gydDDbaIK4Dk= github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7 h1:UhxFibDNY/bfvqU5CAUmr9zpesgbU6SWc8/B4mflAE4= +github.com/docker/libtrust v0.0.0-20160708172513-aabc10ec26b7/go.mod h1:cyGadeNEkKy96OOhEzfZl+yxihPEzKnqJwvfuSUqbZE= github.com/docopt/docopt-go v0.0.0-20180111231733-ee0de3bc6815/go.mod h1:WwZ+bS3ebgob9U8Nd0kOddGdZWjyMGR8Wziv+TBNwSE= github.com/dustin/go-humanize v1.0.0 h1:VSnTsYCnlFHaM2/igO1h6X3HA71jcobQuxemgkq4zYo= github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk= github.com/elazarl/goproxy v0.0.0-20180725130230-947c36da3153/go.mod h1:/Zj4wYkgs4iZTTu3o/KG3Itv/qCCa8VVMlb3i9OVuzc= github.com/elazarl/goproxy v0.0.0-20221015165544-a0805db90819 h1:RIB4cRk+lBqKK3Oy0r2gRX4ui7tuhiZq2SuTtTCi0/0= +github.com/elazarl/goproxy v0.0.0-20221015165544-a0805db90819/go.mod h1:Ro8st/ElPeALwNFlcTpWmkr6IoMFfkjXAvTHpevnDsM= github.com/emicklei/go-restful v0.0.0-20170410110728-ff4f55a20633/go.mod h1:otzb+WCGbkyDHkqmQmT5YD2WR4BBwUdeQoFo8l/7tVs= github.com/emicklei/go-restful v2.9.5+incompatible/go.mod h1:otzb+WCGbkyDHkqmQmT5YD2WR4BBwUdeQoFo8l/7tVs= github.com/emicklei/go-restful/v3 v3.8.0/go.mod h1:6n3XBCmQQb25CM2LCACGz8ukIrRry+4bhvbpWn3mrbc= @@ -301,6 +318,7 @@ github.com/getsentry/raven-go v0.2.0/go.mod h1:KungGk8q33+aIAZUIVWZDr2OfAEBsO49P github.com/ghodss/yaml v1.0.0 h1:wQHKEahhL6wmXdzwWG11gIVCkOv05bNOh+Rxn0yngAk= github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04= github.com/gliderlabs/ssh v0.3.5 h1:OcaySEmAQJgyYcArR+gGGTHCyE7nvhEMTlYY+Dp8CpY= +github.com/gliderlabs/ssh v0.3.5/go.mod h1:8XB4KraRrX39qHhT6yxPsHedjA08I/uBVwj4xC+/+z4= github.com/go-errors/errors v1.0.1 h1:LUHzmkK3GUKUrL/1gfBUxAHzcev3apQlezX/+O7ma6w= github.com/go-errors/errors v1.0.1/go.mod h1:f4zRHt4oKfwPJE5k8C9vpYG+aDHdBFUsgrm6/TyX73Q= github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 h1:+zs/tPmkDkHx3U66DAb0lQFJrpS6731Oaa12ikc+DiI= @@ -308,6 +326,7 @@ github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376/go.mod h1:an3vInlBmS github.com/go-git/go-billy/v5 v5.4.1 h1:Uwp5tDRkPr+l/TnbHOQzp+tmJfLceOlbVucgpTz8ix4= github.com/go-git/go-billy/v5 v5.4.1/go.mod h1:vjbugF6Fz7JIflbVpl1hJsGjSHNltrSw45YK/ukIvQg= github.com/go-git/go-git-fixtures/v4 v4.3.2-0.20230305113008-0c11038e723f h1:Pz0DHeFij3XFhoBRGUDPzSJ+w2UcK5/0JvF8DRI58r8= +github.com/go-git/go-git-fixtures/v4 v4.3.2-0.20230305113008-0c11038e723f/go.mod h1:8LHG1a3SRW71ettAD/jW13h8c6AqjVSeL11RAdgaqpo= github.com/go-git/go-git/v5 v5.8.1 h1:Zo79E4p7TRk0xoRgMq0RShiTHGKcKI4+DI6BfJc/Q+A= github.com/go-git/go-git/v5 v5.8.1/go.mod h1:FHFuoD6yGz5OSKEBK+aWN9Oah0q54Jxl0abmj6GnqAo= github.com/go-gl/glfw v0.0.0-20190409004039-e6da0acd62b1/go.mod h1:vR7hzQXu2zJy9AVAgeJqvqgH9Q5CA+iKCZ2gyEVpxRU= @@ -409,6 +428,7 @@ github.com/golang/protobuf v1.5.3 h1:KhyjKVUg7Usr/dYsdSqoFveMYd5ko72D+zANwlG1mmg github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY= github.com/golang/snappy v0.0.3/go.mod h1:/XxbfmMg8lxefKM7IXC3fBNl/7bRcc72aCRzEWrmP2Q= github.com/gomodule/redigo v1.8.2 h1:H5XSIre1MB5NbPYFp+i1NBbb5qN1W8Y8YAQoAYbkm8k= +github.com/gomodule/redigo v1.8.2/go.mod h1:P9dn9mFrCBvWhGE1wpxx6fgq7BAeLBk+UUUzlpkBYO0= github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ= github.com/google/btree v1.0.0/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ= github.com/google/btree v1.0.1 h1:gK4Kx5IaGY9CD5sPJ36FHiBJ6ZXl0kilRiiCj+jdYp4= @@ -464,6 +484,7 @@ github.com/googleapis/gnostic v0.5.1/go.mod h1:6U4PtQXGIEt/Z3h5MAT7FNofLnw9vXk2c github.com/googleapis/gnostic v0.5.5/go.mod h1:7+EbHbldMins07ALC74bsA81Ovc97DwqyJO1AENw9kA= github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1/go.mod h1:wJfORRmW1u3UXTncJ5qlYoELFm8eSnnEO6hX4iZ3EWY= github.com/gorilla/handlers v1.5.1 h1:9lRY6j8DEeeBT10CvO9hGW0gmky0BprnvDI5vfhUHH4= +github.com/gorilla/handlers v1.5.1/go.mod h1:t8XrUpc4KVXb7HGyJ4/cEnwQiaxrX/hz1Zv/4g96P1Q= github.com/gorilla/mux v1.8.0 h1:i40aqfkR1h2SlN9hojwV5ZA91wcXFOvkdNIeFDP5koI= github.com/gorilla/mux v1.8.0/go.mod h1:DVbg23sWSpFRCP0SfiEN6jmj59UnW/n46BH5rLB71So= github.com/gorilla/websocket v1.4.0/go.mod h1:E7qHFY5m1UJ88s3WnNqhKjPHQ0heANvMoAMk2YaljkQ= @@ -494,6 +515,7 @@ github.com/hashicorp/go-cleanhttp v0.5.2 h1:035FKYIWjmULyFRBKPs8TBQoi0x6d9G4xc9n github.com/hashicorp/go-cleanhttp v0.5.2/go.mod h1:kO/YDlP8L1346E6Sodw+PrpBSV4/SoxCXGY6BqNFT48= github.com/hashicorp/go-hclog v0.9.2/go.mod h1:5CU+agLiy3J7N7QjHK5d05KxGsuXiQLrjA0H7acj2lQ= github.com/hashicorp/go-hclog v0.16.2 h1:K4ev2ib4LdQETX5cSZBG0DVLk1jwGqSPXBjdah3veNs= +github.com/hashicorp/go-hclog v0.16.2/go.mod h1:whpDNt7SSdeAju8AWKIWsul05p54N/39EeqMAyrmvFQ= github.com/hashicorp/go-immutable-radix v1.0.0/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60= github.com/hashicorp/go-msgpack v0.5.3/go.mod h1:ahLV/dePpqEmjfWmKiqvPkv/twdG7iPBM1vqhUKIvfM= github.com/hashicorp/go-multierror v1.0.0/go.mod h1:dHtQlpGsu+cZNNAkkCN/P3hoUDHhCYQXV3UM06sGGrk= @@ -511,6 +533,7 @@ github.com/hashicorp/go.net v0.0.1/go.mod h1:hjKkEWcCURg++eb33jQU7oqQcI9XDCnUzHA github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8= github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8= github.com/hashicorp/golang-lru v0.5.4 h1:YDjusn29QI/Das2iO9M0BHnIbxPeyuCHsjMW+lJfyTc= +github.com/hashicorp/golang-lru v0.5.4/go.mod h1:iADmTwqILo4mZ8BN3D2Q6+9jd8WM5uGBxy+E8yxSoD4= github.com/hashicorp/hcl v0.0.0-20170504190234-a4b07c25de5f/go.mod h1:oZtUIOe8dh44I2q6ScRibXws4Ajl+d+nod3AaR9vL5w= github.com/hashicorp/hcl v1.0.0 h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4= github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ= @@ -702,6 +725,7 @@ github.com/moby/moby v20.10.24+incompatible/go.mod h1:fDXVQ6+S340veQPv35CzDahGBm github.com/moby/spdystream v0.2.0 h1:cjW1zVyyoiM0T7b6UoySUFqzXMoqRckQtXwGPiBhOM8= github.com/moby/spdystream v0.2.0/go.mod h1:f7i0iNDQJ059oMTcWxx8MA/zKFIuD/lY+0GqbN2Wy8c= github.com/moby/sys/mountinfo v0.6.2 h1:BzJjoreD5BMFNmD9Rus6gdd1pLuecOFPt8wC+Vygl78= +github.com/moby/sys/mountinfo v0.6.2/go.mod h1:IJb6JQeOklcdMU9F5xQ8ZALD+CUr5VlGpwtX+VE0rpI= github.com/moby/term v0.0.0-20210610120745-9d4ed1856297/go.mod h1:vgPCkQMyxTZ7IDy8SXRufE172gr8+K/JE/7hHFxHW3A= github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6/go.mod h1:E2VnQOmVuvZB6UYnnDB0qG5Nq/1tD9acaOpo6xmt0Kw= github.com/moby/term v0.0.0-20220808134915-39b0c02b01ae/go.mod h1:E2VnQOmVuvZB6UYnnDB0qG5Nq/1tD9acaOpo6xmt0Kw= @@ -803,6 +827,7 @@ github.com/perimeterx/marshmallow v1.1.4/go.mod h1:dsXbUu8CRzfYP5a87xpp0xq9S3u0V github.com/peterbourgon/diskv v2.0.1+incompatible h1:UBdAOUP5p4RWqPBg048CAvpKN+vxiaj6gdUUzhl4XmI= github.com/peterbourgon/diskv v2.0.1+incompatible/go.mod h1:uqqh8zWWbv1HBMNONnaR/tNboyR3/BZd58JJSHlUSCU= github.com/phayes/freeport v0.0.0-20220201140144-74d24b5ae9f5 h1:Ii+DKncOVM8Cu1Hc+ETb5K+23HdAMvESYE3ZJ5b5cMI= +github.com/phayes/freeport v0.0.0-20220201140144-74d24b5ae9f5/go.mod h1:iIss55rKnNBTvrwdmkUpLnDpZoAHvWaiq5+iMmen4AE= github.com/pjbgf/sha1cd v0.3.0 h1:4D5XXmUUBUl/xQ6IjCkEAbqXskkq/4O7LmGn0AqMDs4= github.com/pjbgf/sha1cd v0.3.0/go.mod h1:nZ1rrWOcGJ5uZgEEVL1VUM9iRQiZvWdbZjkKyFzPPsI= github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA= @@ -821,6 +846,7 @@ github.com/poy/onpar v1.1.2/go.mod h1:6X8FLNoxyr9kkmnlqpK6LSoiOtrO6MICtWwEuWkLjz github.com/pquerna/cachecontrol v0.0.0-20171018203845-0dec1b30a021/go.mod h1:prYjPmNq4d1NPVmpShWobRqXY3q7Vp+80DqgxxUrUIA= github.com/pquerna/cachecontrol v0.1.0/go.mod h1:NrUG3Z7Rdu85UNR3vm7SOsl1nFIeSiQnrHV5K9mBcUI= github.com/prashantv/gostub v1.1.0 h1:BTyx3RfQjRHnUWaGF9oQos79AlQ5k8WNktv7VGvVH4g= +github.com/prashantv/gostub v1.1.0/go.mod h1:A5zLQHz7ieHGG7is6LLXLz7I8+3LZzsrV0P1IAHhP5U= github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw= github.com/prometheus/client_golang v0.9.3/go.mod h1:/TN21ttK/J9q6uSwhBd54HahCDft0ttaMvbicHlPoso= github.com/prometheus/client_golang v1.0.0/go.mod h1:db9x61etRT2tGnBNRi70OPL5FsnadC4Ky3P0J6CfImo= @@ -995,14 +1021,18 @@ github.com/yuin/goldmark v1.4.0/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1 github.com/yuin/goldmark v1.4.1/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k= github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY= github.com/yvasiyarov/go-metrics v0.0.0-20140926110328-57bccd1ccd43 h1:+lm10QQTNSBd8DVTNGHx7o/IKu9HYDvLMffDhbyLccI= +github.com/yvasiyarov/go-metrics v0.0.0-20140926110328-57bccd1ccd43/go.mod h1:aX5oPXxHm3bOH+xeAttToC8pqch2ScQN/JoXYupl6xs= github.com/yvasiyarov/gorelic v0.0.0-20141212073537-a9bba5b9ab50 h1:hlE8//ciYMztlGpl/VA+Zm1AcTPHYkHJPbHqE6WJUXE= +github.com/yvasiyarov/gorelic v0.0.0-20141212073537-a9bba5b9ab50/go.mod h1:NUSPSUX/bi6SeDMUh6brw0nXpxHnc96TguQh0+r/ssA= github.com/yvasiyarov/newrelic_platform_go v0.0.0-20140908184405-b21fdbd4370f h1:ERexzlUfuTvpE74urLSbIQW0Z/6hF9t8U4NsJLaioAY= +github.com/yvasiyarov/newrelic_platform_go v0.0.0-20140908184405-b21fdbd4370f/go.mod h1:GlGEuHIJweS1mbCqG+7vt2nvWLzLLnRHbXz5JKd/Qbg= github.com/zclconf/go-cty v1.1.0/go.mod h1:xnAOWiHeOqg2nWS62VtQ7pbOu17FtxJNW8RLEih+O3s= github.com/zclconf/go-cty v1.13.0 h1:It5dfKTTZHe9aeppbNOda3mN7Ag7sg6QkBNm6TkyFa0= github.com/zclconf/go-cty v1.13.0/go.mod h1:YKQzy/7pZ7iq2jNFzy5go57xdxdWoLLpaEp4u238AE0= go.etcd.io/bbolt v1.3.2/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU= go.etcd.io/bbolt v1.3.6/go.mod h1:qXsaaIqmgQH0T+OPdb99Bf+PKfBBQVAdyD6TY9G8XM4= go.etcd.io/bbolt v1.3.7 h1:j+zJOnnEjF/kyHlDDgGnVL/AIqIJPq8UoB2GSNfkUfQ= +go.etcd.io/bbolt v1.3.7/go.mod h1:N9Mkw9X8x5fupy0IKsmuqVtoGDyxsaDlbk4Rd05IAQw= go.etcd.io/etcd v0.0.0-20200513171258-e048e166ab9c h1:/RwRVN9EdXAVtdHxP7Ndn/tfmM9/goiwU0QTnLBgS4w= go.etcd.io/etcd/api/v3 v3.5.0/go.mod h1:cbVKeC6lCfl7j/8jBhAK6aIYO9XOjdptoxU/nLQcPvs= go.etcd.io/etcd/api/v3 v3.5.5 h1:BX4JIbQ7hl7+jL+g+2j5UAr0o1bctCm6/Ct+ArBGkf0= @@ -1028,6 +1058,7 @@ go.etcd.io/etcd/server/v3 v3.5.5/go.mod h1:rZ95vDw/jrvsbj9XpTqPrTAB9/kzchVdhRiry go.opencensus.io v0.21.0/go.mod h1:mSImk1erAIZhrmZN+AvHh14ztQfjbGwt4TtuofqLduU= go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E= go.opencensus.io v0.24.0 h1:y73uSU6J157QMP2kn2r30vwW1A2W2WFwSCGnAVxeaD0= +go.opencensus.io v0.24.0/go.mod h1:vNK8G9p7aAivkbmorf4v+7Hgx+Zs0yY+0fOtgBfjQKo= go.opentelemetry.io/contrib v0.20.0/go.mod h1:G/EtFaa6qaN7+LxqfIAT3GiZa7Wv5DTBUzl5H4LY0Kc= go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.20.0/go.mod h1:oVGt1LRbBOBq1A5BQLlUg9UaU/54aiHw8cgjV3aWZ/E= go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.25.0/go.mod h1:E5NNboN0UqSAki0Atn9kVwaN7I+l25gGxDqBueo/74E= @@ -1092,6 +1123,7 @@ go.uber.org/goleak v1.1.11/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ go.uber.org/goleak v1.1.12/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/goleak v1.2.0/go.mod h1:XJYK+MuIchqpmGmUSAzotztawfKvYLUIgg7guXrwVUo= go.uber.org/goleak v1.2.1 h1:NBol2c7O1ZokfZ0LEU9K6Whx/KnwvepVetCUhtKja4A= +go.uber.org/goleak v1.2.1/go.mod h1:qlT2yGI9QafXHhZZLxlSuNsMw3FFLxBr+tBRlmO1xH4= go.uber.org/multierr v1.1.0/go.mod h1:wR5kodmAFQ0UK8QlbwjlSNy0Z68gJhDJUG5sjR94q/0= go.uber.org/multierr v1.6.0/go.mod h1:cdWPpRnG4AhwMwsgIHip0KRBQjJy5kYEpYjJxpXp9iU= go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0= diff --git a/makefiles/dependency.mk b/makefiles/dependency.mk index a486714d5..1e7dc1450 100644 --- a/makefiles/dependency.mk +++ b/makefiles/dependency.mk @@ -1,5 +1,5 @@ -GOLANGCILINT_VERSION ?= 1.49.0 +GOLANGCILINT_VERSION ?= 1.54.2 GLOBAL_GOLANGCILINT := $(shell which golangci-lint) GOBIN_GOLANGCILINT:= $(shell which $(GOBIN)/golangci-lint) @@ -27,7 +27,7 @@ ifeq (, $(shell which staticcheck)) @{ \ set -e ;\ echo 'installing honnef.co/go/tools/cmd/staticcheck ' ;\ - go install honnef.co/go/tools/cmd/staticcheck@d7e217c1ff411395475b2971c0824e1e7cc1af98 ;\ + go install honnef.co/go/tools/cmd/staticcheck@v0.4.7 ;\ } STATICCHECK=$(GOBIN)/staticcheck else diff --git a/makefiles/e2e.mk b/makefiles/e2e.mk index c6b2254de..699f9f05c 100644 --- a/makefiles/e2e.mk +++ b/makefiles/e2e.mk @@ -27,7 +27,10 @@ e2e-setup-core-wo-auth: --set applicationRevisionLimit=5 \ --set optimize.disableComponentRevision=false \ --set image.tag=$(GIT_COMMIT) \ - --wait kubevela ./charts/vela-core + --set multicluster.clusterGateway.image.repository=ghcr.io/oam-dev/cluster-gateway \ + --set admissionWebhooks.patch.image.repository=ghcr.io/oam-dev/kube-webhook-certgen/kube-webhook-certgen \ + --wait kubevela ./charts/vela-core \ + --debug .PHONY: e2e-setup-core-w-auth e2e-setup-core-w-auth: @@ -47,8 +50,11 @@ e2e-setup-core-w-auth: --set featureGates.zstdResourceTracker=true \ --set featureGates.zstdApplicationRevision=true \ --set featureGates.validateComponentWhenSharding=true \ - --set multicluster.clusterGateway.enabled=true \ - --set sharding.enabled=true + --set multicluster.clusterGateway.enabled=true \ + --set multicluster.clusterGateway.image.repository=ghcr.io/oam-dev/cluster-gateway \ + --set admissionWebhooks.patch.image.repository=ghcr.io/oam-dev/kube-webhook-certgen/kube-webhook-certgen \ + --set sharding.enabled=true \ + --debug kubectl get deploy kubevela-vela-core -oyaml -n vela-system | \ sed 's/schedulable-shards=/shard-id=shard-0/g' | \ sed 's/instance: kubevela/instance: kubevela-shard/g' | \ diff --git a/pkg/addon/addon.go b/pkg/addon/addon.go index 7c4973c46..49aacff9f 100644 --- a/pkg/addon/addon.go +++ b/pkg/addon/addon.go @@ -854,10 +854,7 @@ func deleteArgsSecret(ctx context.Context, k8sClient client.Client, addonName st var sec v1.Secret if err := k8sClient.Get(ctx, client.ObjectKey{Namespace: types.DefaultKubeVelaNS, Name: addonutil.Addon2SecName(addonName)}, &sec); err == nil { // Handle successful get operation - if deleteErr := k8sClient.Delete(ctx, &sec); deleteErr != nil { - return deleteErr - } - return nil + return k8sClient.Delete(ctx, &sec) } else if !apierrors.IsNotFound(err) { return err } diff --git a/pkg/addon/helper.go b/pkg/addon/helper.go index 27cc02ea3..f34c300dd 100644 --- a/pkg/addon/helper.go +++ b/pkg/addon/helper.go @@ -83,10 +83,7 @@ func DisableAddon(ctx context.Context, cli client.Client, name string, config *r } } - if err := cli.Delete(ctx, app); err != nil { - return err - } - return nil + return cli.Delete(ctx, app) } // EnableAddonByLocalDir enable an addon from local dir diff --git a/pkg/addon/registry.go b/pkg/addon/registry.go index c4c4e2187..be17b3087 100644 --- a/pkg/addon/registry.go +++ b/pkg/addon/registry.go @@ -100,10 +100,7 @@ func (r registryImpl) AddRegistry(ctx context.Context, registry Registry) error registriesKey: string(b), }, } - if err := r.client.Create(ctx, cm); err != nil { - return err - } - return nil + return r.client.Create(ctx, cm) } return err } @@ -119,10 +116,7 @@ func (r registryImpl) AddRegistry(ctx context.Context, registry Registry) error cm.Data = map[string]string{ registriesKey: string(b), } - if err := r.client.Update(ctx, cm); err != nil { - return err - } - return nil + return r.client.Update(ctx, cm) } func (r registryImpl) DeleteRegistry(ctx context.Context, name string) error { @@ -142,10 +136,7 @@ func (r registryImpl) DeleteRegistry(ctx context.Context, name string) error { cm.Data = map[string]string{ registriesKey: string(b), } - if err := r.client.Update(ctx, cm); err != nil { - return err - } - return nil + return r.client.Update(ctx, cm) } func (r registryImpl) UpdateRegistry(ctx context.Context, registry Registry) error { @@ -168,10 +159,7 @@ func (r registryImpl) UpdateRegistry(ctx context.Context, registry Registry) err cm.Data = map[string]string{ registriesKey: string(b), } - if err := r.client.Update(ctx, cm); err != nil { - return err - } - return nil + return r.client.Update(ctx, cm) } func (r registryImpl) GetRegistry(ctx context.Context, name string) (Registry, error) { diff --git a/pkg/controller/core.oam.dev/v1beta1/application/revision.go b/pkg/controller/core.oam.dev/v1beta1/application/revision.go index 2ab5e7b26..45843bc4e 100644 --- a/pkg/controller/core.oam.dev/v1beta1/application/revision.go +++ b/pkg/controller/core.oam.dev/v1beta1/application/revision.go @@ -258,14 +258,16 @@ func ComputeAppRevisionHash(appRevision *v1beta1.ApplicationRevision) (string, e revHash.WorkloadDefinitionHash[key] = hash } for key, cd := range appRevision.Spec.ComponentDefinitions { - hash, err := utils.ComputeSpecHash(&cd.Spec) + c := cd + hash, err := utils.ComputeSpecHash(&c.Spec) if err != nil { return "", err } revHash.ComponentDefinitionHash[key] = hash } for key, td := range appRevision.Spec.TraitDefinitions { - hash, err := utils.ComputeSpecHash(&td.Spec) + t := td + hash, err := utils.ComputeSpecHash(&t.Spec) if err != nil { return "", err } @@ -280,7 +282,8 @@ func ComputeAppRevisionHash(appRevision *v1beta1.ApplicationRevision) (string, e revHash.PolicyDefinitionHash[key] = hash } for key, wd := range appRevision.Spec.WorkflowStepDefinitions { - hash, err := utils.ComputeSpecHash(&wd.Spec) + w := wd + hash, err := utils.ComputeSpecHash(&w.Spec) if err != nil { return "", err } diff --git a/pkg/controller/core.oam.dev/v1beta1/core/components/componentdefinition/componentdefinition_controller.go b/pkg/controller/core.oam.dev/v1beta1/core/components/componentdefinition/componentdefinition_controller.go index 75c28e1e9..4a3e38bf5 100644 --- a/pkg/controller/core.oam.dev/v1beta1/core/components/componentdefinition/componentdefinition_controller.go +++ b/pkg/controller/core.oam.dev/v1beta1/core/components/componentdefinition/componentdefinition_controller.go @@ -75,10 +75,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu defRev, result, err := coredef.ReconcileDefinitionRevision(ctx, r.Client, r.record, &componentDefinition, r.defRevLimit, func(revision *common.Revision) error { componentDefinition.Status.LatestRevision = revision - if err := r.UpdateStatus(ctx, &componentDefinition); err != nil { - return err - } - return nil + return r.UpdateStatus(ctx, &componentDefinition) }) if result != nil { return *result, err diff --git a/pkg/controller/core.oam.dev/v1beta1/core/policies/policydefinition/policydefinition_controller.go b/pkg/controller/core.oam.dev/v1beta1/core/policies/policydefinition/policydefinition_controller.go index 6092f6fd6..6d60b7b58 100644 --- a/pkg/controller/core.oam.dev/v1beta1/core/policies/policydefinition/policydefinition_controller.go +++ b/pkg/controller/core.oam.dev/v1beta1/core/policies/policydefinition/policydefinition_controller.go @@ -77,10 +77,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu defRev, result, err := coredef.ReconcileDefinitionRevision(ctx, r.Client, r.record, &policyDefinition, r.defRevLimit, func(revision *common.Revision) error { policyDefinition.Status.LatestRevision = revision - if err := r.UpdateStatus(ctx, &policyDefinition); err != nil { - return err - } - return nil + return r.UpdateStatus(ctx, &policyDefinition) }) if result != nil { return *result, err diff --git a/pkg/controller/core.oam.dev/v1beta1/core/traits/traitdefinition/traitdefinition_controller.go b/pkg/controller/core.oam.dev/v1beta1/core/traits/traitdefinition/traitdefinition_controller.go index e417c0d71..f78f5e36d 100644 --- a/pkg/controller/core.oam.dev/v1beta1/core/traits/traitdefinition/traitdefinition_controller.go +++ b/pkg/controller/core.oam.dev/v1beta1/core/traits/traitdefinition/traitdefinition_controller.go @@ -81,10 +81,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu defRev, result, err := coredef.ReconcileDefinitionRevision(ctx, r.Client, r.record, &traitDefinition, r.defRevLimit, func(revision *common.Revision) error { traitDefinition.Status.LatestRevision = revision - if err := r.UpdateStatus(ctx, &traitDefinition); err != nil { - return err - } - return nil + return r.UpdateStatus(ctx, &traitDefinition) }) if result != nil { return *result, err diff --git a/pkg/controller/core.oam.dev/v1beta1/core/workflow/workflowstepdefinition/workflowstepdefinition_controller.go b/pkg/controller/core.oam.dev/v1beta1/core/workflow/workflowstepdefinition/workflowstepdefinition_controller.go index 4ad1b52a2..19e47fef3 100644 --- a/pkg/controller/core.oam.dev/v1beta1/core/workflow/workflowstepdefinition/workflowstepdefinition_controller.go +++ b/pkg/controller/core.oam.dev/v1beta1/core/workflow/workflowstepdefinition/workflowstepdefinition_controller.go @@ -81,10 +81,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu defRev, result, err := coredef.ReconcileDefinitionRevision(ctx, r.Client, r.record, &wfStepDefinition, r.defRevLimit, func(revision *common.Revision) error { wfStepDefinition.Status.LatestRevision = revision - if err := r.UpdateStatus(ctx, &wfStepDefinition); err != nil { - return err - } - return nil + return r.UpdateStatus(ctx, &wfStepDefinition) }) if result != nil { return *result, err diff --git a/pkg/definition/gen_sdk/gen_sdk.go b/pkg/definition/gen_sdk/gen_sdk.go index 8f507451c..52ea83d4f 100644 --- a/pkg/definition/gen_sdk/gen_sdk.go +++ b/pkg/definition/gen_sdk/gen_sdk.go @@ -126,6 +126,7 @@ func NewLanguageArgs(lang string, langArgs []string) (LanguageArgs, error) { if len(parts) != 2 { return nil, errors.Errorf("argument %s is not in the format of key=value", arg) } + fmt.Println("====availableArgs", availableArgs, langArgKey(parts[0])) if _, ok := availableArgs[langArgKey(parts[0])]; !ok { return nil, errors.Errorf("argument %s is not supported for language %s", parts[0], lang) } diff --git a/pkg/definition/gen_sdk/gen_sdk_test.go b/pkg/definition/gen_sdk/gen_sdk_test.go index cb24b7904..e67f83eb0 100644 --- a/pkg/definition/gen_sdk/gen_sdk_test.go +++ b/pkg/definition/gen_sdk/gen_sdk_test.go @@ -239,9 +239,9 @@ var _ = Describe("TestNewLanguageArgs", func() { name: "should create a languageArgs struct with the correct values", args: args{ lang: "go", - langArgs: []string{"flag1=value1", "flag2=value2"}, + langArgs: []string{"GoProxy=value1", "MainModuleVersion=value2"}, }, - want: map[string]string{"flag1": "value1", "flag2": "value2"}, + want: map[string]string{"GoProxy": "value1", "MainModuleVersion": "value2"}, wantErr: false, }, { @@ -270,6 +270,7 @@ var _ = Describe("TestNewLanguageArgs", func() { Expect(err).To(HaveOccurred()) return } + Expect(err).Should(BeNil()) for k, v := range tt.want { Expect(got.Get(langArgKey(k))).To(Equal(v)) } diff --git a/pkg/resourcekeeper/dispatch.go b/pkg/resourcekeeper/dispatch.go index 16e49d05f..ba48dd37d 100644 --- a/pkg/resourcekeeper/dispatch.go +++ b/pkg/resourcekeeper/dispatch.go @@ -85,10 +85,7 @@ func (h *resourceKeeper) Dispatch(ctx context.Context, manifests []*unstructured return err } // 3. apply manifests - if err = h.dispatch(ctx, manifests, opts); err != nil { - return err - } - return nil + return h.dispatch(ctx, manifests, opts) } func (h *resourceKeeper) record(ctx context.Context, manifests []*unstructured.Unstructured, options ...DispatchOption) error { diff --git a/pkg/utils/common/common.go b/pkg/utils/common/common.go index a9eb7c612..125fc5ee4 100644 --- a/pkg/utils/common/common.go +++ b/pkg/utils/common/common.go @@ -318,10 +318,7 @@ func RealtimePrintCommandOutput(cmd *exec.Cmd, logFile string) error { } cmd.Stdout = writer cmd.Stderr = writer - if err := cmd.Run(); err != nil { - return err - } - return nil + return cmd.Run() } // AskToChooseOneNamespace ask for choose one namespace as env diff --git a/pkg/utils/env/env.go b/pkg/utils/env/env.go index 925e2a625..b4b92308d 100644 --- a/pkg/utils/env/env.go +++ b/pkg/utils/env/env.go @@ -227,10 +227,7 @@ func SetCurrentEnv(meta *types.EnvMeta) error { return err } //nolint:gosec - if err = os.WriteFile(currentEnvPath, data, 0644); err != nil { - return err - } - return nil + return os.WriteFile(currentEnvPath, data, 0644) } // getEnvNamespaceByName get v1.Namespace object by env name diff --git a/pkg/utils/system/system.go b/pkg/utils/system/system.go index 132655139..696ce003b 100644 --- a/pkg/utils/system/system.go +++ b/pkg/utils/system/system.go @@ -96,10 +96,7 @@ func InitDirs() error { if err := InitCapabilityDir(); err != nil { return err } - if err := InitCapCenterDir(); err != nil { - return err - } - return nil + return InitCapCenterDir() } // InitCapCenterDir create dir if not exits diff --git a/pkg/webhook/utils/utils.go b/pkg/webhook/utils/utils.go index fabbaf686..83c159ada 100644 --- a/pkg/webhook/utils/utils.go +++ b/pkg/webhook/utils/utils.go @@ -69,10 +69,7 @@ func ValidateCueTemplate(cueTemplate string) error { } err := val.Validate() - if e := checkError(err); e != nil { - return e - } - return nil + return checkError(err) } func checkError(err error) error { diff --git a/pkg/workflow/operation/operation.go b/pkg/workflow/operation/operation.go index 821999c20..5b78f973e 100644 --- a/pkg/workflow/operation/operation.go +++ b/pkg/workflow/operation/operation.go @@ -142,12 +142,9 @@ func SuspendWorkflow(ctx context.Context, kubecli client.Client, app *v1beta1.Ap if !found { return fmt.Errorf("can not find step %s", stepName) } - if err := retry.RetryOnConflict(retry.DefaultBackoff, func() error { + return retry.RetryOnConflict(retry.DefaultBackoff, func() error { return kubecli.Status().Patch(ctx, app, client.Merge) - }); err != nil { - return err - } - return nil + }) } // Resume a suspending workflow @@ -237,10 +234,7 @@ func ResumeWorkflow(ctx context.Context, kubecli client.Client, app *v1beta1.App if !found { return fmt.Errorf("can not find step %s", stepName) } - if err := kubecli.Status().Patch(ctx, app, client.Merge); err != nil { - return err - } - return nil + return kubecli.Status().Patch(ctx, app, client.Merge) } // Rollback a running in middle state workflow. @@ -509,10 +503,7 @@ func TerminateWorkflow(ctx context.Context, kubecli client.Client, app *v1beta1. } } - if err := kubecli.Status().Patch(ctx, app, client.Merge); err != nil { - return err - } - return nil + return kubecli.Status().Patch(ctx, app, client.Merge) } func (wo appWorkflowOperator) writeOutput(str string) error { diff --git a/pkg/workflow/providers/oam/apply.go b/pkg/workflow/providers/oam/apply.go index 34e8bacbd..30be8dec9 100644 --- a/pkg/workflow/providers/oam/apply.go +++ b/pkg/workflow/providers/oam/apply.go @@ -225,10 +225,7 @@ func (p *provider) LoadComponentInOrder(ctx monitorContext.Context, _ wfContext. comp.Outputs = nil comps[idx] = *comp } - if err := v.FillObject(comps, "value"); err != nil { - return err - } - return nil + return v.FillObject(comps, "value") } // LoadPolicies load policy describe info in application. diff --git a/references/cli/addon-registry.go b/references/cli/addon-registry.go index ecf7890ad..e4ec07066 100644 --- a/references/cli/addon-registry.go +++ b/references/cli/addon-registry.go @@ -92,10 +92,7 @@ add a specified gitlab registry: vela addon registry add my-repo --type gitlab - return fmt.Errorf("fail to add registry %s: %w", registry.Name, err) } } - if err := addAddonRegistry(context.Background(), c, *registry); err != nil { - return err - } - return nil + return addAddonRegistry(context.Background(), c, *registry) }, } parseArgsFromFlag(cmd) @@ -131,10 +128,7 @@ func NewListAddonRegistryCommand(c common.Args, _ cmdutil.IOStreams) *cobra.Comm Long: "List addon registries.", Example: "vela addon registry list", RunE: func(cmd *cobra.Command, args []string) error { - if err := listAddonRegistry(context.Background(), c); err != nil { - return err - } - return nil + return listAddonRegistry(context.Background(), c) }, } } @@ -151,10 +145,7 @@ func NewUpdateAddonRegistryCommand(c common.Args, _ cmdutil.IOStreams) *cobra.Co if err != nil { return err } - if err := updateAddonRegistry(context.Background(), c, *registry); err != nil { - return err - } - return nil + return updateAddonRegistry(context.Background(), c, *registry) }, } parseArgsFromFlag(cmd) diff --git a/references/cli/addon.go b/references/cli/addon.go index 30f1ce949..ec8b14e5b 100644 --- a/references/cli/addon.go +++ b/references/cli/addon.go @@ -634,10 +634,7 @@ func enableAddonByLocal(ctx context.Context, name string, dir string, k8sClient } func disableAddon(client client.Client, name string, config *rest.Config, force bool) error { - if err := pkgaddon.DisableAddon(context.Background(), client, name, config, force); err != nil { - return err - } - return nil + return pkgaddon.DisableAddon(context.Background(), client, name, config, force) } func statusAddon(name string, ioStreams cmdutil.IOStreams, cmd *cobra.Command, c common.Args) error { diff --git a/references/cli/debug.go b/references/cli/debug.go index 3b0aa3485..371e84622 100644 --- a/references/cli/debug.go +++ b/references/cli/debug.go @@ -124,10 +124,7 @@ func (d *debugOpts) debugApplication(ctx context.Context, wargs *WorkflowArgs, c ioStreams.Info(color.RedString("%s%s", emojiFail, err.Error())) return nil } - if err := d.debugComponents(comps, ioStreams); err != nil { - return err - } - return nil + return d.debugComponents(comps, ioStreams) } func (d *debugOpts) debugWorkflow(ctx context.Context, wargs *WorkflowArgs, cli client.Client, pd *packages.PackageDiscover, ioStreams cmdutil.IOStreams) error { @@ -317,10 +314,7 @@ func (d *debugOpts) handleCueSteps(v *value.Value, ioStreams cmdutil.IOStreams) return nil } - if err := d.separateBySteps(v, ioStreams); err != nil { - return err - } - return nil + return d.separateBySteps(v, ioStreams) } func (d *debugOpts) separateBySteps(v *value.Value, ioStreams cmdutil.IOStreams) error { diff --git a/references/cli/exec.go b/references/cli/exec.go index f554c8930..c83ea0134 100644 --- a/references/cli/exec.go +++ b/references/cli/exec.go @@ -118,10 +118,7 @@ func NewExecCommand(c common.Args, order string, ioStreams util.IOStreams) *cobr if err := o.Complete(); err != nil { return err } - if err := o.Run(); err != nil { - return err - } - return nil + return o.Run() }, Annotations: map[string]string{ types.TagCommandOrder: order, diff --git a/references/cli/logs.go b/references/cli/logs.go index 13d2114f1..03d1bb3f6 100644 --- a/references/cli/logs.go +++ b/references/cli/logs.go @@ -58,10 +58,7 @@ func NewLogsCommand(c common.Args, order string, ioStreams util.IOStreams) *cobr return err } largs.App = app - if err := largs.Run(ctx, ioStreams); err != nil { - return err - } - return nil + return largs.Run(ctx, ioStreams) }, Annotations: map[string]string{ types.TagCommandOrder: order, diff --git a/references/cli/portforward.go b/references/cli/portforward.go index 1b3382e8d..6279f962c 100644 --- a/references/cli/portforward.go +++ b/references/cli/portforward.go @@ -121,10 +121,7 @@ func NewPortForwardCommand(c common.Args, order string, ioStreams util.IOStreams if err := o.Complete(); err != nil { return err } - if err := o.Run(); err != nil { - return err - } - return nil + return o.Run() }, Annotations: map[string]string{ types.TagCommandOrder: order, diff --git a/references/cli/registry.go b/references/cli/registry.go index 6eb4cbfd9..5bbeac438 100644 --- a/references/cli/registry.go +++ b/references/cli/registry.go @@ -174,10 +174,7 @@ func addRegistry(regName, regURL, regToken string) error { if !updated { repos = append(repos, regConfig) } - if err = StoreRepos(repos); err != nil { - return err - } - return nil + return StoreRepos(repos) } // removeRegistry will remove a registry from local diff --git a/references/cli/show.go b/references/cli/show.go index 58e34990a..960d3121c 100644 --- a/references/cli/show.go +++ b/references/cli/show.go @@ -154,10 +154,7 @@ func generateWebsiteDocs(capabilities []types.Capability, docsPath string) error return err } - if err := generateREADME(capabilities, docsPath); err != nil { - return err - } - return nil + return generateREADME(capabilities, docsPath) } func startReferenceDocsSite(ctx context.Context, ns string, c common.Args, ioStreams cmdutil.IOStreams, capabilityName string) error { diff --git a/references/cli/top/model/namespace.go b/references/cli/top/model/namespace.go index b61fc4a6f..a4c58a97f 100644 --- a/references/cli/top/model/namespace.go +++ b/references/cli/top/model/namespace.go @@ -56,6 +56,7 @@ func ListNamespaces(ctx context.Context, c client.Client) (NamespaceList, error) // ToTableBody generate body of table in namespace view func (l NamespaceList) ToTableBody() [][]string { data := make([][]string, len(l)+1) + // nolint:gosec data[0] = []string{"all", "*", "*"} for index, ns := range l { data[index+1] = []string{ns.name, ns.status, ns.age} diff --git a/references/cli/top/view/app.go b/references/cli/top/view/app.go index 630a2cdc5..83acaa35b 100644 --- a/references/cli/top/view/app.go +++ b/references/cli/top/view/app.go @@ -112,10 +112,7 @@ func (a *App) Run() error { }) }() a.Refresh() - if err := a.Application.Run(); err != nil { - return err - } - return nil + return a.Application.Run() } // Refresh will refresh the ui after the delay time diff --git a/references/cli/workflow.go b/references/cli/workflow.go index 1dd7a3f3e..c1d55acc1 100644 --- a/references/cli/workflow.go +++ b/references/cli/workflow.go @@ -596,6 +596,7 @@ func (w *WorkflowArgs) printResourceLogs(ctx context.Context, cli client.Client, return err } } else { + // nolint:gosec selectPod = &podList[0] } l := Args{ diff --git a/references/cmd/cli/main.go b/references/cmd/cli/main.go index 5a2bc577b..0a9bb4d69 100644 --- a/references/cmd/cli/main.go +++ b/references/cmd/cli/main.go @@ -17,9 +17,7 @@ limitations under the License. package main import ( - "math/rand" "os" - "time" utilfeature "k8s.io/apiserver/pkg/util/feature" "k8s.io/klog/v2" @@ -32,7 +30,6 @@ import ( func main() { preimport.ResumeLogging() - rand.Seed(time.Now().UnixNano()) _ = utilfeature.DefaultMutableFeatureGate.Set("AllAlpha=true") system.BindEnvironmentVariables() diff --git a/references/common/application.go b/references/common/application.go index 6c2e1f30e..3a23603b9 100644 --- a/references/common/application.go +++ b/references/common/application.go @@ -229,10 +229,7 @@ func (o *AppfileOptions) ApplyApp(app *corev1beta1.Application, scopes []oam.Obj } func (o *AppfileOptions) apply(app *corev1beta1.Application, scopes []oam.Object) error { - if err := appfile.Run(context.TODO(), o.Kubecli, app, scopes); err != nil { - return err - } - return nil + return appfile.Run(context.TODO(), o.Kubecli, app, scopes) } // Info shows the status of each service in the Appfile diff --git a/test/e2e-multicluster-test/multicluster_standalone_test.go b/test/e2e-multicluster-test/multicluster_standalone_test.go index 1e1159413..98a3730fc 100644 --- a/test/e2e-multicluster-test/multicluster_standalone_test.go +++ b/test/e2e-multicluster-test/multicluster_standalone_test.go @@ -164,7 +164,7 @@ var _ = Describe("Test multicluster standalone scenario", func() { g.Expect(deploys.Items[0].Spec.Replicas).Should(Equal(pointer.Int32(0))) g.Expect(k8sClient.Get(hubCtx, appKey, _app)).Should(Succeed()) g.Expect(_app.Status.Phase).Should(Equal(oamcomm.ApplicationRunning)) - }, 30*time.Second).Should(Succeed()) + }, 60*time.Second).Should(Succeed()) // update application without updating publishVersion Eventually(func(g Gomega) {