From 5ddeabb6afca68c7f797ff02c8746f168e7e4f9b Mon Sep 17 00:00:00 2001
From: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Date: Tue, 3 Aug 2021 12:47:59 +0800
Subject: [PATCH] fix resource tracker ownerRef override (#2002)

---
 .../application/dispatch/dispatch_test.go     | 109 ++++++++++++++++++
 1 file changed, 109 insertions(+)
 create mode 100644 pkg/controller/core.oam.dev/v1alpha2/application/dispatch/dispatch_test.go

diff --git a/pkg/controller/core.oam.dev/v1alpha2/application/dispatch/dispatch_test.go b/pkg/controller/core.oam.dev/v1alpha2/application/dispatch/dispatch_test.go
new file mode 100644
index 000000000..0f83b7caf
--- /dev/null
+++ b/pkg/controller/core.oam.dev/v1alpha2/application/dispatch/dispatch_test.go
@@ -0,0 +1,109 @@
+/*
+Copyright 2021 The KubeVela Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package dispatch
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+)
+
+func TestSetOAMOwner(t *testing.T) {
+	tests := map[string]struct {
+		OO       ObjectOwner
+		CO       v1.OwnerReference
+		ExpOwner []v1.OwnerReference
+	}{
+		"test empty origin owner": {
+			OO: &unstructured.Unstructured{},
+			CO: v1.OwnerReference{
+				APIVersion: "core.oam.dev/v1beta1",
+				Kind:       "ResourceTracker",
+				Name:       "myapp",
+			},
+			ExpOwner: []v1.OwnerReference{{
+				APIVersion: "core.oam.dev/v1beta1",
+				Kind:       "ResourceTracker",
+				Name:       "myapp",
+			}},
+		},
+		"test remove old resourceTracker owner": {
+			OO: &unstructured.Unstructured{
+				Object: map[string]interface{}{
+					"metadata": map[string]interface{}{
+						"ownerReferences": []interface{}{
+							map[string]interface{}{
+								"apiVersion": "core.oam.dev/v1beta1",
+								"kind":       "ResourceTracker",
+							},
+							map[string]interface{}{
+								"apiVersion": "core.oam.dev/v1alpha2",
+								"kind":       "ApplicationContext",
+							},
+						},
+					},
+				},
+			},
+			CO: v1.OwnerReference{
+				APIVersion: "core.oam.dev/v1beta1",
+				Kind:       "ResourceTracker",
+				Name:       "myapp",
+			},
+			ExpOwner: []v1.OwnerReference{{
+				APIVersion: "core.oam.dev/v1beta1",
+				Kind:       "ResourceTracker",
+				Name:       "myapp",
+			}},
+		},
+		"test other owner not removed": {
+			OO: &unstructured.Unstructured{
+				Object: map[string]interface{}{
+					"metadata": map[string]interface{}{
+						"ownerReferences": []interface{}{
+							map[string]interface{}{
+								"apiVersion": "core.oam.dev/v1alpha1",
+								"kind":       "Rollout",
+								"name":       "xxx",
+							},
+						},
+					},
+				},
+			},
+			CO: v1.OwnerReference{
+				APIVersion: "core.oam.dev/v1beta1",
+				Kind:       "ResourceTracker",
+				Name:       "myapp",
+			},
+			ExpOwner: []v1.OwnerReference{{
+				APIVersion: "core.oam.dev/v1beta1",
+				Kind:       "ResourceTracker",
+				Name:       "myapp",
+			},
+				{
+					APIVersion: "core.oam.dev/v1alpha1",
+					Kind:       "Rollout",
+					Name:       "xxx",
+				}},
+		},
+	}
+	for name, ti := range tests {
+		setOrOverrideOAMControllerOwner(ti.OO, ti.CO)
+		assert.Equal(t, ti.ExpOwner, ti.OO.GetOwnerReferences(), name)
+	}
+}