diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index 10602bc52..5aaf34be2 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -78,7 +78,6 @@ jobs: - name: Get Ginkgo run: | go install github.com/onsi/ginkgo/v2/ginkgo@v2.10.0 - go get github.com/onsi/gomega/... - name: Load image run: | diff --git a/pkg/controller/core.oam.dev/v1beta1/application/application_controller.go b/pkg/controller/core.oam.dev/v1beta1/application/application_controller.go index a4a625e1a..eebb746b5 100644 --- a/pkg/controller/core.oam.dev/v1beta1/application/application_controller.go +++ b/pkg/controller/core.oam.dev/v1beta1/application/application_controller.go @@ -198,7 +198,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu if err != nil { logCtx.Error(err, "[handle workflow]") r.Recorder.Event(app, event.Warning(velatypes.ReasonFailedWorkflow, err)) - return r.endWithNegativeCondition(logCtx, app, condition.ErrorCondition(common.WorkflowCondition.String(), err), common.ApplicationRendering) + return r.endWithNegativeCondition(logCtx, app, condition.ErrorCondition(common.WorkflowCondition.String(), err), common.ApplicationWorkflowFailed) } app.Status.SetConditions(condition.ReadyCondition(common.RenderCondition.String())) r.Recorder.Event(app, event.Normal(velatypes.ReasonRendered, velatypes.MessageRendered)) diff --git a/test/e2e-test/testdata/app/app10.yaml b/test/e2e-test/testdata/app/app10.yaml index b432d0e1b..d13a9b92a 100644 --- a/test/e2e-test/testdata/app/app10.yaml +++ b/test/e2e-test/testdata/app/app10.yaml @@ -7,6 +7,13 @@ spec: - name: myweb type: worker properties: + image: "stefanprodan/podinfo:4.0.3" cmd: - ./podinfo - - stress-cpu=1 \ No newline at end of file + - stress-cpu=1 + workflow: + steps: + - name: apply + type: apply-component + properties: + component: test