From 3425c2043f11ce237d3cb2f009acc02bb692505b Mon Sep 17 00:00:00 2001 From: barnettZQG Date: Sat, 29 Oct 2022 12:14:26 +0800 Subject: [PATCH] Fix: do not change the workflow after the env changed Signed-off-by: barnettZQG --- pkg/apiserver/domain/service/env.go | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/pkg/apiserver/domain/service/env.go b/pkg/apiserver/domain/service/env.go index 326bdfd33..3871f9020 100644 --- a/pkg/apiserver/domain/service/env.go +++ b/pkg/apiserver/domain/service/env.go @@ -184,23 +184,6 @@ func checkEqual(old, new []string) bool { return reflect.DeepEqual(old, new) } -func (p *envServiceImpl) updateAppWithNewEnv(ctx context.Context, envName string, env *model.Env) error { - - // List all apps inside the env - apps, err := listApp(ctx, p.Store, apisv1.ListApplicationOptions{Env: envName}) - if err != nil { - return err - } - for _, app := range apps { - err = repository.UpdateEnvWorkflow(ctx, p.KubeClient, p.Store, app, env) - if err != nil { - return err - } - } - return nil - -} - // UpdateEnv update an env for request func (p *envServiceImpl) UpdateEnv(ctx context.Context, name string, req apisv1.UpdateEnvRequest) (*apisv1.Env, error) { env := &model.Env{} @@ -222,9 +205,7 @@ func (p *envServiceImpl) UpdateEnv(ctx context.Context, name string, req apisv1. return nil, bcode.ErrEnvTargetConflict } - var targetChanged bool if len(req.Targets) > 0 && !checkEqual(env.Targets, req.Targets) { - targetChanged = true env.Targets = req.Targets } @@ -247,13 +228,6 @@ func (p *envServiceImpl) UpdateEnv(ctx context.Context, name string, req apisv1. return nil, err } - if targetChanged { - if err = p.updateAppWithNewEnv(ctx, name, env); err != nil { - log.Logger.Errorf("update envbinding failure %s", err.Error()) - return nil, err - } - } - if err := managePrivilegesForEnvironment(ctx, p.KubeClient, env, false); err != nil { return nil, err }