From 293f38dd84db7c5cfd53ccb3fd6658b85564d79c Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 19 Sep 2022 11:18:33 +0800 Subject: [PATCH] Fix: panic when properties empty (#4747) Signed-off-by: Somefive (cherry picked from commit 13fec3cb1852de38f337832cf234cd830e098f61) Co-authored-by: Somefive --- pkg/workflow/step/generator.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/workflow/step/generator.go b/pkg/workflow/step/generator.go index 3b1e2de6f..4701602c0 100644 --- a/pkg/workflow/step/generator.go +++ b/pkg/workflow/step/generator.go @@ -168,7 +168,9 @@ func (g *DeployPreApproveWorkflowStepGenerator) Generate(app *v1beta1.Applicatio for _, step := range existingSteps { if step.Type == "deploy" && !lastSuspend { props := DeployWorkflowStepSpec{} - _ = utils.StrictUnmarshal(step.Properties.Raw, &props) + if step.Properties != nil { + _ = utils.StrictUnmarshal(step.Properties.Raw, &props) + } if props.Auto != nil && !*props.Auto { steps = append(steps, v1beta1.WorkflowStep{ Name: "manual-approve-" + step.Name,