mirror of
https://github.com/kubeshark/kubeshark.git
synced 2026-08-18 03:46:38 +00:00
* deps: bump indirect deps to clear critical/high Dependabot alerts Bumps the vulnerable indirect dependencies flagged as critical or high severity in Dependabot: - golang.org/x/crypto v0.39.0 -> v0.54.0 (7 critical + 2 high: SSH agent constraint/key-constraint bypass, @revoked auth bypass, FIDO/U2F presence check bypass, VerifiedPublicKeyCallback permission skip, infinite loop on large channel writes, client-induced server deadlock, RSA/DSA DoS, byte arithmetic underflow panic) - google.golang.org/grpc v1.68.1 -> v1.83.0 (critical: authz bypass via missing leading slash in :path; high: xDS RBAC and HTTP/2 issues) - github.com/containerd/containerd v1.7.27 -> v1.7.34 (high: LABEL -> restart-monitor binary:// host-root RCE, runAsNonRoot evasion, local privesc via wide CRI directory permissions) - oras.land/oras-go/v2 v2.6.0 -> v2.6.2 (high: CVE-2026-50163 hardlink extract-dir escape, credential forwarding via unvalidated Location header) - github.com/moby/spdystream v0.5.0 -> v0.5.1 (high: DoS on CRI) Transitively pulls up x/net, x/sync, x/sys, x/term, x/text, x/time, x/oauth2, protobuf, filepath-securejoin, selinux and go-logr via go mod tidy. The go directive moves 1.24.0 -> 1.25.0 (required by the upgraded modules); the explicit toolchain pin is dropped. CI resolves Go from go.mod, so no workflow changes are needed. go build ./... and go test ./... pass. * ci: move golangci-lint to v2, fix resulting lint issues golangci-lint-action@v3 pins `latest` to v1.64.8, which is built with go1.24 and refuses to run now that go.mod targets 1.25.0: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0) Move the job to golangci-lint-action@v7 + v2.8.0 and add a .golangci.yml mirroring the hub repo's v2 config: govet, staticcheck, ineffassign and unused, plus gofmt/goimports as formatters. Fixes for the issues that surfaced: - ST1005: lowercase error strings, drop trailing '!' in connect/hub.go - SA4011: kubernetes/watch.go had a `break` inside a `select` default that broke the select rather than the loop, i.e. a no-op; removed - QF1008: drop the embedded ChartPathOptions selector in helm.go - QF1003: tagged switch on r.URL.Path in mcp_test.go - QF1004: strings.Replace(..., -1) -> strings.ReplaceAll - gofmt -s and goimports with a local prefix across the tree errcheck is not in the enabled set, matching hub. * cmd: clarify --time parse error in pcap dump The error neither named the offending flag/value nor separated the wrapped error from the message. Reported by Copilot on #1952. --------- Co-authored-by: Alon Girmonsky <1990761+alongir@users.noreply.github.com>
170 lines
5.7 KiB
Go
170 lines
5.7 KiB
Go
package kubernetes
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"net/url"
|
|
"regexp"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/rs/zerolog/log"
|
|
"k8s.io/apimachinery/pkg/util/httpstream"
|
|
"k8s.io/client-go/tools/portforward"
|
|
"k8s.io/client-go/transport/spdy"
|
|
"k8s.io/kubectl/pkg/proxy"
|
|
|
|
"github.com/kubeshark/kubeshark/config"
|
|
)
|
|
|
|
const k8sProxyApiPrefix = "/"
|
|
const selfServicePort = 80
|
|
|
|
func StartProxy(kubernetesProvider *Provider, proxyHost string, srcPort uint16, selfNamespace string, selfServiceName string) (*http.Server, error) {
|
|
log.Info().
|
|
Str("proxy-host", proxyHost).
|
|
Str("namespace", selfNamespace).
|
|
Str("service", selfServiceName).
|
|
Int("src-port", int(srcPort)).
|
|
Msg("Starting proxy...")
|
|
|
|
filter := &proxy.FilterServer{
|
|
AcceptPaths: proxy.MakeRegexpArrayOrDie(proxy.DefaultPathAcceptRE),
|
|
RejectPaths: proxy.MakeRegexpArrayOrDie(proxy.DefaultPathRejectRE),
|
|
AcceptHosts: proxy.MakeRegexpArrayOrDie("^.*"),
|
|
RejectMethods: proxy.MakeRegexpArrayOrDie(proxy.DefaultMethodRejectRE),
|
|
}
|
|
|
|
proxyHandler, err := proxy.NewProxyHandler(k8sProxyApiPrefix, filter, &kubernetesProvider.clientConfig, time.Second*2, false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
mux := http.NewServeMux()
|
|
mux.Handle(k8sProxyApiPrefix, getRerouteHttpHandlerSelfAPI(proxyHandler, selfNamespace, selfServiceName))
|
|
mux.Handle("/static/", getRerouteHttpHandlerSelfStatic(proxyHandler, selfNamespace, selfServiceName))
|
|
|
|
l, err := net.Listen("tcp", fmt.Sprintf("%s:%d", proxyHost, int(srcPort)))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
server := &http.Server{
|
|
Handler: mux,
|
|
}
|
|
|
|
go func() {
|
|
if err := server.Serve(l); err != nil && err != http.ErrServerClosed {
|
|
log.Error().Err(err).Msg("While creating proxy!")
|
|
return
|
|
}
|
|
}()
|
|
|
|
return server, nil
|
|
}
|
|
|
|
func getSelfHubProxiedHostAndPath(selfNamespace string, selfServiceName string) string {
|
|
return fmt.Sprintf("/api/v1/namespaces/%s/services/%s:%d/proxy", selfNamespace, selfServiceName, selfServicePort)
|
|
}
|
|
|
|
func GetProxyOnPort(port uint16) string {
|
|
return fmt.Sprintf("http://%s:%d", config.Config.Tap.Proxy.Host, port)
|
|
}
|
|
|
|
func GetHubUrl() string {
|
|
return fmt.Sprintf("%s/api", GetProxyOnPort(config.Config.Tap.Proxy.Front.Port))
|
|
}
|
|
|
|
func getRerouteHttpHandlerSelfAPI(proxyHandler http.Handler, selfNamespace string, selfServiceName string) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Access-Control-Allow-Origin", "*")
|
|
w.Header().Set("Access-Control-Allow-Credentials", "true")
|
|
w.Header().Set("Access-Control-Allow-Headers", "Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization, accept, origin, Cache-Control, X-Requested-With, x-session-token")
|
|
w.Header().Set("Access-Control-Allow-Methods", "POST, OPTIONS, GET, PUT, DELETE")
|
|
|
|
if r.Method == "OPTIONS" {
|
|
w.WriteHeader(http.StatusNoContent)
|
|
return
|
|
}
|
|
|
|
proxiedPath := getSelfHubProxiedHostAndPath(selfNamespace, selfServiceName)
|
|
|
|
//avoid redirecting several times
|
|
if !strings.Contains(r.URL.Path, proxiedPath) {
|
|
r.URL.Path = fmt.Sprintf("%s%s", getSelfHubProxiedHostAndPath(selfNamespace, selfServiceName), r.URL.Path)
|
|
}
|
|
proxyHandler.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
func getRerouteHttpHandlerSelfStatic(proxyHandler http.Handler, selfNamespace string, selfServiceName string) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
r.URL.Path = strings.Replace(r.URL.Path, "/static/", fmt.Sprintf("%s/static/", getSelfHubProxiedHostAndPath(selfNamespace, selfServiceName)), 1)
|
|
proxyHandler.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
func NewPortForward(kubernetesProvider *Provider, namespace string, podRegex *regexp.Regexp, srcPort uint16, dstPort uint16, ctx context.Context) (*portforward.PortForwarder, error) {
|
|
pods, err := kubernetesProvider.ListPodsByAppLabel(ctx, namespace, map[string]string{AppLabelKey: "front"})
|
|
if err != nil {
|
|
return nil, err
|
|
} else if len(pods) == 0 {
|
|
return nil, fmt.Errorf("didn't find pod to port-forward")
|
|
}
|
|
|
|
podName := pods[0].Name
|
|
|
|
log.Info().
|
|
Str("namespace", namespace).
|
|
Str("pod", podName).
|
|
Int("src-port", int(srcPort)).
|
|
Int("dst-port", int(dstPort)).
|
|
Msg("Starting proxy using port-forward method...")
|
|
|
|
dialer, err := getHttpDialer(kubernetesProvider, namespace, podName)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
stopChan, readyChan := make(chan struct{}, 1), make(chan struct{}, 1)
|
|
out, errOut := new(bytes.Buffer), new(bytes.Buffer)
|
|
|
|
forwarder, err := portforward.New(dialer, []string{fmt.Sprintf("%d:%d", srcPort, dstPort)}, stopChan, readyChan, out, errOut)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
go func() {
|
|
if err = forwarder.ForwardPorts(); err != nil {
|
|
log.Error().Err(err).Msg("While Kubernetes port-forwarding!")
|
|
log.Info().Str("command", fmt.Sprintf("kubectl port-forward -n %s service/kubeshark-front 8899:80", config.Config.Tap.Release.Namespace)).Msg("Please try running:")
|
|
return
|
|
}
|
|
}()
|
|
|
|
return forwarder, nil
|
|
}
|
|
|
|
func getHttpDialer(kubernetesProvider *Provider, namespace string, podName string) (httpstream.Dialer, error) {
|
|
roundTripper, upgrader, err := spdy.RoundTripperFor(&kubernetesProvider.clientConfig)
|
|
if err != nil {
|
|
log.Error().Err(err).Msg("While creating HTTP dialer!")
|
|
return nil, err
|
|
}
|
|
|
|
clientConfigHostUrl, err := url.Parse(kubernetesProvider.clientConfig.Host)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed parsing client config host URL %s, error %w", kubernetesProvider.clientConfig.Host, err)
|
|
}
|
|
path := fmt.Sprintf("%s/api/v1/namespaces/%s/pods/%s/portforward", clientConfigHostUrl.Path, namespace, podName)
|
|
|
|
serverURL := url.URL{Scheme: "https", Path: path, Host: clientConfigHostUrl.Host}
|
|
log.Debug().
|
|
Str("url", serverURL.String()).
|
|
Msg("HTTP dialer URL:")
|
|
|
|
return spdy.NewDialer(upgrader, &http.Client{Transport: roundTripper}, http.MethodPost, &serverURL), nil
|
|
}
|