mirror of
https://github.com/kubeshark/kubeshark.git
synced 2026-08-18 03:46:38 +00:00
* deps: bump indirect deps to clear critical/high Dependabot alerts Bumps the vulnerable indirect dependencies flagged as critical or high severity in Dependabot: - golang.org/x/crypto v0.39.0 -> v0.54.0 (7 critical + 2 high: SSH agent constraint/key-constraint bypass, @revoked auth bypass, FIDO/U2F presence check bypass, VerifiedPublicKeyCallback permission skip, infinite loop on large channel writes, client-induced server deadlock, RSA/DSA DoS, byte arithmetic underflow panic) - google.golang.org/grpc v1.68.1 -> v1.83.0 (critical: authz bypass via missing leading slash in :path; high: xDS RBAC and HTTP/2 issues) - github.com/containerd/containerd v1.7.27 -> v1.7.34 (high: LABEL -> restart-monitor binary:// host-root RCE, runAsNonRoot evasion, local privesc via wide CRI directory permissions) - oras.land/oras-go/v2 v2.6.0 -> v2.6.2 (high: CVE-2026-50163 hardlink extract-dir escape, credential forwarding via unvalidated Location header) - github.com/moby/spdystream v0.5.0 -> v0.5.1 (high: DoS on CRI) Transitively pulls up x/net, x/sync, x/sys, x/term, x/text, x/time, x/oauth2, protobuf, filepath-securejoin, selinux and go-logr via go mod tidy. The go directive moves 1.24.0 -> 1.25.0 (required by the upgraded modules); the explicit toolchain pin is dropped. CI resolves Go from go.mod, so no workflow changes are needed. go build ./... and go test ./... pass. * ci: move golangci-lint to v2, fix resulting lint issues golangci-lint-action@v3 pins `latest` to v1.64.8, which is built with go1.24 and refuses to run now that go.mod targets 1.25.0: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0) Move the job to golangci-lint-action@v7 + v2.8.0 and add a .golangci.yml mirroring the hub repo's v2 config: govet, staticcheck, ineffassign and unused, plus gofmt/goimports as formatters. Fixes for the issues that surfaced: - ST1005: lowercase error strings, drop trailing '!' in connect/hub.go - SA4011: kubernetes/watch.go had a `break` inside a `select` default that broke the select rather than the loop, i.e. a no-op; removed - QF1008: drop the embedded ChartPathOptions selector in helm.go - QF1003: tagged switch on r.URL.Path in mcp_test.go - QF1004: strings.Replace(..., -1) -> strings.ReplaceAll - gofmt -s and goimports with a local prefix across the tree errcheck is not in the enabled set, matching hub. * cmd: clarify --time parse error in pcap dump The error neither named the offending flag/value nor separated the wrapped error from the message. Reported by Copilot on #1952. --------- Co-authored-by: Alon Girmonsky <1990761+alongir@users.noreply.github.com>
112 lines
3.4 KiB
Go
112 lines
3.4 KiB
Go
package cmd
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"github.com/creasty/defaults"
|
|
"github.com/rs/zerolog"
|
|
"github.com/rs/zerolog/log"
|
|
"github.com/spf13/cobra"
|
|
"k8s.io/client-go/kubernetes"
|
|
"k8s.io/client-go/tools/clientcmd"
|
|
"k8s.io/client-go/util/homedir"
|
|
|
|
"github.com/kubeshark/kubeshark/config/configStructs"
|
|
)
|
|
|
|
// pcapDumpCmd represents the consolidated pcapdump command
|
|
var pcapDumpCmd = &cobra.Command{
|
|
Use: "pcapdump",
|
|
Short: "Store all captured traffic (including decrypted TLS) in a PCAP file.",
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
// Retrieve the kubeconfig path from the flag
|
|
kubeconfig, _ := cmd.Flags().GetString(configStructs.PcapKubeconfig)
|
|
|
|
// If kubeconfig is not provided, use the default location
|
|
if kubeconfig == "" {
|
|
if home := homedir.HomeDir(); home != "" {
|
|
kubeconfig = filepath.Join(home, ".kube", "config")
|
|
} else {
|
|
return errors.New("kubeconfig flag not provided and no home directory available for default config location")
|
|
}
|
|
}
|
|
|
|
debugEnabled, _ := cmd.Flags().GetBool("debug")
|
|
if debugEnabled {
|
|
zerolog.SetGlobalLevel(zerolog.DebugLevel)
|
|
log.Debug().Msg("Debug logging enabled")
|
|
} else {
|
|
zerolog.SetGlobalLevel(zerolog.InfoLevel)
|
|
}
|
|
|
|
// Use the current context in kubeconfig
|
|
config, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
|
|
if err != nil {
|
|
return fmt.Errorf("error building kubeconfig: %w", err)
|
|
}
|
|
|
|
clientset, err := kubernetes.NewForConfig(config)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating Kubernetes client: %w", err)
|
|
}
|
|
|
|
// Parse the `--time` flag
|
|
timeIntervalStr, _ := cmd.Flags().GetString("time")
|
|
var cutoffTime *time.Time // Use a pointer to distinguish between provided and not provided
|
|
if timeIntervalStr != "" {
|
|
duration, err := time.ParseDuration(timeIntervalStr)
|
|
if err != nil {
|
|
return fmt.Errorf("invalid --time value %q: %w", timeIntervalStr, err)
|
|
}
|
|
tempCutoffTime := time.Now().Add(-duration)
|
|
cutoffTime = &tempCutoffTime
|
|
}
|
|
|
|
// Test the dest dir if provided
|
|
destDir, _ := cmd.Flags().GetString(configStructs.PcapDest)
|
|
if destDir != "" {
|
|
info, err := os.Stat(destDir)
|
|
if os.IsNotExist(err) {
|
|
return fmt.Errorf("directory does not exist: %s", destDir)
|
|
}
|
|
if err != nil {
|
|
return fmt.Errorf("error checking dest directory: %w", err)
|
|
}
|
|
if !info.IsDir() {
|
|
return fmt.Errorf("dest path is not a directory: %s", destDir)
|
|
}
|
|
tempFile, err := os.CreateTemp(destDir, "write-test-*")
|
|
if err != nil {
|
|
return fmt.Errorf("directory %s is not writable", destDir)
|
|
}
|
|
_ = os.Remove(tempFile.Name())
|
|
}
|
|
|
|
log.Info().Msg("Copying PCAP files")
|
|
err = copyPcapFiles(clientset, config, destDir, cutoffTime)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
},
|
|
}
|
|
|
|
func init() {
|
|
rootCmd.AddCommand(pcapDumpCmd)
|
|
|
|
defaultPcapDumpConfig := configStructs.PcapDumpConfig{}
|
|
if err := defaults.Set(&defaultPcapDumpConfig); err != nil {
|
|
log.Debug().Err(err).Send()
|
|
}
|
|
|
|
pcapDumpCmd.Flags().String(configStructs.PcapTime, "", "Time interval (e.g., 10m, 1h) in the past for which the pcaps are copied")
|
|
pcapDumpCmd.Flags().String(configStructs.PcapDest, "", "Local destination path for copied PCAP files (can not be used together with --enabled)")
|
|
pcapDumpCmd.Flags().String(configStructs.PcapKubeconfig, "", "Path for kubeconfig (if not provided the default location will be checked)")
|
|
pcapDumpCmd.Flags().Bool("debug", false, "Enable debug logging")
|
|
}
|