mirror of
https://github.com/kubeshark/kubeshark.git
synced 2026-08-18 03:46:38 +00:00
* deps: bump indirect deps to clear critical/high Dependabot alerts Bumps the vulnerable indirect dependencies flagged as critical or high severity in Dependabot: - golang.org/x/crypto v0.39.0 -> v0.54.0 (7 critical + 2 high: SSH agent constraint/key-constraint bypass, @revoked auth bypass, FIDO/U2F presence check bypass, VerifiedPublicKeyCallback permission skip, infinite loop on large channel writes, client-induced server deadlock, RSA/DSA DoS, byte arithmetic underflow panic) - google.golang.org/grpc v1.68.1 -> v1.83.0 (critical: authz bypass via missing leading slash in :path; high: xDS RBAC and HTTP/2 issues) - github.com/containerd/containerd v1.7.27 -> v1.7.34 (high: LABEL -> restart-monitor binary:// host-root RCE, runAsNonRoot evasion, local privesc via wide CRI directory permissions) - oras.land/oras-go/v2 v2.6.0 -> v2.6.2 (high: CVE-2026-50163 hardlink extract-dir escape, credential forwarding via unvalidated Location header) - github.com/moby/spdystream v0.5.0 -> v0.5.1 (high: DoS on CRI) Transitively pulls up x/net, x/sync, x/sys, x/term, x/text, x/time, x/oauth2, protobuf, filepath-securejoin, selinux and go-logr via go mod tidy. The go directive moves 1.24.0 -> 1.25.0 (required by the upgraded modules); the explicit toolchain pin is dropped. CI resolves Go from go.mod, so no workflow changes are needed. go build ./... and go test ./... pass. * ci: move golangci-lint to v2, fix resulting lint issues golangci-lint-action@v3 pins `latest` to v1.64.8, which is built with go1.24 and refuses to run now that go.mod targets 1.25.0: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0) Move the job to golangci-lint-action@v7 + v2.8.0 and add a .golangci.yml mirroring the hub repo's v2 config: govet, staticcheck, ineffassign and unused, plus gofmt/goimports as formatters. Fixes for the issues that surfaced: - ST1005: lowercase error strings, drop trailing '!' in connect/hub.go - SA4011: kubernetes/watch.go had a `break` inside a `select` default that broke the select rather than the loop, i.e. a no-op; removed - QF1008: drop the embedded ChartPathOptions selector in helm.go - QF1003: tagged switch on r.URL.Path in mcp_test.go - QF1004: strings.Replace(..., -1) -> strings.ReplaceAll - gofmt -s and goimports with a local prefix across the tree errcheck is not in the enabled set, matching hub. * cmd: clarify --time parse error in pcap dump The error neither named the offending flag/value nor separated the wrapped error from the message. Reported by Copilot on #1952. --------- Co-authored-by: Alon Girmonsky <1990761+alongir@users.noreply.github.com>
185 lines
6.0 KiB
Go
185 lines
6.0 KiB
Go
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
"os"
|
|
"os/signal"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/creasty/defaults"
|
|
"github.com/gorilla/websocket"
|
|
"github.com/rs/zerolog/log"
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/kubeshark/kubeshark/config"
|
|
"github.com/kubeshark/kubeshark/config/configStructs"
|
|
"github.com/kubeshark/kubeshark/kubernetes"
|
|
"github.com/kubeshark/kubeshark/utils"
|
|
)
|
|
|
|
var consoleCmd = &cobra.Command{
|
|
Use: "console",
|
|
Short: "Stream the scripting console logs into shell (temporarily non-functional — under refactoring after hub API changes)",
|
|
Long: `Stream the scripting console logs into shell.
|
|
|
|
NOTE: This command is currently non-functional and under refactoring. The hub
|
|
moved scripting-console log streaming off the /scripts/logs WebSocket onto a
|
|
Connect-RPC streaming service, and this client has not yet been updated to use
|
|
it, so no logs will stream until the migration lands.`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
log.Warn().Msg(fmt.Sprintf(utils.Yellow, "The 'console' command is temporarily non-functional and under refactoring: the hub moved scripting-console log streaming off the /scripts/logs WebSocket onto a Connect-RPC service, and this client has not yet been updated. No logs will stream, so the command exits without doing anything."))
|
|
return nil
|
|
},
|
|
}
|
|
|
|
func init() {
|
|
rootCmd.AddCommand(consoleCmd)
|
|
|
|
defaultTapConfig := configStructs.TapConfig{}
|
|
if err := defaults.Set(&defaultTapConfig); err != nil {
|
|
log.Debug().Err(err).Send()
|
|
}
|
|
|
|
consoleCmd.Flags().Uint16(configStructs.ProxyFrontPortLabel, defaultTapConfig.Proxy.Front.Port, "Provide a custom port for the Kubeshark")
|
|
consoleCmd.Flags().String(configStructs.ProxyHostLabel, defaultTapConfig.Proxy.Host, "Provide a custom host for the Kubeshark")
|
|
consoleCmd.Flags().StringP(configStructs.ReleaseNamespaceLabel, "s", defaultTapConfig.Release.Namespace, "Release namespace of Kubeshark")
|
|
}
|
|
|
|
//nolint:unused // retained for the in-progress console refactoring; re-wired once the Connect-RPC client lands
|
|
func runConsoleWithoutProxy() {
|
|
log.Info().Msg("Starting scripting console ...")
|
|
time.Sleep(5 * time.Second)
|
|
|
|
// Best-effort: mint a scoped ServiceAccount token to authenticate to a
|
|
// gated Hub as kubeshark-cli; fall back to License-Key when not possible.
|
|
saToken := ""
|
|
if provider, err := getKubernetesProviderForCli(true, true); err == nil {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
|
|
if tok, terr := provider.MintHubToken(ctx, config.Config.Tap.Release.Namespace); terr == nil {
|
|
saToken = tok
|
|
}
|
|
cancel()
|
|
}
|
|
|
|
hubUrl := kubernetes.GetHubUrl()
|
|
for {
|
|
|
|
// Attempt to connect to the Hub every second
|
|
response, err := http.Get(fmt.Sprintf("%s/echo", hubUrl))
|
|
if err != nil || response.StatusCode != 200 {
|
|
log.Info().Msg(fmt.Sprintf(utils.Yellow, "Couldn't connect to Hub."))
|
|
time.Sleep(5 * time.Second)
|
|
continue
|
|
}
|
|
|
|
interrupt := make(chan os.Signal, 1)
|
|
signal.Notify(interrupt, os.Interrupt)
|
|
|
|
log.Info().Str("host", config.Config.Tap.Proxy.Host).Str("url", hubUrl).Msg("Connecting to:")
|
|
u := url.URL{
|
|
Scheme: "ws",
|
|
Host: fmt.Sprintf("%s:%d", config.Config.Tap.Proxy.Host, config.Config.Tap.Proxy.Front.Port),
|
|
Path: "/api/scripts/logs",
|
|
}
|
|
headers := http.Header{}
|
|
headers.Set(utils.X_KUBESHARK_CAPTURE_HEADER_KEY, utils.X_KUBESHARK_CAPTURE_HEADER_IGNORE_VALUE)
|
|
if saToken != "" {
|
|
headers.Set(utils.CLI_AUTH_HEADER, saToken)
|
|
} else {
|
|
headers.Set(utils.LICENSE_KEY_HEADER, config.Config.License)
|
|
}
|
|
|
|
c, _, err := websocket.DefaultDialer.Dial(u.String(), headers)
|
|
if err != nil {
|
|
log.Error().Err(err).Msg("Websocket dial error, retrying in 5 seconds...")
|
|
time.Sleep(5 * time.Second) // Delay before retrying
|
|
continue
|
|
}
|
|
defer c.Close()
|
|
|
|
done := make(chan struct{})
|
|
|
|
go func() {
|
|
defer close(done)
|
|
for {
|
|
_, message, err := c.ReadMessage()
|
|
if err != nil {
|
|
log.Error().Err(err).Msg("Error reading websocket message, reconnecting...")
|
|
break // Break to reconnect
|
|
}
|
|
|
|
msg := string(message)
|
|
if strings.Contains(msg, ":ERROR]") {
|
|
msg = fmt.Sprintf(utils.Red, msg)
|
|
fmt.Fprintln(os.Stderr, msg)
|
|
} else {
|
|
fmt.Fprintln(os.Stdout, msg)
|
|
}
|
|
}
|
|
}()
|
|
|
|
ticker := time.NewTicker(time.Second)
|
|
defer ticker.Stop()
|
|
|
|
select {
|
|
case <-done:
|
|
log.Warn().Msg(fmt.Sprintf(utils.Yellow, "Connection closed, reconnecting..."))
|
|
time.Sleep(5 * time.Second) // Delay before reconnecting
|
|
continue // Reconnect after error
|
|
case <-interrupt:
|
|
err := c.WriteMessage(websocket.CloseMessage, websocket.FormatCloseMessage(websocket.CloseNormalClosure, ""))
|
|
if err != nil {
|
|
log.Error().Err(err).Send()
|
|
continue
|
|
}
|
|
|
|
select {
|
|
case <-done:
|
|
case <-time.After(time.Second):
|
|
}
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
//nolint:unused // retained for the in-progress console refactoring; re-wired once the Connect-RPC client lands
|
|
func runConsole() {
|
|
log.Warn().Msg(fmt.Sprintf(utils.Yellow, "The 'console' command is temporarily non-functional and under refactoring: the hub moved scripting-console log streaming off the /scripts/logs WebSocket onto a Connect-RPC service, and this client has not yet been updated. No logs will stream."))
|
|
|
|
go runConsoleWithoutProxy()
|
|
|
|
// Create interrupt channel and setup signal handling once
|
|
interrupt := make(chan os.Signal, 1)
|
|
signal.Notify(interrupt, os.Interrupt)
|
|
done := make(chan struct{})
|
|
|
|
ticker := time.NewTicker(5 * time.Second)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-interrupt:
|
|
// Handle interrupt and exit gracefully
|
|
log.Warn().Msg(fmt.Sprintf(utils.Yellow, "Received interrupt, exiting..."))
|
|
select {
|
|
case <-done:
|
|
case <-time.After(time.Second):
|
|
}
|
|
return
|
|
|
|
case <-ticker.C:
|
|
// Attempt to connect to the Hub every second
|
|
hubUrl := kubernetes.GetHubUrl()
|
|
response, err := http.Get(fmt.Sprintf("%s/echo", hubUrl))
|
|
if err != nil || response.StatusCode != 200 {
|
|
log.Info().Msg(fmt.Sprintf(utils.Yellow, "Couldn't connect to Hub. Establishing proxy..."))
|
|
runProxy(false, true)
|
|
}
|
|
}
|
|
}
|
|
}
|