mirror of
https://github.com/kubescape/kubescape.git
synced 2026-04-06 10:46:52 +00:00
2fb4efa531
Pull Request Description: Changes Made Added a new test case TestParseSetArgs_InvalidKey in the config package to cover scenarios where an invalid key is provided in the set command arguments. Test Case Details Function Tested: TestParseSetArgs_InvalidKey Test Objective: Ensures that the parseSetArgs function correctly handles the scenario where an invalid key is provided, returning an appropriate error message. Test Input: Command arguments with an invalid key, e.g., invalidKey=value1. Expected Output: The function should return an error message indicating that the provided key is unknown, along with the list of supported keys. Motivation This new test case enhances the test coverage for the parseSetArgs function, ensuring robust handling of invalid keys during the configuration setting process. By validating that the function produces the expected error message for such cases, we contribute to the overall reliability of the codebase. This addition further strengthens the testing suite for the config package, promoting code quality and correctness. Signed-off-by: Umair <58398786+Umair0343@users.noreply.github.com>
82 lines
2.7 KiB
Go
82 lines
2.7 KiB
Go
package config
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
metav1 "github.com/kubescape/kubescape/v3/core/meta/datastructures/v1"
|
|
"github.com/kubescape/kubescape/v3/core/mocks"
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGetSetCmd(t *testing.T) {
|
|
// Create a mock Kubescape interface
|
|
mockKubescape := &mocks.MockIKubescape{}
|
|
|
|
// Call the GetConfigCmd function
|
|
configSetCmd := getSetCmd(mockKubescape)
|
|
|
|
// Verify the command name and short description
|
|
assert.Equal(t, "set", configSetCmd.Use)
|
|
assert.Equal(t, "Set configurations, supported: "+strings.Join(stringKeysToSlice(supportConfigSet), "/"), configSetCmd.Short)
|
|
assert.Equal(t, setConfigExample, configSetCmd.Example)
|
|
assert.Equal(t, stringKeysToSlice(supportConfigSet), configSetCmd.ValidArgs)
|
|
|
|
err := configSetCmd.RunE(&cobra.Command{}, []string{"accountID=value1"})
|
|
assert.Nil(t, err)
|
|
|
|
err = configSetCmd.RunE(&cobra.Command{}, []string{})
|
|
expectedErrorMessage := "key '' unknown . supported: accessKey/accountID/cloudAPIURL/cloudReportURL"
|
|
assert.Equal(t, expectedErrorMessage, err.Error())
|
|
}
|
|
|
|
// Should return a slice of keys when given a non-empty map
|
|
func TestStringKeysToSlice(t *testing.T) {
|
|
m := map[string]func(*metav1.SetConfig, string){
|
|
"key1": nil,
|
|
"key2": nil,
|
|
"key3": nil,
|
|
}
|
|
result := stringKeysToSlice(m)
|
|
expected := []string{"key1", "key2", "key3"}
|
|
assert.ElementsMatch(t, expected, result)
|
|
}
|
|
|
|
func TestParseSetArgs_InvalidFormat(t *testing.T) {
|
|
args := []string{"key"}
|
|
setConfig, err := parseSetArgs(args)
|
|
assert.Equal(t, "", setConfig.Account)
|
|
assert.Equal(t, "", setConfig.AccessKey)
|
|
assert.Equal(t, "", setConfig.CloudReportURL)
|
|
assert.Equal(t, "", setConfig.CloudAPIURL)
|
|
|
|
expectedErrorMessage := fmt.Sprintf("key '' unknown . supported: %s", strings.Join(stringKeysToSlice(supportConfigSet), "/"))
|
|
assert.Equal(t, expectedErrorMessage, err.Error())
|
|
}
|
|
|
|
func TestParseSetArgs_AccessKey(t *testing.T) {
|
|
args := []string{"accessKey", "value1"}
|
|
setConfig, _ := parseSetArgs(args)
|
|
assert.Equal(t, "", setConfig.Account)
|
|
assert.Equal(t, "value1", setConfig.AccessKey)
|
|
assert.Equal(t, "", setConfig.CloudReportURL)
|
|
assert.Equal(t, "", setConfig.CloudAPIURL)
|
|
}
|
|
|
|
func TestParseSetArgs_Single(t *testing.T) {
|
|
args := []string{"accountID=value1"}
|
|
setConfig, _ := parseSetArgs(args)
|
|
assert.Equal(t, "value1", setConfig.Account)
|
|
assert.Equal(t, "", setConfig.AccessKey)
|
|
assert.Equal(t, "", setConfig.CloudReportURL)
|
|
assert.Equal(t, "", setConfig.CloudAPIURL)
|
|
}
|
|
|
|
func TestParseSetArgs_InvalidKey(t *testing.T) {
|
|
args := []string{"invalidKey=value1"}
|
|
_, err := parseSetArgs(args)
|
|
assert.Equal(t, "key 'invalidKey' unknown . supported: accessKey/accountID/cloudAPIURL/cloudReportURL", err.Error())
|
|
}
|