From 44b74e2681a68b28ccb2a29e312f3cd18fedbc6c Mon Sep 17 00:00:00 2001 From: David Delarosa Date: Tue, 5 Oct 2021 17:28:38 +0300 Subject: [PATCH 1/3] Change workflow to use build.py script --- .github/workflows/build.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 454681c9..84fcc155 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -38,13 +38,16 @@ jobs: with: go-version: 1.16 - name: Build + uses: actions/setup-python@v2 + with: + python-version: 3.7 env: RELEASE: v1.0.${{ github.run_number }} ArmoBEServer: api.armo.cloud ArmoERServer: report.euprod1.cyberarmorsoft.com ArmoWebsite: portal.armo.cloud CGO_ENABLED: 0 - run: mkdir -p build/${{ matrix.os }} && go mod tidy && go build -ldflags "-w -s -X github.com/armosec/kubescape/cmd.BuildNumber=$RELEASE -X github.com/armosec/kubescape/cautils/getter.ArmoBEURL=$ArmoBEServer -X github.com/armosec/kubescape/cautils/getter.ArmoERURL=$ArmoERServer -X github.com/armosec/kubescape/cautils/getter.ArmoFEURL=$ArmoWebsite" -o build/${{ matrix.os }}/kubescape # && md5sum build/${{ matrix.os }}/kubescape > build/${{ matrix.os }}/kubescape.md5 + run: python3 build.py - name: Upload Release binaries id: upload-release-asset From 25b8ec82e85456c64fd23338640395f6a6f4c627 Mon Sep 17 00:00:00 2001 From: David Delarosa Date: Wed, 6 Oct 2021 10:21:29 +0300 Subject: [PATCH 2/3] Cannot use both 'uses' and 'run' --- .github/workflows/build.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 84fcc155..7b16864c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -38,16 +38,13 @@ jobs: with: go-version: 1.16 - name: Build - uses: actions/setup-python@v2 - with: - python-version: 3.7 env: RELEASE: v1.0.${{ github.run_number }} ArmoBEServer: api.armo.cloud ArmoERServer: report.euprod1.cyberarmorsoft.com ArmoWebsite: portal.armo.cloud CGO_ENABLED: 0 - run: python3 build.py + run: python build.py - name: Upload Release binaries id: upload-release-asset From 075ba4c603df98f4614de45303ca56134de5dfc2 Mon Sep 17 00:00:00 2001 From: David Delarosa Date: Wed, 6 Oct 2021 11:23:56 +0300 Subject: [PATCH 3/3] Comment out this windows exe The build workflow relay on the same binary name - so we won't change that right now. --- build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.py b/build.py index 895ae7bd..f18f0de5 100644 --- a/build.py +++ b/build.py @@ -28,7 +28,7 @@ def getBuildDir(): def getPackageName(): packageName = "kubescape" - if platform.system() == "Windows": packageName += ".exe" + # if platform.system() == "Windows": packageName += ".exe" return packageName