From a21e9d706e0ae74dead646416cf2355c664f33db Mon Sep 17 00:00:00 2001
From: Yonah Dissen <ydissen@vmware.com>
Date: Sun, 7 Nov 2021 21:23:57 +0200
Subject: [PATCH] small changes in helm chart

---
 examples/helm_chart/README.md   |  6 ++----
 examples/helm_chart/values.yaml | 21 +++++++++------------
 2 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/examples/helm_chart/README.md b/examples/helm_chart/README.md
index 92c75549..d296b88c 100644
--- a/examples/helm_chart/README.md
+++ b/examples/helm_chart/README.md
@@ -17,12 +17,10 @@ Kubescape is the first open-source tool for testing if Kubernetes is deployed se
 | nodeSelector | object | `{}` |  |
 | podAnnotations | object | `{}` |  |
 | podSecurityContext | object | `{}` |  |
-| resources | object | `{}` |  |
+| resources | object | `{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"200m","memory":"256Mi"}}` | Default resources for running the service in cluster |
 | schedule | string | `"0 0 * * *"` | Frequency of running the scan |
 | securityContext | object | `{}` |  |
-| serviceAccount.annotations | object | `{}` |  |
-| serviceAccount.create | bool | `true` |  |
-| serviceAccount.name | string | `"kubescape-discovery"` |  |
+| serviceAccount | object | `{"annotations":{},"create":true,"name":"kubescape-discovery"}` | Service account that runs the scan and has permissions to view the cluster |
 | tolerations | list | `[]` |  |
 
 ----------------------------------------------
diff --git a/examples/helm_chart/values.yaml b/examples/helm_chart/values.yaml
index 2ff587f5..c81f55ee 100644
--- a/examples/helm_chart/values.yaml
+++ b/examples/helm_chart/values.yaml
@@ -17,6 +17,7 @@ imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
+# -- Service account that runs the scan and has permissions to view the cluster
 serviceAccount:
   # Specifies whether a service account should be created
   create: true
@@ -46,18 +47,14 @@ securityContext: {}
   # runAsNonRoot: true
   # runAsUser: 1000
 
-
-resources: {}
-  # We usually recommend not to specify default resources and to leave this as a conscious
-  # choice for the user. This also increases chances charts run on environments with little
-  # resources, such as Minikube. If you do want to specify resources, uncomment the following
-  # lines, adjust them as necessary, and remove the curly braces after 'resources:'.
-  # limits:
-  #   cpu: 100m
-  #   memory: 128Mi
-  # requests:
-  #   cpu: 100m
-  #   memory: 128Mi
+# -- Default resources for running the service in cluster
+resources:
+  limits:
+    cpu: 500m
+    memory: 512Mi
+  requests:
+    cpu: 200m
+    memory: 256Mi
 
 
 nodeSelector: {}