github/kubescape
1
0
Fork 0
mirror of https://github.com/kubescape/kubescape.git synced 2026-04-15 06:58:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1497 from sulemaanhamza/bugfix-core-list-gencontrolrows

Browse Source 
Fix for Index Out of Range Error in Malformed Policies Handling
This commit is contained in:
Matthias Bertschy
2023-11-23 17:09:58 +01:00
committed by GitHub
parent 633024f8c5 bc2fc83599
commit 6fcfe7f4e5
2 changed files with 91 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/core/list.go
View File

@@ -159,8 +159,21 @@ func generateControlRows(policies []string) [][]string {
rows := [][]string{}
for _, control := range policies {
idAndControlAndFrameworks := strings.Split(control, "|")
id, control, framework := idAndControlAndFrameworks[0], idAndControlAndFrameworks[1], idAndControlAndFrameworks[2]
var id, control, framework string
switch len(idAndControlAndFrameworks) {
case 0:
continue
case 1:
id = idAndControlAndFrameworks[0]
case 2:
id, control = idAndControlAndFrameworks[0], idAndControlAndFrameworks[1]
default:
id, control, framework = idAndControlAndFrameworks[0], idAndControlAndFrameworks[1], idAndControlAndFrameworks[2]
}
docs := cautils.GetControlLink(id)

77
core/core/list_test.go
View File

@@ -201,6 +201,33 @@ func TestGenerateControlRowsWithAllFields(t *testing.T) {
assert.Equal(t, want, got)
}
// Handles policies with no '|' characters in the string
func TestGenerateControlRowsHandlesPoliciesWithEmptyStringOrNoPipesOrOnePipeMissing(t *testing.T) {
policies := []string{
"",
"1",
"2|Control 2|Framework 2",
"3|Control 3|Framework 3|Extra 3",
"4||Framework 4",
"|",
"5|Control 5||Extra 5",
}
expectedRows := [][]string{
{"", "", "https://hub.armosec.io/docs/", ""},
{"1", "", "https://hub.armosec.io/docs/1", ""},
{"2", "Control 2", "https://hub.armosec.io/docs/2", "Framework\n2"},
{"3", "Control 3", "https://hub.armosec.io/docs/3", "Framework\n3"},
{"4", "", "https://hub.armosec.io/docs/4", "Framework\n4"},
{"", "", "https://hub.armosec.io/docs/", ""},
{"5", "Control 5", "https://hub.armosec.io/docs/5", ""},
}
rows := generateControlRows(policies)
assert.Equal(t, expectedRows, rows)
}
// The function generates a table with the correct headers and rows based on the input policies.
func TestGenerateTableWithCorrectHeadersAndRows(t *testing.T) {
// Arrange
@@ -240,6 +267,56 @@ func TestGenerateTableWithCorrectHeadersAndRows(t *testing.T) {
assert.Equal(t, want, string(got))
}
func TestGenerateTableWithMalformedPoliciesAndPrettyPrintHeadersAndRows(t *testing.T) {
// Arrange
ctx := context.Background()
policies := []string{
"",
"1",
"2|Control 2|Framework 2",
"3|Control 3|Framework 3|Extra 3",
"4||Framework 4",
"|",
"5|Control 5||Extra 5",
}
// Redirect stdout to a buffer
rescueStdout := os.Stdout
r, w, _ := os.Pipe()
os.Stdout = w
prettyPrintControls(ctx, policies)
w.Close()
got, _ := io.ReadAll(r)
os.Stdout = rescueStdout
want := `┌────────────┬──────────────┬───────────────────────────────┬────────────┐
│ Control ID │ Control name │ Docs │ Frameworks │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ │ │ https://hub.armosec.io/docs/ │ │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ 1 │ │ https://hub.armosec.io/docs/1 │ │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ 2 │ Control 2 │ https://hub.armosec.io/docs/2 │ Framework │
│ │ │ │ 2 │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ 3 │ Control 3 │ https://hub.armosec.io/docs/3 │ Framework │
│ │ │ │ 3 │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ 4 │ │ https://hub.armosec.io/docs/4 │ Framework │
│ │ │ │ 4 │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ │ │ https://hub.armosec.io/docs/ │ │
├────────────┼──────────────┼───────────────────────────────┼────────────┤
│ 5 │ Control 5 │ https://hub.armosec.io/docs/5 │ │
└────────────┴──────────────┴───────────────────────────────┴────────────┘
`
assert.Equal(t, want, string(got))
}
// Returns a non-empty list of supported actions when 'ListSupportActions' is called.
func TestListSupportActionsNotEmpty(t *testing.T) {
actions := ListSupportActions()