From eeb1d8bff7788e6cda9a99c730fd4609e0c1a2c4 Mon Sep 17 00:00:00 2001 From: OmAxiani0 Date: Mon, 22 Aug 2022 22:05:43 +0530 Subject: [PATCH 1/2] Added simple PR template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..f486c8b0 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ +## Describe your changes + +## Screenshots - If Any (Optional) + +## Issue ticket number and link + +## Checklist before requesting a review +- [ ] My code follows the style guidelines of this project +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have performed a self-review of my code +- [ ] If it is a core feature, I have added thorough tests. +- [ ] New and existing unit tests pass locally with my changes From 240971172df325d3ba527c0a92ac507fe089ceac Mon Sep 17 00:00:00 2001 From: David Wertenteil Date: Tue, 23 Aug 2022 08:28:04 +0300 Subject: [PATCH 2/2] Requesting PRs should be opened against the dev branch --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f486c8b0..f357279b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,3 +10,5 @@ - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests. - [ ] New and existing unit tests pass locally with my changes + +**Please opne the PR agains the `dev` branch (Unless the PR contains only documentation changes)**