From 8a7511cecb9beb5b6e110322a17e71a036e9ca59 Mon Sep 17 00:00:00 2001 From: Vlad Klokun Date: Fri, 3 Jun 2022 19:35:33 +0300 Subject: [PATCH 01/15] chore: add maintenance message --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 65a9b6b8..4e40133a 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,8 @@ [![Go Report Card](https://goreportcard.com/badge/github.com/armosec/kubescape)](https://goreportcard.com/report/github.com/armosec/kubescape) +**WARNING: Kubescape is currently under maintenance, but we’ll be back soon. Thank you for your patience ;)** + Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer and image vulnerabilities scanning. Kubescape scans K8s clusters, YAML files, and HELM charts, detecting misconfigurations according to multiple frameworks (such as the [NSA-CISA](https://www.armosec.io/blog/kubernetes-hardening-guidance-summary-by-armo) , [MITRE ATT&CK®](https://www.microsoft.com/security/blog/2021/03/23/secure-containerized-environments-with-updated-threat-matrix-for-kubernetes/)), software vulnerabilities, and RBAC (role-based-access-control) violations at early stages of the CI/CD pipeline, calculates risk score instantly and shows risk trends over time. From 91d1ec6c2fc4eb6dd9a3249156b96ce730da128d Mon Sep 17 00:00:00 2001 From: Rotem Refael <48656234+rotemamsa@users.noreply.github.com> Date: Mon, 6 Jun 2022 13:30:22 +0300 Subject: [PATCH 02/15] Update README.md --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index 4e40133a..65a9b6b8 100644 --- a/README.md +++ b/README.md @@ -4,8 +4,6 @@ [![Go Report Card](https://goreportcard.com/badge/github.com/armosec/kubescape)](https://goreportcard.com/report/github.com/armosec/kubescape) -**WARNING: Kubescape is currently under maintenance, but we’ll be back soon. Thank you for your patience ;)** - Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer and image vulnerabilities scanning. Kubescape scans K8s clusters, YAML files, and HELM charts, detecting misconfigurations according to multiple frameworks (such as the [NSA-CISA](https://www.armosec.io/blog/kubernetes-hardening-guidance-summary-by-armo) , [MITRE ATT&CK®](https://www.microsoft.com/security/blog/2021/03/23/secure-containerized-environments-with-updated-threat-matrix-for-kubernetes/)), software vulnerabilities, and RBAC (role-based-access-control) violations at early stages of the CI/CD pipeline, calculates risk score instantly and shows risk trends over time. From 57874f399bdb53c70406135bf53dc76d1375065f Mon Sep 17 00:00:00 2001 From: Amir Malka Date: Mon, 25 Jul 2022 12:31:34 +0300 Subject: [PATCH 03/15] Update Makefile To support the new build process in homebrew, we are not using the submodules, hence, adding a dash to ignore an error when git submodule command fails --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1fd42de0..f45b5953 100644 --- a/Makefile +++ b/Makefile @@ -7,7 +7,7 @@ export CGO_ENABLED=1 # build and install libgit2 libgit2: - git submodule update --init --recursive + -git submodule update --init --recursive cd git2go; make install-static # go build tags From c8c3ab76d67f0885dc4c935e8a3e2e72415f8fd2 Mon Sep 17 00:00:00 2001 From: vladklokun Date: Mon, 22 Aug 2022 17:19:45 +0300 Subject: [PATCH 04/15] Add a feature request template --- .github/ISSUE_TEMPLATE/feature_request.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..bbcbbe7d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 22e1e8a82f4ad665a508bf5250291d1a0b85b420 Mon Sep 17 00:00:00 2001 From: vladklokun Date: Mon, 22 Aug 2022 17:28:56 +0300 Subject: [PATCH 05/15] chore: Add a Bug Report issue template --- .github/ISSUE_TEMPLATE/bug_report.md | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..d1587865 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,34 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +# Describe the bug +A clear and concise description of what the bug is. + +# Environment +OS: the OS + version you’re running Kubescape on, e.g Ubuntu 22.04 LTS +Version: the version that Kubescape reports when you run `kubescape version` +``` +Your current version is: +``` + +# Steps To Reproduce +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +# Expected behavior +A clear and concise description of what you expected to happen. + +# Actual Behavior +A clear and concise description of what happened. If applicable, add screenshots to help explain your problem. + +# Additional context +Add any other context about the problem here. From 52c2b4e85423fdea24d84115421b102294320bff Mon Sep 17 00:00:00 2001 From: Prajapati omkar <72141037+prajapatiomkar@users.noreply.github.com> Date: Mon, 22 Aug 2022 20:53:31 +0530 Subject: [PATCH 06/15] Made changes in Readme file by adding discord link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index aa355e3a..ae5cec78 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Want to contribute? Want to discuss something? Have an issue? * Feel free to pick a task from the [roadmap](docs/roadmap.md) or suggest a feature of your own. [Contact us](MAINTAINERS.md) directly for more information :) * Open a issue, we are trying to respond within 48 hours -* [Join us](https://armosec.github.io/kubescape) in a discussion on our discord server! +* [Join us](https://discord.com/invite/WKZRaCtBxN) in a discussion on our discord server! [logo](https://armosec.github.io/kubescape/) ![discord](https://img.shields.io/discord/893048809884643379) From 307b7be28d67dffe3d4012374d7c6fb343eed086 Mon Sep 17 00:00:00 2001 From: NirmitSawant Date: Mon, 22 Aug 2022 21:06:26 +0530 Subject: [PATCH 07/15] Updated the correct link on the discord button --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ae5cec78..cd6ed45f 100644 --- a/README.md +++ b/README.md @@ -68,7 +68,7 @@ Want to contribute? Want to discuss something? Have an issue? * Open a issue, we are trying to respond within 48 hours * [Join us](https://discord.com/invite/WKZRaCtBxN) in a discussion on our discord server! -[logo](https://armosec.github.io/kubescape/) +[logo](https://discord.com/invite/WKZRaCtBxN) ![discord](https://img.shields.io/discord/893048809884643379) From eeb1d8bff7788e6cda9a99c730fd4609e0c1a2c4 Mon Sep 17 00:00:00 2001 From: OmAxiani0 Date: Mon, 22 Aug 2022 22:05:43 +0530 Subject: [PATCH 08/15] Added simple PR template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..f486c8b0 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ +## Describe your changes + +## Screenshots - If Any (Optional) + +## Issue ticket number and link + +## Checklist before requesting a review +- [ ] My code follows the style guidelines of this project +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have performed a self-review of my code +- [ ] If it is a core feature, I have added thorough tests. +- [ ] New and existing unit tests pass locally with my changes From 7a51b461781da495ffd50d6c2a7bbf9c85b8eeb0 Mon Sep 17 00:00:00 2001 From: Yash Hegde <120CH0007@nitrkl.ac.in> Date: Tue, 23 Aug 2022 00:29:18 +0530 Subject: [PATCH 09/15] Correction of grammatical errors --- README.md | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index cd6ed45f..27adce48 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer and image vulnerabilities scanning. Kubescape scans K8s clusters, YAML files, and HELM charts, detecting misconfigurations according to multiple frameworks (such as the [NSA-CISA](https://www.armosec.io/blog/kubernetes-hardening-guidance-summary-by-armo/?utm_source=github&utm_medium=repository), [MITRE ATT&CK®](https://www.microsoft.com/security/blog/2021/03/23/secure-containerized-environments-with-updated-threat-matrix-for-kubernetes/)), software vulnerabilities, and RBAC (role-based-access-control) violations at early stages of the CI/CD pipeline, calculates risk score instantly and shows risk trends over time. -It became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins’ precious time, effort, and resources. +It has became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins’ precious time, effort, and resources. Kubescape integrates natively with other DevOps tools, including Jenkins, CircleCI, Github workflows, Prometheus, and Slack, and supports multi-cloud K8s deployments like EKS, GKE, and AKS.
@@ -49,7 +49,7 @@ kubescape scan --submit --enable-host-scan --verbose
-> Kubescape is an open source project, we welcome your feedback and ideas for improvement. We’re also aiming to collaborate with the Kubernetes community to help make the tests themselves more robust and complete as Kubernetes develops. +> Kubescape is an open source project. We welcome your feedback and ideas for improvement. We’re also aiming to collaborate with the Kubernetes community to help make the tests more robust and complete as Kubernetes develops.
@@ -58,15 +58,15 @@ kubescape scan --submit --enable-host-scan --verbose
-# Being part of the team +# Being a part of the team We invite you to our team! We are excited about this project and want to return the love we get. Want to contribute? Want to discuss something? Have an issue? * Feel free to pick a task from the [roadmap](docs/roadmap.md) or suggest a feature of your own. [Contact us](MAINTAINERS.md) directly for more information :) -* Open a issue, we are trying to respond within 48 hours -* [Join us](https://discord.com/invite/WKZRaCtBxN) in a discussion on our discord server! +* Open an issue, we are trying to respond within 48 hours +* [Join us](https://discord.com/invite/WKZRaCtBxN) in the discussion on our discord server! [logo](https://discord.com/invite/WKZRaCtBxN) ![discord](https://img.shields.io/discord/893048809884643379) @@ -203,7 +203,7 @@ kubescape scan *.yaml --submit kubescape scan https://github.com/armosec/kubescape --submit ``` -#### Display all scanned resources (including the resources who passed) +#### Display all scanned resources (including the resources which passed) ``` kubescape scan --verbose ``` @@ -243,7 +243,7 @@ kubescape scan --exceptions examples/exceptions/exclude-kube-namespaces.json ``` kubescape scan --submit ``` -> Kubescape will load the default values file +> Kubescape will load the default value file ### Offline/Air-gaped Environment Support @@ -263,11 +263,11 @@ kubescape download artifacts --output path/to/local/dir kubescape scan --use-artifacts-from path/to/local/dir ``` -#### Download a single artifacts +#### Download a single artifact -You can also download a single artifacts and scan with the `--use-from` flag +You can also download a single artifact and scan with the `--use-from` flag -1. Download and save in file, if file name not specified, will save in `~/.kubescape/.json` +1. Download and save in file, if file name is not specified, will save in `~/.kubescape/.json` ``` kubescape download framework nsa --output /path/nsa.json ``` @@ -402,13 +402,13 @@ You can use the samples files below to setup your VS code environment for buildi # Under the hood ## Technology -Kubescape based on [OPA engine](https://github.com/open-policy-agent/opa) and ARMO's posture controls. +Kubescape is based on [OPA engine](https://github.com/open-policy-agent/opa) and ARMO's posture controls. -The tools retrieves Kubernetes objects from the API server and runs a set of [rego's snippets](https://www.openpolicyagent.org/docs/latest/policy-language/) developed by [ARMO](https://www.armosec.io?utm_source=github&utm_medium=repository). +The tools retrieve Kubernetes objects from the API server and run a set of [rego's snippets](https://www.openpolicyagent.org/docs/latest/policy-language/) developed by [ARMO](https://www.armosec.io?utm_source=github&utm_medium=repository). -The results by default printed in a pretty "console friendly" manner, but they can be retrieved in JSON format for further processing. +The results by default are printed in a pretty "console friendly" manner, but they can be retrieved in JSON format for further processing. -Kubescape is an open source project, we welcome your feedback and ideas for improvement. We’re also aiming to collaborate with the Kubernetes community to help make the tests themselves more robust and complete as Kubernetes develops. +Kubescape is an open source project, we welcome your feedback and ideas for improvement. We’re also aiming to collaborate with the Kubernetes community to help make the tests more robust and complete as Kubernetes develops. ## Thanks to all the contributors ❤️ From 4b96ce4a542f92424f02b2f7148eb063680809e5 Mon Sep 17 00:00:00 2001 From: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Date: Tue, 23 Aug 2022 02:36:21 +0530 Subject: [PATCH 10/15] Update README.md --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 27adce48..c4e8e678 100644 --- a/README.md +++ b/README.md @@ -5,9 +5,9 @@ -Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer and image vulnerabilities scanning. +Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer, and image vulnerabilities scanning. Kubescape scans K8s clusters, YAML files, and HELM charts, detecting misconfigurations according to multiple frameworks (such as the [NSA-CISA](https://www.armosec.io/blog/kubernetes-hardening-guidance-summary-by-armo/?utm_source=github&utm_medium=repository), [MITRE ATT&CK®](https://www.microsoft.com/security/blog/2021/03/23/secure-containerized-environments-with-updated-threat-matrix-for-kubernetes/)), software vulnerabilities, and RBAC (role-based-access-control) violations at early stages of the CI/CD pipeline, calculates risk score instantly and shows risk trends over time. -It has became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins’ precious time, effort, and resources. +It became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins precious time, effort, and resources. Kubescape integrates natively with other DevOps tools, including Jenkins, CircleCI, Github workflows, Prometheus, and Slack, and supports multi-cloud K8s deployments like EKS, GKE, and AKS.
@@ -87,7 +87,7 @@ Want to contribute? Want to discuss something? Have an issue? * [Scan Kubescape on an air-gapped environment (offline support)](https://youtu.be/IGXL9s37smM) * [Managing exceptions in the Kubescape SaaS version](https://youtu.be/OzpvxGmCR80) * [Configure and run customized frameworks](https://youtu.be/12Sanq_rEhs) -* Customize controls configurations. [Kubescape CLI](https://youtu.be/955psg6TVu4), [Kubescape SaaS](https://youtu.be/lIMVSVhH33o) +* Customize control configurations. [Kubescape CLI](https://youtu.be/955psg6TVu4), [Kubescape SaaS](https://youtu.be/lIMVSVhH33o)
Windows @@ -357,7 +357,7 @@ View Kubescape scan results directly in [Lens IDE](https://k8slens.dev/) using k ## VS code configuration samples -You can use the samples files below to setup your VS code environment for building and debugging purposes. +You can use the sample files below to setup your VS code environment for building and debugging purposes.
.vscode/settings.json @@ -402,7 +402,7 @@ You can use the samples files below to setup your VS code environment for buildi # Under the hood ## Technology -Kubescape is based on [OPA engine](https://github.com/open-policy-agent/opa) and ARMO's posture controls. +Kubescape is based on the [OPA engine](https://github.com/open-policy-agent/opa) and ARMO's posture controls. The tools retrieve Kubernetes objects from the API server and run a set of [rego's snippets](https://www.openpolicyagent.org/docs/latest/policy-language/) developed by [ARMO](https://www.armosec.io?utm_source=github&utm_medium=repository). From 12619f4f3b0339763de50d8a9cffb952c06af832 Mon Sep 17 00:00:00 2001 From: David Wertenteil Date: Tue, 23 Aug 2022 08:19:01 +0300 Subject: [PATCH 11/15] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c4e8e678..a2a04a6a 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer, and image vulnerabilities scanning. Kubescape scans K8s clusters, YAML files, and HELM charts, detecting misconfigurations according to multiple frameworks (such as the [NSA-CISA](https://www.armosec.io/blog/kubernetes-hardening-guidance-summary-by-armo/?utm_source=github&utm_medium=repository), [MITRE ATT&CK®](https://www.microsoft.com/security/blog/2021/03/23/secure-containerized-environments-with-updated-threat-matrix-for-kubernetes/)), software vulnerabilities, and RBAC (role-based-access-control) violations at early stages of the CI/CD pipeline, calculates risk score instantly and shows risk trends over time. -It became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins precious time, effort, and resources. +It has became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins precious time, effort, and resources. Kubescape integrates natively with other DevOps tools, including Jenkins, CircleCI, Github workflows, Prometheus, and Slack, and supports multi-cloud K8s deployments like EKS, GKE, and AKS.
From cf6ae51f76b95e548b2c01e8084ab0498aa82fc1 Mon Sep 17 00:00:00 2001 From: David Wertenteil Date: Tue, 23 Aug 2022 08:20:15 +0300 Subject: [PATCH 12/15] Update README.md --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index a2a04a6a..57b46f33 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,8 @@ Kubescape is a K8s open-source tool providing a multi-cloud K8s single pane of glass, including risk analysis, security compliance, RBAC visualizer, and image vulnerabilities scanning. Kubescape scans K8s clusters, YAML files, and HELM charts, detecting misconfigurations according to multiple frameworks (such as the [NSA-CISA](https://www.armosec.io/blog/kubernetes-hardening-guidance-summary-by-armo/?utm_source=github&utm_medium=repository), [MITRE ATT&CK®](https://www.microsoft.com/security/blog/2021/03/23/secure-containerized-environments-with-updated-threat-matrix-for-kubernetes/)), software vulnerabilities, and RBAC (role-based-access-control) violations at early stages of the CI/CD pipeline, calculates risk score instantly and shows risk trends over time. -It has became one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins precious time, effort, and resources. + +It has become one of the fastest-growing Kubernetes tools among developers due to its easy-to-use CLI interface, flexible output formats, and automated scanning capabilities, saving Kubernetes users and admins precious time, effort, and resources. Kubescape integrates natively with other DevOps tools, including Jenkins, CircleCI, Github workflows, Prometheus, and Slack, and supports multi-cloud K8s deployments like EKS, GKE, and AKS.
From 240971172df325d3ba527c0a92ac507fe089ceac Mon Sep 17 00:00:00 2001 From: David Wertenteil Date: Tue, 23 Aug 2022 08:28:04 +0300 Subject: [PATCH 13/15] Requesting PRs should be opened against the dev branch --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f486c8b0..f357279b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,3 +10,5 @@ - [ ] I have performed a self-review of my code - [ ] If it is a core feature, I have added thorough tests. - [ ] New and existing unit tests pass locally with my changes + +**Please opne the PR agains the `dev` branch (Unless the PR contains only documentation changes)** From b2763b1f4f16d1d59ae4c7420471584fafd66a7d Mon Sep 17 00:00:00 2001 From: Saptarshi Sarkar Date: Tue, 23 Aug 2022 15:54:22 +0530 Subject: [PATCH 14/15] Fixed typo --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f357279b..8d977ebe 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,4 +11,4 @@ - [ ] If it is a core feature, I have added thorough tests. - [ ] New and existing unit tests pass locally with my changes -**Please opne the PR agains the `dev` branch (Unless the PR contains only documentation changes)** +**Please open the PR agains the `dev` branch (Unless the PR contains only documentation changes)** From 4becfc6b885caf49c785d033a8aff9c9c9ee50b2 Mon Sep 17 00:00:00 2001 From: David Wertenteil Date: Tue, 23 Aug 2022 13:28:40 +0300 Subject: [PATCH 15/15] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8d977ebe..b2d8493c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,4 +11,4 @@ - [ ] If it is a core feature, I have added thorough tests. - [ ] New and existing unit tests pass locally with my changes -**Please open the PR agains the `dev` branch (Unless the PR contains only documentation changes)** +**Please open the PR against the `dev` branch (Unless the PR contains only documentation changes)**