From 562b998ca7fcd5bd2671f9d7d0e935b949f0cdbf Mon Sep 17 00:00:00 2001 From: Hidetake Iwata Date: Sun, 12 Jan 2025 15:17:47 +0900 Subject: [PATCH] Add `[SECURITY RISK]` to insecure flag description (#1237) --- docs/usage.md | 2 +- pkg/cmd/tls.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/usage.md b/docs/usage.md index c0112974..1045e61d 100644 --- a/docs/usage.md +++ b/docs/usage.md @@ -18,7 +18,7 @@ Flags: --token-cache-storage string Storage for the token cache. One of (auto|keyring|disk) (default "auto") --certificate-authority stringArray Path to a cert file for the certificate authority --certificate-authority-data stringArray Base64 encoded cert for the certificate authority - --insecure-skip-tls-verify If set, the server's certificate will not be checked for validity. This will make your HTTPS connections insecure + --insecure-skip-tls-verify [SECURITY RISK] If set, the server's certificate will not be checked for validity --tls-renegotiation-once If set, allow a remote server to request renegotiation once per connection --tls-renegotiation-freely If set, allow a remote server to repeatedly request renegotiation --grant-type string Authorization grant type to use. One of (auto|authcode|authcode-keyboard|password|device-code) (default "auto") diff --git a/pkg/cmd/tls.go b/pkg/cmd/tls.go index 7ab6e49c..6b20bfa5 100644 --- a/pkg/cmd/tls.go +++ b/pkg/cmd/tls.go @@ -18,7 +18,7 @@ type tlsOptions struct { func (o *tlsOptions) addFlags(f *pflag.FlagSet) { f.StringArrayVar(&o.CACertFilename, "certificate-authority", nil, "Path to a cert file for the certificate authority") f.StringArrayVar(&o.CACertData, "certificate-authority-data", nil, "Base64 encoded cert for the certificate authority") - f.BoolVar(&o.SkipTLSVerify, "insecure-skip-tls-verify", false, "If set, the server's certificate will not be checked for validity. This will make your HTTPS connections insecure") + f.BoolVar(&o.SkipTLSVerify, "insecure-skip-tls-verify", false, "[SECURITY RISK] If set, the server's certificate will not be checked for validity") f.BoolVar(&o.RenegotiateOnceAsClient, "tls-renegotiation-once", false, "If set, allow a remote server to request renegotiation once per connection") f.BoolVar(&o.RenegotiateFreelyAsClient, "tls-renegotiation-freely", false, "If set, allow a remote server to repeatedly request renegotiation") }