The bare except clause in the Kubernetes client initialization block
caused a NameError crash when initialization failed. If KrknKubernetes()
raised an exception before kubecli was assigned, the except handler
attempted to call kubecli.initialize_clients(None) on an undefined
variable, masking the original error entirely.
Replaced the bare except with except Exception as e to:
- Log the actual initialization error for visibility
- Initialize both kubecli and ocpcli with None kubeconfig as fallback
so subsequent code referencing these variables does not crash
- Avoid catching SystemExit and KeyboardInterrupt unintentionally
Fixes#1264
Signed-off-by: Parth Agrawal <parth.agrawal4002@gmail.com>
Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com>
collect_cluster_metadata runs unconditionally after every scenario,
even when telemetry.enabled is false. On large OpenShift clusters
(e.g. ROSA with many namespaces), this takes up to 15 minutes
listing all Pods, Secrets, ConfigMaps, Routes, Builds, and nodes.
Guard the call with a telemetry.enabled check (default: true) so
base runs still collect metadata but users can opt out by setting
telemetry.enabled: false in their config.
Signed-off-by: Elijah DeLee <kdelee@redhat.com>
Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com>
- Fix typo 'wating' -> 'waiting' in scenario wait log message
- Replace print() with logging.debug() for pod metrics in prometheus client
- Replace star import with explicit imports in utils/__init__.py
- Remove unnecessary global declaration in main()
- Log VM status exceptions at ERROR level with exception details
Include unit tests in tests/test_logging_and_code_quality.py covering all fixes.
Signed-off-by: 1PoPTRoN <vrxn.arp1traj@gmail.com>
Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com>
Functional & Unit Tests / Functional & Unit Tests (push) Failing after 9m18s
Functional & Unit Tests / Generate Coverage Badge (push) Has been skipped
* Add rollback config
* Inject rollback handler to scenario plugin
* Add Serializer
* Add decorator
* Add test with SimpleRollbackScenarioPlugin
* Add logger for verbose debug flow
* Resolve review comment
- remove additional rollback config in config.yaml
- set KUBECONFIG to ~/.kube/config in test_rollback
* Simplify set_rollback_context_decorator
* Fix integration of rollback_handler in __load_plugins
* Refactor rollback.config module
- make it singleton class with register method to construct
- RollbackContext ( <timestamp>-<run_uuid> )
- add get_rollback_versions_directory for moduling the directory
format
* Adapt new rollback.config
* Refactor serialization
- respect rollback_callable_name
- refactor _parse_rollback_callable_code
- refine VERSION_FILE_TEMPLATE
* Add get_scenario_rollback_versions_directory in RollbackConfig
* Add rollback in ApplicationOutageScenarioPlugin
* Add RollbackCallable and RollbackContent for type annotation
* Refactor rollback_handler with limited arguments
* Refactor the serialization for rollback
- limited arguments: callback and rollback_content just these two!
- always constuct lib_openshift and lib_telemetry in version file
- add _parse_rollback_content_definition for retrieving scenaio specific
rollback_content
- remove utils for formating variadic function
* Refactor applicaton outage scenario
* Fix test_rollback
* Make RollbackContent with static fields
* simplify serialization
- Remove all unused format dynamic arguments utils
- Add jinja template for version file
- Replace set_context for serialization with passing version to serialize_callable
* Add rollback for hogs scenario
* Fix version file full path based on feedback
- {versions_directory}/<timestamp(ns)>-<run_uuid>/{scenario_type}-<timestamp(ns)>-<random_hash>.py
* Fix scenario plugins after rebase
* Add rollback config
* Inject rollback handler to scenario plugin
* Add test with SimpleRollbackScenarioPlugin
* Resolve review comment
- remove additional rollback config in config.yaml
- set KUBECONFIG to ~/.kube/config in test_rollback
* Fix integration of rollback_handler in __load_plugins
* Refactor rollback.config module
- make it singleton class with register method to construct
- RollbackContext ( <timestamp>-<run_uuid> )
- add get_rollback_versions_directory for moduling the directory
format
* Adapt new rollback.config
* Add rollback in ApplicationOutageScenarioPlugin
* Add RollbackCallable and RollbackContent for type annotation
* Refactor applicaton outage scenario
* Fix test_rollback
* Make RollbackContent with static fields
* simplify serialization
- Remove all unused format dynamic arguments utils
- Add jinja template for version file
- Replace set_context for serialization with passing version to serialize_callable
* Add rollback for hogs scenario
* Fix version file full path based on feedback
- {versions_directory}/<timestamp(ns)>-<run_uuid>/{scenario_type}-<timestamp(ns)>-<random_hash>.py
* Fix scenario plugins after rebase
* Add execute rollback
* Add CLI for list and execute rollback
* Replace subprocess with importlib
* Fix error after rebase
* fixup! Fix docstring
- Add telemetry_ocp in execute_rollback docstring
- Remove rollback_config in create_plugin docstring
- Remove scenario_types in set_rollback_callable docsting
* fixup! Replace os.urandom with krkn_lib.utils.get_random_string
* fixup! Add missing telemetry_ocp for execute_rollback_version_files
* fixup! Remove redundant import
- Remove duplicate TYPE_CHECKING in handler module
- Remove cast in signal module
- Remove RollbackConfig in scenario_plugin_factory
* fixup! Replace sys.exit(1) with return
* fixup! Remove duplicate rollback_network_policy
* fixup! Decouple Serializer initialization
* fixup! Rename callback to rollback_callable
* fixup! Refine comment for constructing AbstractScenarioPlugin with
placeholder value
* fixup! Add version in docstring
* fixup! Remove uv.lock
* Hog scenario porting from arcaflow to native (#748)
* added new native hog scenario
* removed arcaflow dependency + legacy hog scenarios
* config update
* changed hog configuration structure + added average samples
* fix on cpu count
* removes tripledes warning
* changed selector format
* changed selector syntax
* number of nodes option
* documentation
* functional tests
* exception handling on hog deployment thread
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Hog scenario porting from arcaflow to native (#748)
* added new native hog scenario
* removed arcaflow dependency + legacy hog scenarios
* config update
* changed hog configuration structure + added average samples
* fix on cpu count
* removes tripledes warning
* changed selector format
* changed selector syntax
* number of nodes option
* documentation
* functional tests
* exception handling on hog deployment thread
Signed-off-by: Paige Patton <prubenda@redhat.com>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* adding vsphere updates to non native
Signed-off-by: Paige Patton <prubenda@redhat.com>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* adding node id to affected node
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Fixed the spelling mistake
Signed-off-by: Meghana Katta <mkatta@mkatta-thinkpadt14gen4.bengluru.csb>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* adding v4.0.8 version (#756)
Signed-off-by: Paige Patton <prubenda@redhat.com>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Add autodetecting distribution (#753)
Used is_openshift function from krkn lib
Remove distribution from config
Remove distribution from documentation
Signed-off-by: jtydlack <139967002+jtydlack@users.noreply.github.com>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes include health check doc and exit_on_failure config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes include health check doc and exit_on_failure config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Added the health check config in functional test config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Modified the health checks documentation
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for debugging the functional test failing
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* changed the code for debugging in run_test.sh
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removed the functional test running line
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removing the health check config in common_test_config for debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Fixing functional test fialure
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removing the changes that are added for debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* few modifications
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Renamed timestamp
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changed the start timestamp and end timestamp data type to the datetime
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes include health check doc and exit_on_failure config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Hog scenario porting from arcaflow to native (#748)
* added new native hog scenario
* removed arcaflow dependency + legacy hog scenarios
* config update
* changed hog configuration structure + added average samples
* fix on cpu count
* removes tripledes warning
* changed selector format
* changed selector syntax
* number of nodes option
* documentation
* functional tests
* exception handling on hog deployment thread
Signed-off-by: Paige Patton <prubenda@redhat.com>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* adding node id to affected node
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes include health check doc and exit_on_failure config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Added the health check config in functional test config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Modified the health checks documentation
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for debugging the functional test failing
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* changed the code for debugging in run_test.sh
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removed the functional test running line
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removing the health check config in common_test_config for debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Fixing functional test fialure
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removing the changes that are added for debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* few modifications
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Renamed timestamp
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Hog scenario porting from arcaflow to native (#748)
* added new native hog scenario
* removed arcaflow dependency + legacy hog scenarios
* config update
* changed hog configuration structure + added average samples
* fix on cpu count
* removes tripledes warning
* changed selector format
* changed selector syntax
* number of nodes option
* documentation
* functional tests
* exception handling on hog deployment thread
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Hog scenario porting from arcaflow to native (#748)
* added new native hog scenario
* removed arcaflow dependency + legacy hog scenarios
* config update
* changed hog configuration structure + added average samples
* fix on cpu count
* removes tripledes warning
* changed selector format
* changed selector syntax
* number of nodes option
* documentation
* functional tests
* exception handling on hog deployment thread
Signed-off-by: Paige Patton <prubenda@redhat.com>
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* adding node id to affected node
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes include health check doc and exit_on_failure config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* initial version of health checks
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for appending success response and health check config format
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Update config.yaml
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Added the health check config in functional test config
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changes for debugging the functional test failing
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* changed the code for debugging in run_test.sh
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removed the functional test running line
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removing the health check config in common_test_config for debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Fixing functional test fialure
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Removing the changes that are added for debugging
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* few modifications
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Renamed timestamp
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* passing the health check response as HealthCheck object
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Updated the krkn-lib version in requirements.txt
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
* Changed the coverage
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
---------
Signed-off-by: kattameghana <meghanakatta8@gmail.com>
Signed-off-by: Paige Patton <prubenda@redhat.com>
Signed-off-by: Meghana Katta <mkatta@mkatta-thinkpadt14gen4.bengluru.csb>
Signed-off-by: jtydlack <139967002+jtydlack@users.noreply.github.com>
Co-authored-by: Tullio Sebastiani <tsebastiani@users.noreply.github.com>
Co-authored-by: Paige Patton <prubenda@redhat.com>
Co-authored-by: Meghana Katta <mkatta@mkatta-thinkpadt14gen4.bengluru.csb>
Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com>
Co-authored-by: jtydlack <139967002+jtydlack@users.noreply.github.com>
Functional & Unit Tests / Functional & Unit Tests (push) Failing after 9m12s
Functional & Unit Tests / Generate Coverage Badge (push) Has been skipped
Used is_openshift function from krkn lib
Remove distribution from config
Remove distribution from documentation
Signed-off-by: jtydlack <139967002+jtydlack@users.noreply.github.com>
This is needed for the TRT/component readiness integration to improve
dashboard readability and tie results back to chaos.
Signed-off-by: Naga Ravi Chaitanya Elluri <nelluri@redhat.com>
* adding elastic set to none
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Auto User <auto@users.noreply.github.com>
* too many ls
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
---------
Signed-off-by: Auto User <auto@users.noreply.github.com>
Co-authored-by: Auto User <auto@users.noreply.github.com>
This covers use case where user wants to just check for critical alerts
post chaos without having to enable the alerts evaluation feature which
evaluates prom queries specified in an alerts file.
Signed-off-by: Naga Ravi Chaitanya Elluri <nelluri@redhat.com>
* taking out start and end time"
Signed-off-by: Paige Rubendall <prubenda@redhat.com>
* adding only break when alert fires
Signed-off-by: Paige Rubendall <prubenda@redhat.com>
* fail at end if alert had fired
Signed-off-by: Paige Rubendall <prubenda@redhat.com>
* adding new krkn-lib function with no range
Signed-off-by: Paige Rubendall <prubenda@redhat.com>
* updating requirements to new krkn-lib
Signed-off-by: Paige Rubendall <prubenda@redhat.com>
---------
Signed-off-by: Paige Rubendall <prubenda@redhat.com>
Naga Ravi Chaitanya Elluri
Parth AgrawalandPaige Patton
Arpit RajandPaige Patton
Elijah DeLeeandPaige Patton
Nitesh KumarandNitesh
Darshan Jain
Paige Patton
LIU ZHE YOU
