From c0cf47dfed57c19c7c602503b0294775e4cc274e Mon Sep 17 00:00:00 2001 From: Parth Agrawal <94750839+parth-agrawall@users.noreply.github.com> Date: Thu, 28 May 2026 23:38:21 +0530 Subject: [PATCH] fix: replace bare except with Exception handler in Kubernetes client init (#1265) The bare except clause in the Kubernetes client initialization block caused a NameError crash when initialization failed. If KrknKubernetes() raised an exception before kubecli was assigned, the except handler attempted to call kubecli.initialize_clients(None) on an undefined variable, masking the original error entirely. Replaced the bare except with except Exception as e to: - Log the actual initialization error for visibility - Initialize both kubecli and ocpcli with None kubeconfig as fallback so subsequent code referencing these variables does not crash - Avoid catching SystemExit and KeyboardInterrupt unintentionally Fixes #1264 Signed-off-by: Parth Agrawal Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com> --- run_kraken.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/run_kraken.py b/run_kraken.py index d266b9eb..58f2a4cc 100644 --- a/run_kraken.py +++ b/run_kraken.py @@ -223,8 +223,10 @@ def main(options, command: Optional[str]) -> int: # krkn-lib-kubernetes init kubecli = KrknKubernetes(kubeconfig_path=kubeconfig_path) ocpcli = KrknOpenshift(kubeconfig_path=kubeconfig_path) - except: - kubecli.initialize_clients(None) + except Exception as e: + logging.error("Failed to initialize Kubernetes clients: %s" % e) + kubecli = KrknKubernetes(kubeconfig_path=None) + ocpcli = KrknOpenshift(kubeconfig_path=None) distribution = "kubernetes" if ocpcli.is_openshift():