github/krkn
1
0
Fork 0
mirror of https://github.com/krkn-chaos/krkn.git synced 2026-08-25 09:27:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve logging clarity , reduce noise, fix log levels, and reword misleading messages (#1562)

Browse Source 
* fix: improve logging clarity — reduce noise, fix log levels, and reword misleading messages

- Move per-directory rollback WARNING to DEBUG; add single INFO summary
- Change "No rollback context directories found" from WARNING to DEBUG
- Change "Skip cleanup/execution" from WARNING to DEBUG
- Fix misleading Cerberus "still failing" message: early-return when
  disabled, use correct log levels, remove inaccurate wording
- Change "No error logs collected" from INFO to DEBUG
- Reword "Detected distribution" to "Detected cluster platform"
- Reword OCP metadata collection log for clarity

Closes #1559

Signed-off-by: ddjain <darjain@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: ddjain <darjain@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: address review comments — fix tests, reword log messages

- Add cerberus_enabled = True to 4 publish_kraken_status tests broken
  by early-return guard
- Add new test for cerberus_disabled early-return path
- Reword rollback skip summary to neutral wording
- Remove capitalize() from platform detection log

Signed-off-by: ddjain <darjain@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Signed-off-by: ddjain <darjain@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Darshan Jain
2026-08-14 09:45:55 -04:00
committed by GitHub
co-authored by Cursor
parent 7658a6b871
commit 51f41e3595
5 changed files with 38 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_cerberus_setup.py
+13
View File
@@ -160,9 +160,19 @@ class TestCerberusSetup(unittest.TestCase):
self.assertEqual(cm.exception.code, 1)
@patch('krkn.cerberus.setup.get_status')
def test_publish_kraken_status_cerberus_disabled_skips(self, mock_get_status):
"""Test publish_kraken_status returns immediately when cerberus is disabled"""
cerberus_setup.cerberus_enabled = False
cerberus_setup.publish_kraken_status(0, 100)
mock_get_status.assert_not_called()
@patch('krkn.cerberus.setup.get_status')
def test_publish_kraken_status_healthy_exit_on_failure_false(self, mock_get_status):
"""Test publish_kraken_status when cluster is healthy and exit_on_failure is False"""
cerberus_setup.cerberus_enabled = True
cerberus_setup.exit_on_failure = False
mock_get_status.return_value = True
@@ -173,6 +183,7 @@ class TestCerberusSetup(unittest.TestCase):
@patch('krkn.cerberus.setup.get_status')
def test_publish_kraken_status_healthy_exit_on_failure_true(self, mock_get_status):
"""Test publish_kraken_status when cluster is healthy and exit_on_failure is True"""
cerberus_setup.cerberus_enabled = True
cerberus_setup.exit_on_failure = True
mock_get_status.return_value = True
@@ -185,6 +196,7 @@ class TestCerberusSetup(unittest.TestCase):
@patch('krkn.cerberus.setup.get_status')
def test_publish_kraken_status_unhealthy_exit_on_failure_false(self, mock_get_status):
"""Test publish_kraken_status when cluster is unhealthy and exit_on_failure is False"""
cerberus_setup.cerberus_enabled = True
cerberus_setup.exit_on_failure = False
mock_get_status.return_value = False
@@ -195,6 +207,7 @@ class TestCerberusSetup(unittest.TestCase):
@patch('krkn.cerberus.setup.get_status')
def test_publish_kraken_status_unhealthy_exit_on_failure_true(self, mock_get_status):
"""Test publish_kraken_status when cluster is unhealthy and exit_on_failure is True"""
cerberus_setup.cerberus_enabled = True
cerberus_setup.exit_on_failure = True
mock_get_status.return_value = False