From 9a5909a4abd296fc3424efb33d7c38f9d6b55dcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Tue, 13 Feb 2018 22:52:43 +0000 Subject: [PATCH 1/2] Log Alertmanager version used for testing There's ever growing list of tested Alertmanager releases, print version so it's more obvious what do we actually test against --- api_test.go | 1 + views_test.go | 3 +++ 2 files changed, 4 insertions(+) diff --git a/api_test.go b/api_test.go index dd7b0455a..0b3f70c78 100644 --- a/api_test.go +++ b/api_test.go @@ -931,6 +931,7 @@ func testAlertGroup(version string, t *testing.T, testCase groupTest, group mode func TestVerifyAllGroups(t *testing.T) { mockConfig() for _, version := range mock.ListAllMocks() { + t.Logf("Testing API using mock files from Alertmanager %s", version) mockAlerts(version) r := ginTestEngine() req, _ := http.NewRequest("GET", "/alerts.json", nil) diff --git a/views_test.go b/views_test.go index 4b8990536..a371447e2 100644 --- a/views_test.go +++ b/views_test.go @@ -117,6 +117,7 @@ func mockAlerts(version string) { func TestAlerts(t *testing.T) { mockConfig() for _, version := range mock.ListAllMocks() { + t.Logf("Testing alerts using mock files from Alertmanager %s", version) mockAlerts(version) r := ginTestEngine() req, _ := http.NewRequest("GET", "/alerts.json?q=@receiver=by-cluster-service,alertname=HTTP_Probe_Failed,instance=web1", nil) @@ -183,6 +184,7 @@ func TestAlerts(t *testing.T) { func TestValidateAllAlerts(t *testing.T) { mockConfig() for _, version := range mock.ListAllMocks() { + t.Logf("Validating alerts.json response using mock files from Alertmanager %s", version) mockAlerts(version) r := ginTestEngine() req, _ := http.NewRequest("GET", "/alerts.json?q=alertname=HTTP_Probe_Failed,instance=web1", nil) @@ -354,6 +356,7 @@ var acTests = []acTestCase{ func TestAutocomplete(t *testing.T) { mockConfig() for _, version := range mock.ListAllMocks() { + t.Logf("Testing autocomplete using mock files from Alertmanager %s", version) mockAlerts(version) r := ginTestEngine() From 48ca69fb7caf21a58c187b243d7a8fd5dae64779 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Tue, 13 Feb 2018 22:52:56 +0000 Subject: [PATCH 2/2] Enable verbose output from go test --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b5162b3f7..b8efb22d2 100644 --- a/Makefile +++ b/Makefile @@ -132,7 +132,7 @@ mock-assets: .build/deps-build-go.ok .PHONY: test-go test-go: .build/vendor.ok - go test -bench=. -cover `go list ./... | grep -v /vendor/` + go test -v -bench=. -cover `go list ./... | grep -v /vendor/` .PHONY: test-js test-js: .build/deps-build-node.ok