From fdb01d39f1e8b90505a0423afd743cb8893e6485 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Mon, 27 Aug 2018 22:27:27 +0100 Subject: [PATCH] fix(ui): fix typos and make code more testable --- ui/src/Components/SilenceModal/SilenceSubmitProgress.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ui/src/Components/SilenceModal/SilenceSubmitProgress.js b/ui/src/Components/SilenceModal/SilenceSubmitProgress.js index 693291b3b..a19fd2fa3 100644 --- a/ui/src/Components/SilenceModal/SilenceSubmitProgress.js +++ b/ui/src/Components/SilenceModal/SilenceSubmitProgress.js @@ -51,6 +51,8 @@ const SilenceSubmitProgress = observer( submitState = observable( { + // store fetch result here, useful for testing + fetch: null, value: SubmitState.InProgress, result: null, markDone(result) { @@ -68,7 +70,7 @@ const SilenceSubmitProgress = observer( handleAlertmanagerRequest = () => { const { uri, payload } = this.props; - fetch(`${uri}/api/v1/silences`, { + this.submitState.fetch = fetch(`${uri}/api/v1/silences`, { method: "POST", body: JSON.stringify(payload), headers: { @@ -91,8 +93,11 @@ const SilenceSubmitProgress = observer( } else if (response.status === "error") { this.submitState.markFailed(response.error); } else { - this.submitState.markFailed(JSON.strigify(response)); + this.submitState.markFailed(JSON.stringify(response)); } + + // return status so we can assert it in tests + return response.status; }; componentDidMount() {