github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-11 03:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sanitize Alertmanager URI before putting it in /alerts.json reponse

Browse Source 
Alertmanager URI might contain basic auth username & password, we should replace password with 'xxx' in logs and and error messages.
Go will still print it in HTTP request errors, but that will be fixed in the next Go release - https://go-review.googlesource.com/c/go/+/102855
Fixes #259
This commit is contained in:
Łukasz Mierzwa
2018-04-26 10:05:40 -07:00
parent eab4c396df
commit fd0eb46adf
10 changed files with 156 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/CONFIGURATION.md
View File

@@ -67,6 +67,14 @@ alertmanager:
testing with JSON files, see [mock](/internal/mock/) dir for examples, files
in this directory are used for running tests and when running demo instance
of unsee with `make run`.
If URI contains basic auth info
(`https://user:password@alertmanager.example.com`) and you don't want it to
be visible to users then ensure `proxy: true` is also set.
Without proxy mode full URI needs to be passed to unsee web UI code.
With proxy mode all requests will be routed via unsee HTTP server and since
unsee has full URI in the config it only needs Alertmanager name in that
request.
`proxy: true` in order to avoid leaking auth information to the browser.
* `timeout` - timeout for requests send to this Alertmanager server, a string in
[time.Duration](https://golang.org/pkg/time/#ParseDuration) format.
* `proxy` - if enabled requests from user browsers to this Alertmanager will be