From e8d5715e04fcfcc7012425e5b40507da1681cd35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= <l.mierzwa@gmail.com>
Date: Mon, 25 Mar 2019 21:24:55 -0700
Subject: [PATCH] fix(ui): use flex for ordering filter elements

---
 .../Labels/FilterInputLabel/index.css         |  2 +-
 .../Labels/FilterInputLabel/index.js          | 48 +++++++++----------
 2 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/ui/src/Components/Labels/FilterInputLabel/index.css b/ui/src/Components/Labels/FilterInputLabel/index.css
index 3de3f2cad..97fcc246d 100644
--- a/ui/src/Components/Labels/FilterInputLabel/index.css
+++ b/ui/src/Components/Labels/FilterInputLabel/index.css
@@ -22,5 +22,5 @@
 
 .badge.components-filteredinputlabel > .close {
   /* make close button bigger, to match font size of the badge */
-  font-size: 1rem;
+  font-size: 100%;
 }
diff --git a/ui/src/Components/Labels/FilterInputLabel/index.js b/ui/src/Components/Labels/FilterInputLabel/index.js
index 9f225b40d..db41f6050 100644
--- a/ui/src/Components/Labels/FilterInputLabel/index.js
+++ b/ui/src/Components/Labels/FilterInputLabel/index.js
@@ -56,32 +56,18 @@ const FilterInputLabel = observer(
           f => f.hits !== alertStore.info.totalAlerts
         ).length > 0;
 
+      const rootClasses = filter.applied
+        ? cs.className
+        : [
+            "badge-secondary components-filteredinputlabel",
+            ...cs.baseClassNames
+          ].join(" ");
+
       return (
         <span
-          className={
-            filter.applied
-              ? cs.className
-              : [
-                  "badge-secondary components-filteredinputlabel",
-                  ...cs.baseClassNames
-                ].join(" ")
-          }
+          className={`${rootClasses} d-inline-flex flex-row`}
           style={cs.style}
         >
-          <button
-            type="button"
-            className="close ml-1"
-            style={cs.style}
-            onClick={() => alertStore.filters.removeFilter(filter.raw)}
-          >
-            <span
-              className={`align-text-bottom ${cs.colorClassNames
-                .filter(c => !c.match(/badge-/))
-                .join(" ")}`}
-            >
-              &times;
-            </span>
-          </button>
           {filter.isValid ? (
             filter.applied ? (
               showCounter ? (
@@ -99,9 +85,9 @@ const FilterInputLabel = observer(
               <FontAwesomeIcon icon={faExclamationCircle} />
             </span>
           )}
-          <TooltipWrapper title="Click to edit this filter">
+          <TooltipWrapper title="Click to edit this filter" className="my-auto">
             <RIEInput
-              className={showCounter ? "" : "align-middle"}
+              className="align-middle"
               defaultValue=""
               value={filter.raw}
               propName="raw"
@@ -109,6 +95,20 @@ const FilterInputLabel = observer(
               classEditing="py-0 border-0 bg-light"
             />
           </TooltipWrapper>
+          <button
+            type="button"
+            className="close ml-1 align-middle"
+            style={cs.style}
+            onClick={() => alertStore.filters.removeFilter(filter.raw)}
+          >
+            <span
+              className={cs.colorClassNames
+                .filter(c => !c.match(/badge-/))
+                .join(" ")}
+            >
+              &times;
+            </span>
+          </button>
         </span>
       );
     }