From e23b00c080c9c9b93cd599d87e8fae2c2c3dfd83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Sun, 3 Dec 2017 10:26:41 -0800 Subject: [PATCH] Fix listen address and port passing Only HOST & PORT env variables used by gin internally were really used, pass resulting config to gin so we match documentation, and log it on startup --- docs/example.yaml | 2 +- internal/config/config.go | 2 +- main.go | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/example.yaml b/docs/example.yaml index 964e29ad5..01b19dc45 100644 --- a/docs/example.yaml +++ b/docs/example.yaml @@ -25,7 +25,7 @@ labels: keep: [] strip: [] listen: - address: "*" + address: "0.0.0.0" port: 8080 prefix: / log: diff --git a/internal/config/config.go b/internal/config/config.go index c96dd1f26..4272983b4 100644 --- a/internal/config/config.go +++ b/internal/config/config.go @@ -62,7 +62,7 @@ func init() { pflag.StringSlice("receivers.strip", []string{}, "List of receivers to not display alerts for") - pflag.String("listen.address", "*", "IP/Hostname to listen on") + pflag.String("listen.address", "", "IP/Hostname to listen on") pflag.Int("listen.port", 8080, "HTTP port to listen on") pflag.String("listen.prefix", "/", "URL prefix") diff --git a/main.go b/main.go index 5981d52b7..20e31e5eb 100644 --- a/main.go +++ b/main.go @@ -1,6 +1,7 @@ package main import ( + "fmt" "html/template" "path" "strings" @@ -150,7 +151,9 @@ func main() { } setupRouter(router) - err := router.Run() + listen := fmt.Sprintf("%s:%d", config.Config.Listen.Address, config.Config.Listen.Port) + log.Infof("Listening on %s", listen) + err := router.Run(listen) if err != nil { log.Fatal(err) }