From cd63ee512e50354a01b3147af8c0e2d50125a73f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= <l.mierzwa@gmail.com>
Date: Wed, 5 Jul 2017 18:22:25 -0700
Subject: [PATCH] Fix metric updates for alert counters

Metrics were incremented but never reset, this fixes it
---
 alertmanager/models.go | 37 ++++++++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 5 deletions(-)

diff --git a/alertmanager/models.go b/alertmanager/models.go
index 322a927fa..026767923 100644
--- a/alertmanager/models.go
+++ b/alertmanager/models.go
@@ -68,6 +68,22 @@ func (am *Alertmanager) clearData() {
 	am.colors = models.LabelsColorMap{}
 	am.autocomplete = []models.Autocomplete{}
 	am.lock.Unlock()
+	// reset metrics to 0 since we don't store anything anymore
+	am.resetMetrics()
+}
+
+func (am *Alertmanager) resetMetrics() {
+	// reset alert state/instance counters
+	for _, state := range models.AlertStateList {
+		metricAlerts.With(prometheus.Labels{
+			"alertmanager": am.Name,
+			"state":        state,
+		}).Set(0)
+	}
+	// reset alert group counters
+	metricAlertGroups.With(prometheus.Labels{
+		"alertmanager": am.Name,
+	}).Set(0)
 }
 
 func (am *Alertmanager) pullSilences(version string) error {
@@ -137,6 +153,13 @@ func (am *Alertmanager) pullAlerts(version string) error {
 	dedupedGroups := []models.AlertGroup{}
 	colors := models.LabelsColorMap{}
 	autocompleteMap := map[string]models.Autocomplete{}
+
+	// we'll use this to update alert counter metrics (per state/instance)
+	alertMetrics := map[string]float64{}
+	for _, state := range models.AlertStateList {
+		alertMetrics[state] = 0
+	}
+
 	log.Infof("[%s] Processing unique alert groups (%d)", am.Name, len(uniqueGroups))
 	for _, ag := range uniqueGroups {
 		alerts := models.AlertList{}
@@ -172,11 +195,7 @@ func (am *Alertmanager) pullAlerts(version string) error {
 			alert.UpdateFingerprints()
 			alerts = append(alerts, alert)
 
-			// update internal metrics
-			metricAlerts.With(prometheus.Labels{
-				"alertmanager": am.Name,
-				"state":        alert.State,
-			}).Inc()
+			alertMetrics[alert.State]++
 		}
 
 		for _, hint := range transform.BuildAutocomplete(alerts) {
@@ -192,6 +211,14 @@ func (am *Alertmanager) pullAlerts(version string) error {
 		dedupedGroups = append(dedupedGroups, ag)
 	}
 
+	// update internal metrics with new computed values
+	for state, val := range alertMetrics {
+		metricAlerts.With(prometheus.Labels{
+			"alertmanager": am.Name,
+			"state":        state,
+		}).Set(val)
+	}
+
 	log.Infof("[%s] Merging autocomplete data (%d)", am.Name, len(autocompleteMap))
 	autocomplete := []models.Autocomplete{}
 	for _, hint := range autocompleteMap {