From 928b6d45bd28247cccd246ea50b9ab130f50e0e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Mon, 23 Dec 2019 16:07:46 +0000 Subject: [PATCH] fix(ci): don't try to load fonts on Percy This ensures that the grid renders correctly, since load events don't seem to trigger on storybook and grid is not repacked after element heights changes. --- ui/src/App.tsx | 1 + ui/src/Styles/App.scss | 3 --- ui/src/Styles/FontBundle.scss | 2 ++ ui/src/Styles/Fonts.scss | 2 -- 4 files changed, 3 insertions(+), 5 deletions(-) create mode 100644 ui/src/Styles/FontBundle.scss diff --git a/ui/src/App.tsx b/ui/src/App.tsx index d16f02f2b..7c1cd53cc 100644 --- a/ui/src/App.tsx +++ b/ui/src/App.tsx @@ -15,6 +15,7 @@ import { BodyTheme, ThemeContext } from "Components/Theme"; import { ErrorBoundary } from "./ErrorBoundary"; import "Styles/ResetCSS.scss"; +import "Styles/FontBundle.scss"; import "Styles/App.scss"; // https://github.com/facebook/react/issues/14603 diff --git a/ui/src/Styles/App.scss b/ui/src/Styles/App.scss index adbf47654..08cf7dd3b 100644 --- a/ui/src/Styles/App.scss +++ b/ui/src/Styles/App.scss @@ -1,6 +1,3 @@ -// bundled font assets, so we don't need to talk to Google Fonts API -@import "~typeface-open-sans/index.css"; - .cursor-pointer { cursor: pointer; } diff --git a/ui/src/Styles/FontBundle.scss b/ui/src/Styles/FontBundle.scss new file mode 100644 index 000000000..5841cf475 --- /dev/null +++ b/ui/src/Styles/FontBundle.scss @@ -0,0 +1,2 @@ +// bundled font assets, so we don't need to talk to Google Fonts API +@import "~typeface-open-sans/index.css"; diff --git a/ui/src/Styles/Fonts.scss b/ui/src/Styles/Fonts.scss index 9e39beb35..1c9a5539d 100644 --- a/ui/src/Styles/Fonts.scss +++ b/ui/src/Styles/Fonts.scss @@ -11,5 +11,3 @@ $font-weight-bold: 600; $font-family-sans-serif: "Open Sans", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol" !default; - -@import "~typeface-open-sans/index.css";