From 64aa544be1175bd80d034985267bb23c5fb3cdea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Tue, 8 Oct 2019 21:19:54 +0100 Subject: [PATCH 1/3] chore(ui): tweak filter input css --- ui/src/Components/Labels/FilterInputLabel/index.js | 2 +- ui/src/Components/Labels/FilterInputLabel/index.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/src/Components/Labels/FilterInputLabel/index.js b/ui/src/Components/Labels/FilterInputLabel/index.js index 056a3fa5c..da489d9f9 100644 --- a/ui/src/Components/Labels/FilterInputLabel/index.js +++ b/ui/src/Components/Labels/FilterInputLabel/index.js @@ -98,7 +98,7 @@ const FilterInputLabel = observer( value={filter.raw} propName="raw" change={this.onChange} - classEditing="py-0 border-0 bg-light" + classEditing="py-0 border-0 bg-light text-black rounded" afterStart={alertStore.status.pause} afterFinish={alertStore.status.resume} /> diff --git a/ui/src/Components/Labels/FilterInputLabel/index.scss b/ui/src/Components/Labels/FilterInputLabel/index.scss index 879adeedd..2574b1963 100644 --- a/ui/src/Components/Labels/FilterInputLabel/index.scss +++ b/ui/src/Components/Labels/FilterInputLabel/index.scss @@ -15,7 +15,7 @@ &:hover { background-color: $light; color: $black; - border-radius: 4px; + border-radius: 0.25rem; } } From 48b906b887e6f44cf446d77a2bf7a3bc2715a2de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Tue, 8 Oct 2019 21:24:41 +0100 Subject: [PATCH 2/3] chore(ui): use mug-hot icon for empty grid --- .../Grid/EmptyGrid/__snapshots__/index.test.js.snap | 6 +++--- ui/src/Components/Grid/EmptyGrid/index.js | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/src/Components/Grid/EmptyGrid/__snapshots__/index.test.js.snap b/ui/src/Components/Grid/EmptyGrid/__snapshots__/index.test.js.snap index 5b20e7684..9e3f2b5fa 100644 --- a/ui/src/Components/Grid/EmptyGrid/__snapshots__/index.test.js.snap +++ b/ui/src/Components/Grid/EmptyGrid/__snapshots__/index.test.js.snap @@ -6,15 +6,15 @@ exports[` matches snapshot 1`] = ` diff --git a/ui/src/Components/Grid/EmptyGrid/index.js b/ui/src/Components/Grid/EmptyGrid/index.js index 9bdb71b21..beeadd886 100644 --- a/ui/src/Components/Grid/EmptyGrid/index.js +++ b/ui/src/Components/Grid/EmptyGrid/index.js @@ -1,13 +1,13 @@ import React from "react"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; -import { faCheckCircle } from "@fortawesome/free-solid-svg-icons/faCheckCircle"; +import { faMugHot } from "@fortawesome/free-solid-svg-icons/faMugHot"; import "./index.scss"; const EmptyGrid = () => (

- +

); From 65510acdf3c2b9760cad8b08de4a85e628531d35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Tue, 8 Oct 2019 22:01:13 +0100 Subject: [PATCH 3/3] chore(ui): tweak internal error message css --- ui/src/ErrorBoundary.js | 32 +++++++++++++------ .../__snapshots__/ErrorBoundary.test.js.snap | 22 ++++++++++--- 2 files changed, 40 insertions(+), 14 deletions(-) diff --git a/ui/src/ErrorBoundary.js b/ui/src/ErrorBoundary.js index 242f73fc8..0b4e0d003 100644 --- a/ui/src/ErrorBoundary.js +++ b/ui/src/ErrorBoundary.js @@ -4,28 +4,41 @@ import PropTypes from "prop-types"; import * as Sentry from "@sentry/browser"; import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; -import { faExclamationCircle } from "@fortawesome/free-solid-svg-icons/faExclamationCircle"; +import { faBomb } from "@fortawesome/free-solid-svg-icons/faBomb"; -const InternalError = ({ message, secondsLeft }) => ( +const InternalError = ({ message, secondsLeft, progressLeft }) => (

- + Internal error

-

{message}

-

+

+ {message} +

+

This page will auto refresh in {secondsLeft}s + + +

); InternalError.propTypes = { message: PropTypes.node.isRequired, - secondsLeft: PropTypes.number.isRequired + secondsLeft: PropTypes.number.isRequired, + progressLeft: PropTypes.number.isRequired }; class ErrorBoundary extends Component { @@ -68,6 +81,7 @@ class ErrorBoundary extends Component { ); } diff --git a/ui/src/__snapshots__/ErrorBoundary.test.js.snap b/ui/src/__snapshots__/ErrorBoundary.test.js.snap index 9ad7d293f..7afcbb79a 100644 --- a/ui/src/__snapshots__/ErrorBoundary.test.js.snap +++ b/ui/src/__snapshots__/ErrorBoundary.test.js.snap @@ -8,14 +8,14 @@ exports[` matches snapshot 1`] = ` @@ -23,11 +23,23 @@ exports[` matches snapshot 1`] = ` Internal error -

+

Error: Error thrown from problem child

-

+

This page will auto refresh in 60s + + + +