github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-05 03:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ui): drop alert count from silence preview

Browse Source 
This will be confusing since we deduplicate receivers, drop the count and more info
This commit is contained in:
Łukasz Mierzwa
2018-10-06 19:23:57 +01:00
parent 9de7e9a738
commit 6b08fc88cc
2 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
ui/src/Components/SilenceModal/SilencePreview/__snapshots__/index.test.js.snap
View File

@@ -2,17 +2,13 @@
exports[`<SilencePreview /> matches snapshot 1`] = `
"
<div class=\\"mb-2\\">
<div class=\\"mb-3\\">
<p class=\\"lead text-center\\">
This silence will match
<strong>
3
</strong>
alerts
Unique alert label sets (without receiver) matching this silence.
</p>
<div>
<ul class=\\"list-group list-group-flush px-2\\">
<li class=\\"list-group-item px-2 pt-2 pb-1\\">
<ul class=\\"list-group list-group-flush\\">
<li class=\\"list-group-item px-0 pt-2 pb-1\\">
<span class=\\"components-label text-nowrap text-truncate badge badge-dark mw-100\\">
alertname: foo
</span>
@@ -23,7 +19,7 @@ exports[`<SilencePreview /> matches snapshot 1`] = `
instance: foo1
</span>
</li>
<li class=\\"list-group-item px-2 pt-2 pb-1\\">
<li class=\\"list-group-item px-0 pt-2 pb-1\\">
<span class=\\"components-label text-nowrap text-truncate badge badge-dark mw-100\\">
alertname: bar
</span>
@@ -34,7 +30,7 @@ exports[`<SilencePreview /> matches snapshot 1`] = `
instance: bar1
</span>
</li>
<li class=\\"list-group-item px-2 pt-2 pb-1\\">
<li class=\\"list-group-item px-0 pt-2 pb-1\\">
<span class=\\"components-label text-nowrap text-truncate badge badge-dark mw-100\\">
alertname: bar
</span>

13
ui/src/Components/SilenceModal/SilencePreview/index.js
View File

@@ -29,9 +29,9 @@ FetchError.propTypes = {
};
const Preview = ({ alertStore, labelsList }) => (
<ul className="list-group list-group-flush px-2">
<ul className="list-group list-group-flush">
{labelsList.map(labels => (
<li key={hash(labels)} className="list-group-item px-2 pt-2 pb-1">
<li key={hash(labels)} className="list-group-item px-0 pt-2 pb-1">
{Object.entries(labels).map(([name, value]) => (
<StaticLabel
key={name}
@@ -61,6 +61,8 @@ const SilencePreview = observer(
alertLabels: [],
error: null,
fetch: null,
// take a list of groups and outputs a list of label sets, this ignores
// the receiver, so we'll end up with only unique alerts
groupsToUniqueLabels(groups) {
const alerts = {};
for (const group of groups) {
@@ -123,15 +125,14 @@ const SilencePreview = observer(
return (
<React.Fragment>
<div className="mb-2">
<div className="mb-3">
{this.matchedAlerts.error !== null ? (
<FetchError message={this.matchedAlerts.error} />
) : (
<React.Fragment>
<p className="lead text-center">
This silence will match{" "}
<strong>{this.matchedAlerts.alertLabels.length}</strong> alert
{this.matchedAlerts.alertLabels.length > 1 ? "s" : ""}
Unique alert label sets (without receiver) matching this
silence.
</p>
<div>
<Preview