From 62555df1b0b61da8a97c65f81ba3bad618fa9c97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Sat, 3 Mar 2018 14:05:49 -0800 Subject: [PATCH] Use the correct variable in tests 'es.JiraURL == es.JiraURL' is always true, it should compare es with gs. Fix it and reformat for readability --- api_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api_test.go b/api_test.go index dd7b0455a..08fe1d619 100644 --- a/api_test.go +++ b/api_test.go @@ -870,7 +870,10 @@ func testAlert(version string, t *testing.T, expectedAlert, gotAlert models.Aler for _, es := range expectedAM.Silences { foundSilence := false for _, gs := range gotAM.Silences { - if es.Comment == gs.Comment && es.CreatedBy == gs.CreatedBy && es.JiraID == gs.JiraID && es.JiraURL == es.JiraURL { + if es.Comment == gs.Comment && + es.CreatedBy == gs.CreatedBy && + es.JiraID == gs.JiraID && + es.JiraURL == gs.JiraURL { foundSilence = true } }